lmcjt37 / l3digital Goto Github PK
View Code? Open in Web Editor NEWWebsite for l3digital
Home Page: https://l3-digital.lmcjt.now.sh
Website for l3digital
Home Page: https://l3-digital.lmcjt.now.sh
Use GraphQL to grab the data and populate the page with project items.
The same process used in the index page can be re-used here.
Testing in Safari showed that the text isn't animating as expected or as in comparison to how it appears in Chrome.
Looking at adding a deploying to Zeit now - https://zeit.co/now
We can then add an alias for the domain l3digital.co.uk to have everything hook together with free hosting.
Bonus:: setup custom email addresses.
According to GatsbyJS, we shouldn't use the to reference to external links.
https://www.gatsbyjs.org/docs/gatsby-link/?no-cache=1#use-link-only-for-internal-links
There should be better links to access sub pages of the projects section.
This includes a better way of navigate back up to display all projects.
When viewing a page such as projects or about-us, if the screen width is 737px-979px then the image widths are 100%. Images at this size consume too much of the page and isn't a great UX.
Missing config vars as not inheriting from parent environment
Typically informational sections use a base colour background and show copy and an image. A suggestion would be to create some shapes or change the background for these sections so that it splits the content and looks more pleasant.
Home page has an example of where this could be applied.
When in production and navigating back to the home screen. It loads the home page and then navigates an exit and then enter incorrectly.
The website lacks flourishes to help us stand out - here's some I was thinking about
The tooling used to develop and deploy the website should be reviewed.
Suggestions for other tooling options, or to add further tooling.
Current: Simple fade in/out transition
Suggestion: https://tympanus.net/Tutorials/PageRevealEffects/
The information shown to the side of the email form needs updating.
Should probably be pulled from Contentful.
Dividers are not appearing on Safari browsers.
These dividers use inline SVG, where this could be the reason that they are not appearing.
It could be mark-up, or XML parsing, or the simple reason Safari browsers doesn't support these SVGs.
These are found in the menu and footer.
Need to create accounts and link these up correctly. If not wanted then the icons/links need removing.
Needs testing across different browsers, especially Safari and IE.
Current implementation is commented out as it doesn't work consistently.
Project pages are missing the header and footer. Seems this would be resolved by making sure these are wrapped with the layout component.
Once the PR for welcome information is merged, there will be scope to add in some scrolling animations.
https://www.gatsbyjs.org/packages/gatsby-plugin-page-transitions/
example: https://github.com/mongkuen/gatsby-plugin-page-transitions/tree/master/examples
Something similar to the "Sentry provides answers" section here https://sentry.io/welcome/
Would make the page look more meatier and could include information about what we can do at L3.
Based on current situation of having a main employment, if the site went live detailing who was in the team it may look bad.
Remove?
Tested on iPhone XR
When scrolling, the banners continues to update. Could be related to #56
Only seen on the home screen.
Image is defined in the element but seems something is constraining it so that it doesn't appear.
Some images from the template are still being used and could do with being updated.
Removing the redundant assets - #19
Investigate the slow loads of assets, noticed on /about page.
Make use of 'sharp' plugin, and others not being used.
I think the banner on the home screen should cover the full height of the screen it is rendering.
Example could be taken from my personal site - https://lmcjt.com
Looks like the production app is being deployed before promotion from staging.
Possibly a hangover from initial development process.
The banners are a default component which needs updating.
The default image is still existing from initial setup and needs updating maybe?
Tested on iPhone 6S - iOS 11.4.1
All you see is the dark blue background and the header component isn't appearing. It seems you are still able to click the tag of the logo to reload the home page, but this isn't visible either.
The rest of the page and sub-pages appear to load and render correctly.
Suspected cause is the implementation of the tertiary logic for and
This requires updating some packages, see article below for details
https://www.gatsbyjs.org/blog/2019-02-20-introducing-use-static-query/
The addition of hooks would allow us to abstract the queries and remove the need for repetitive query code.
The grow and rotate is too much.
Remove rotate and make scale slower?
Project page needs section content trimming or the imagery vertically centering to improve look
Add any missing explanations for new users and the package scripts that haven't been detailed.
Migrate to Gatsby V2
Resolve any dependency issues, including auditing node modules and resolving peer dependencies.
This is down to there not being the correct page nodes created for project pages with a parent of projects.
If the pages were l3digital.co.uk/projects/<project_page>
then we could use the partiallyActive
prop to identify projects as the parent, enhancing the menu.
As previously missed from the index page.
V2 has significant migration changes, one of which is that pages aren't automatically wrapped with the layout/index.
Simply need to import and wrap all returned renders with Layout
Back button (new) needs some margin. This should come from the section wrappers probably.
This may require bumping the node and npm versions in the engines
object of package.json
You can then run npm audit
for more details
Some sort of error reporting could also help for coverage...
In the past I have used nyc - https://www.npmjs.com/package/nyc which is easily modifiable.
When accessing projects and specifically individual pages. The back button only goes back to '/projects' but if we know the from location we can return the user properly to the previous page.
When viewing on mobile (iPhone XR), upon load the dynamic header meant for desktop only loads. As you scroll, the mobile header then renders.
I would suspect that the screen width for mobile browsers isn't working correctly?
Follow article to make absolute paths relative and more readable.
https://www.gatsbyjs.org/docs/add-custom-webpack-config/#absolute-imports
Banner images appear to be loading in slowly, to the point where I'm seeing them part load
Speed test for checking difference.
[30ping | 8.45Mbps download | 0.96Mbps Upload]
A number of invalid prop type errors are appearing in the console
Failed prop type: HomeIndex: prop type 'data' is invalid; it must be a function, usually from React.PropTypes.
Failed prop type: Invalid prop 'description' of type 'object' supplied to 'IndexArticle', expected 'string'.
Investigate cause...
edit: There are scroll events on the home page that do not work on Safari browser.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.