lmmendes/datadog_buildpack

datadog_buildpack's Issues

STD_LOG_COLLECTION_PORT & LOGS_CONFIG variables

We should allow people to specify STD_LOG_COLLECTION_PORT and LOGS_CONFIG source attribute.

Where STD_LOG_COLLECTION_PORT value should match the LOGS_CONFIG port attribute.

And LOGS_CONFIG source attribute should also have a default, eg: pcf but be able to be defined in case users wish to change the configuration of their logback-spring.xml and have a different playload.

      STD_LOG_COLLECTION_PORT: 10514
      LOGS_CONFIG: '[{"type":"tcp","port":"10514","source":"pcf-source-v1", "service":" nebula-sandbox-app"}]'

Question, should be search for a LOGS_CONFIG_SOURCE in the vcap service variables and if not set we would default to pcf?

App version

If datadog vcap service doesn't define a DD_VERSION the default version should be retrieved from META-INF file that exists under the app folder, it has the following structure:

Manifest-Version: 1.0
Created-By: Maven Jar Plugin 3.2.0
Build-Jdk-Spec: 11
Implementation-Title: nebula
Implementation-Version: 0.1.0-SNAPSHOT
Main-Class: org.springframework.boot.loader.JarLauncher
Start-Class: io.mb.nebula.NebulaApplication
Spring-Boot-Version: 2.3.8.RELEASE
Spring-Boot-Classes: BOOT-INF/classes/
Spring-Boot-Lib: BOOT-INF/lib/
Spring-Boot-Classpath-Index: BOOT-INF/classpath.idx

This is a safer approach in my option than trying to find the POM file under the META-INF folder because it requires us to know the artifact group and id, or using a glob and trying to find the pom.xml or pom.properties under that folder.

Also this approach would have to be adapted if gradle was used.