loewen-hob/rembg-comfyui-node-better

Rembg Background Removal Node for ComfyUI- you can choose which onnx model to use!

rembg-comfyui-node-better's Issues

SAM model getting an error

Hi, great to see this node!

I'd love to use the SAM upscale model. However, I'm getting an error.

My steps are:

1. Download the SAM encoder and decoder.
2. Place them in the models/checkpoints folder.
3. Set the model in rembg node to 'sam'
4. When I run it, I get the following error:

Error occurred when executing Image Remove Background (rembg):

'{}' is not of type 'array'

Failed validating 'type' in schema:
    {'items': {'properties': {'data': {'items': {'type': 'number'},
                                       'type': 'array'},
                              'label': {'type': 'integer'},
                              'type': {'type': 'string'}},
               'type': 'object'},
     'type': 'array'}

On instance:
    '{}'

  File "/Users/jo/Documents/dev/ComfyUI/execution.py", line 151, in recursive_execute
    output_data, output_ui = get_output_data(obj, input_data_all)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jo/Documents/dev/ComfyUI/execution.py", line 81, in get_output_data
    return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jo/Documents/dev/ComfyUI/execution.py", line 74, in map_node_over_list
    results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jo/Documents/dev/ComfyUI/custom_nodes/rembg-comfyui-node-better/__init__.py", line 38, in remove_background
    image = pil2tensor(remove(tensor2pil(image), session = session))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/rembg/bg.py", line 260, in remove
    masks = session.predict(img, *args, **kwargs)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/rembg/sessions/sam.py", line 169, in predict
    validate(instance=prompt, schema=schema)
  File "/opt/homebrew/lib/python3.11/site-packages/jsonschema/validators.py", line 1312, in validate
    raise error

Do you know where I'm going wrong? I saw the README says 'The sam model is not easy to use, and I'd like to refine this feature in the future.' Are you able to share what instructions you followed to get it working?