logeth/commissions

A Repository Containing Log's Commissions

Wassup, im Log (You might know me from discord) 👋

Just like the person reading this, I like coding

I don't really know what else to put here

commissions's Issues

StrategyRARIcDAI.sol Review

• commissions/Awaiting Commissions/StrategyRARIcDAI.sol

  Lines 51 to 52 in a8e8700

  	// cDAI and fcDAI are auto compounding by default, so this contract needs to track its profits itself using this variable
  	uint StampBalance;

  Why keep track of assets if you have exchangeRate?

• commissions/Awaiting Commissions/StrategyRARIcDAI.sol

  Lines 74 to 90 in a8e8700

  	_profit = sub(estimatedTotalAssets(), StampBalance); // _profit is in DAI
  	fcDAI.redeemUnderlying(div(mul(_profit, cDAI.exchangeRateCurrent()), 10e18)); // Multiply then remove 18 decimals (big to small, Rule 2)
  	cDAI.redeemUnderlying(_profit);
  	StampBalance = estimatedTotalAssets();
  	fcDAI.redeemUnderlying(div(mul(_debtOutstanding , cDAI.exchangeRateCurrent()), 10e18)); // Multiply then remove 18 decimals (big to small, Rule 2)
  	cDAI.redeemUnderlying(_debtOutstanding);
  	StampBalance = sub(StampBalance, _debtOutstanding);
  	_loss = 0; // It is impossible to lose money from this stratagy, so loss is always zero.
  	// (Unless compound gets hacked.. but then this vault will probably be the least of your concerns.)
  	_debtPayment = 0; // No debts are paid
  	return (_profit, _loss, _debtPayment);

  why call two times to reedemUnderlying? Can't you estimate profits with exchangeRate and make the difference between that value and vault.strategies(address(this))['totalDebt']?

• commissions/Awaiting Commissions/StrategyRARIcDAI.sol

  Line 88 in a8e8700

  _debtPayment = 0; // No debts are paid

  you need to pay the debtOutstanding, no matter profit or loss. Why is it always 0?

• commissions/Awaiting Commissions/StrategyRARIcDAI.sol

  Line 101 in a8e8700

  debtOutstanding = add(debtOutstanding, _debtOutstanding); // Keep track of debt to the vault

  the vault does this for you with a method called: vault.debtOutstanding(strategy) or with vault.strategies(address(this))['totalDebt'].
• To simplify the 3 strategies DAI, USDC and USDT, you can have a clone method and make the cToken, fcTooken and Oracle parameters of the constructor.
• Do you have tests for these strategies?
• What's the estimated APR?