loomnetwork/gamechain

gamechain's Issues

[Backend] Account Service

We need an account server for the user to sign up and login from the GUI and keep data to Dapp.

Functionality:

• Sign Up

• Login

Some Text is hidden After Game End Pop-up appears

http://prntscr.com/kea217

Long Text/Name should be ellipsized and set a max character limit for saving a Horde name

http://prntscr.com/ke9x5y

Fetching ListDecks, when there is no deck

Getting an error when try to fetch getDeck when all the decks are deleted.
Should not return null reference
Should return empty array

Error
===== Deck Data Not Loaded from Backed ===== System.NullReferenceException: Object reference not set to an instance of an object

Tutorial should not be visible again if user quits the tutorial before

Tutorial is visible everytime user clicks on Play Button

https://www.useloom.com/share/1a8de0d9df5444e59249d28d45b562f5

Research On Randomness

The game uses a lot of randomness. For example:

• Draw a card
• Random Attack
• Random summon zombies.
• more..

The contract must be able to generate random number without any consensus error when running on multiple validators.

Add Integration Test on Deck

Test cases to cover:

• List
• Get
• Create
• Update
• Delete

Tasks:

1. Get basic understanding of e2e test. See function TestE2E in e2e/e2e_test.go
2. Create a new yaml test case in e2e. Examples can be found in e2e/test_cases.yaml
3. Add more test cases to send a request in RunCmd and check validity of the output in Expected
4. Run the test make test

Add Deck

Always have to Add Deck with Hero id and 0 Cards

"heroId": 0,
     "name": "Deck 1",
     "cards": []

Pack opener screen is empty

There are no packs to open or display at pack opener screen.

screenshot- http://prntscr.com/kcqq1d

[Backend] Add Deck to user

The user should be able to manage deck from his cards.

• Create
• Read
• Update
• Delete

A blank screen appears for 10 seconds after starting the game, if user is playing the game in non-windowed mode(Using full screen)

Better to show some Loading/Progress bar rather than showing a complete blank screen

[Backend] Add Card Libary

Add card library

Use similar Fonts and Styling for Numbers and Text

http://prntscr.com/ke9sai

[Backend] Add PurchasePack

Requirements From frontend:

/purchasePacks POST
Sent parameters:
Packs: Int, number of packs the user has purchased. This increases the Packs parameter of the player profile
Based on the purchase method and platform, the server might want to have some security checks to validate the purchase.

Terms and Conditions pop-up should appear only once.

TnC pop-up should not be visible again if user accepts it by clicking on GOT IT button.

video- https://www.useloom.com/share/56a8edc1bd404860b6ef910f80a475c0

Animation is not smooth in tutorial when zombie cards are clashing

please observe the animation/transition when two zombie cards are clashing.

video - https://www.useloom.com/share/907bae23021f4f74a2c949c5dc285b83

Tutorial should stop if user clicks on Back button provided on the Top left corner

Tutorial is still playing on front(over quit pop-up) if user clicks on back button.

video- https://www.useloom.com/share/1a8de0d9df5444e59249d28d45b562f5

User is Not able to see the Typed Text/Name while editing the Name of his new Horde

https://www.useloom.com/share/80799924e273464b834cdc16774d980e

More meaningful output format when running cli

Currently we have commands:

• create_account
• get_account
• update_account
• get_decks
• create_deck
• delete_deck

But when running these command, we get nothing back or just simple Go struct e.g.

{loom false false false Image2 false 0 0 3 [100 101 102 97 117 108 116 0 74 190 12 219 233 52 88 240 118 171 244 175 157 83 214 185 225 216 103 226]}

The requirements for this issue it to format output so that it can be find by e2e test, which relies on finding patterns on standard output and error

Also, the input to command line should be minimal so we can add it in test cases.

[Suggestion]- No option in tutorial to mute/unmute sound

Account Integration with LoomAuth

The game play should allow the user to login using the account from LoomAuth.

Ref: Account Flow

• Setup local Vault server to work with LoomAuth
• Authenticate user in LoomAuth
• Create and Store private key in Vault
• The frontend fetches the private key in Vault
• Get user information

Delete Default Deck

Client side is able to delete default Deck.
but server side is not allow deleting default deck.

[Backend] Init Card and Collection

We need to provide 2 functionality for the unity client so that the client can have a view of cards and collection. We can now just fix the data in the init call when deploying the contract.

1. Card
2. Collection

Add Integration Test on Hero

Method to be covered:

• Add
• ...

Cli output for get_account and update_account should list all account fields

cli's get_account and update_account should display all account field, like image, game_membership_tier.

This would help us to test update account functionality properly.

GetDeck Error

Getting an Null from Backend, When there is no deck available.
Should not return Null.

it should have empty array
{
"decks": []
}

[Frontend] PurchasePack

TBD

Merge Frontend with `playtest`

Try to merge some code that connects to backend to the playtest branch.

The backend method calls currently supported:

• Account
• Deck

[Backend] Card contract functionality

Card contract should support the following functionality:

• List(addr loom.Address)
• Get(addr loom.Address, cardID string)
• Total(addr loom.Address, cardUID string)
• Transfer(to loom.Address)

Not able to add Deck

There are some scenario when player select some cards while creating new deck or edit deck, but not able to save deck or add deck because of following exception
you cannot add more than 0 for your card id: 0

The tutorial seems to be incorrect at the end if someone is not following exact Tutorial steps

In the end, it is demonstrated that You won the match but It is clearly visible that Hero zombie is still on Battleground.

video- https://www.useloom.com/share/197c553b4d4140cda0a2c1a2383f1f66

Please correct the Pop-up Text message

Incorrect text - Do you really wan't to delete default

Correct text- Do you really want to delete default

Screenshot- http://prntscr.com/kcribe

[Unity] Game fetch decks and cards from zb.

Unity should fetch user profile containing decks and cards from zb smart contract.

User is not able to Go back or skip tutorial from tutorial video

User should be allowed to skip tutorial anytime while watching tutorial

User should not be allowed to Save a blank Horde

http://prntscr.com/ke9t8m

User is not able to see bottom section completely in windowed mode

If user is playing in windowed mode bottom section is slightly cropped

[Backend] Gameplay Contract functionality

Gameplay contract should able to work with Card Contract for the followings:

• Init
• Play

Tutorial is Incorrect

If any user is not following the exact tutorial steps then tutorial seems to be incorrect.

just like in this video I finished the game earlier by not following the tutorials steps but I am still getting instructions to finish the game.

video - https://www.useloom.com/share/ef53debb6fb8421c87bc94954a81c77e

Tutorial is still moving forward after clicking on Back button

User should be allowed to leave/skip tutorial by clicking on back button but Tutorial is still progressing after clicking on Back button

video- https://www.useloom.com/share/07d2bad476144978b1d03f487c95324a

[Backend] Separated Card contract

• Card contract should be separated from game play.
• Card contract should run on it's own code base in Go.

No tutorial How to use Max +/- button at pack opener screen

http://prntscr.com/kcqrtc

[Unity] Call ListCardLibrary Method

The frontend should call ListCardLibrary to get all the card info. The result is a collection of cards grouped by element.

[Backend] Add test case

Add test case to the contract

Buy Now button is not working

No response/message after user clicks on Buy Now button

screenshot- http://prntscr.com/kcqol9

Add Hero Management

The frontend should be able to get the details of the heroes, specific for a certain user. Heroes can level up, and abilities for them can be bought and unlocked.

Methods:

• ListHeroes()
• GetHero(hero_id)
• GetHeroAbility(ability_id)
• AddExperience(hero_id, amount)
• UpdateHero(hero_data)

Ref: https://docs.google.com/document/d/1jAd2kPND5zKYuIT3xZsIeZL41NP83d81v3lXFfruQrw/edit#

[Backend] A tool to import/export Card from JSON

We have UI to allow user to create cards and export to JSON. We need a tool to convert those JSON to Card contract

[Backend] Add OpenPack

Requirements from frontend:

/openPack GET
 
Called once every time a user opens a pack.
Upon checking that the user has indeed a pack to open (Packs parameter of profile), it will decrease the Packs parameter of 1. Will return:
cardsFound: [id1, id2, id3, id4, id5], the server returns an array of strings, containing 5 ids (or the number of cards that can be found in each pack), chosen randomly based on the rarity of the cards. It also immediately adds those 5 cards to the Collection parameter of the user profile. The client will then show the new 5 cards to the user.

[Backend] Refactor cli

• Remove PersistentPreRunE because not all the command need PrivKey and RPC
• Group all the init functions in to one init function. [optional] - styling choice

Change CardID to Card Name

• Change card_id (int) to CardName(string)

[Backend] Refactor Code

Styling

• rename filename using Go's convention.
  e.g. createAccount.go --> create_account.go
• reformat error message using golinter
  e.g user already exists.\n -> no ., no \n,
  fmt.Errorf("invalid JSON passed in value field. Error: %s\n", err.Error()) -> no ., no \n
• the name of cli subcommand should be all small letters:
  ./bin/cli createAccount --> should be create-account or create_account

Functional

• change the method receiver that does not internal state to just a normal function.
  e.g. func (z *ZombieBattleground) deleteDecks(...) --> should be just deleteDecks(...)