loopj/aiovantage

Python library for interacting with and controlling Vantage InFusion home automation controllers.

aiovantage's Issues

Omni sensors for SDM12 are not reporting sensor values

Checklist

• This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
• This issue is not a duplicate issue of currently previous issues..

Describe the issue

Sensors for SDM12 (temperature, current, power) are not reporting values.

But, as soon as DC is connected, and the SDM12 is selected in the DC UI, the sensors start reporting.
Close DC, or change focus to a different object, and sensors stop reporting again.

I am not 100% sure, but sensors for SDM12 did work when introduced, so may have stopped working some point later.

I noticed this with SDM12's, but it may apply to other omni sensors as well.

I could not confirm if temperature is reported, as DC in v4.6 that I tested with did not show temperature, at least I could not find it in the UI, have not tested with DC 4.7 yet.

Reproduction steps

• Run monitor_omni_sensors.py, or add SDM12 sensors to HA dashboard.
• Observe that there are no values reported.
• Launch DC, connected to controller, focus on a SDM12 module.
• Observe that sensor values are now reported every few seconds.
• But only for the selected module.
• Change DC focus to a different module and observe values now reported for that module.
• Close DC and sensor values stop being reported.

Add support for Thermostats

Checklist

• This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
• This issue is not a duplicate feature request of previous feature requests.

Describe the feature you'd like

Expose thermostats attached to a Vantage system through a `vantage.thermostats' controller.

Additional context

No response

IDiagnostic.SetFirewallConfiguration() missing brace in API declaration.

Checklist

• This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
• This issue is not a duplicate issue of currently previous issues..

Describe the issue

Looks like a missing closing brace, I can guess where it goes, but I don't know the source of the API declaration, so leaving it to you to fix.

IDiagnostic.SetFirewallConfiguration(OpenPorts: {TCP: List[int], UDP: List[int], ICMP: bool)

Maybe IDiagnostic.SetFirewallConfiguration(OpenPorts: {TCP: List[int], UDP: List[int], ICMP: bool})

Btw, where is this documented?

Reproduction steps

Noticed in VSCode warning about a missing brace.

Loads with LoadType of `[MDR8RW101]` should be classed as relays

Checklist

• This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
• This issue is not a duplicate issue of currently previous issues..

Describe the issue

Loads with LoadType of [MDR8RW101] should be classed as relays

Reproduction steps

n/a

Received response: "Failed" (Error code 12)

Using main source from v0.2.2.
Running dump_system.py:

2023-06-20 10:41:53,762 [MainThread  ] [DEBUG] Sending command: INVOKE 870 Task.GetState
2023-06-20 10:41:53,773 [MainThread  ] [DEBUG] Received response: CommandResponse(command='INVOKE', args=['870', '1', 'Task.GetState'], data=[])
2023-06-20 10:41:53,775 [MainThread  ] [DEBUG] Sending command: ELLOG STATUS ON
2023-06-20 10:41:53,781 [MainThread  ] [INFO ] TasksController fetched full state
2023-06-20 10:41:53,791 [MainThread  ] [DEBUG] Received response: "Failed" (Error code 12)
2023-06-20 10:41:53,792 [MainThread  ] [DEBUG] Sending command: ELENABLE STATUSEX ON
2023-06-20 10:41:53,808 [MainThread  ] [DEBUG] <asyncio.sslproto.SSLProtocol object at 0x0000025BB0531E50>: Fatal error on transport
Traceback (most recent call last):
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.1264.0_x64__qbz5n2kfra8p0\Lib\asyncio\sslproto.py", line 644, in _do_shutdown
    self._sslobj.unwrap()
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.1264.0_x64__qbz5n2kfra8p0\Lib\ssl.py", line 983, in unwrap
    return self._sslobj.shutdown()
           ^^^^^^^^^^^^^^^^^^^^^^^
ssl.SSLError: [SSL: APPLICATION_DATA_AFTER_CLOSE_NOTIFY] application data after close notify (_ssl.c:2702)
2023-06-20 10:41:53,813 [MainThread  ] [DEBUG] <_ProactorSocketTransport fd=1028> received EOF
2023-06-20 10:41:53,814 [MainThread  ] [DEBUG] <asyncio.sslproto.SSLProtocol object at 0x0000025BAEF37990> received EOF
2023-06-20 10:41:53,827 [MainThread  ] [DEBUG] Close <ProactorEventLoop running=False closed=False debug=True>

Exception emitted by connection.py:

        # Re-raise all other exceptions, including "R:ERROR" responses
        if isinstance(response, Exception):
            raise response

aiovantage.log

Re-fetch objects when a "System Program" is detected

Checklist

• This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
• This issue is not a duplicate feature request of previous feature requests.

Describe the feature you'd like

When a new configuration is sent to the controller, it may have added, removed, or changed system objects. We should add support for detecting "system program" events, and update the state of our controllers and/or objects.

We can probably detect a Object.GetMTime and use that.

Additional context

No response

Child loads for LVRS8-DIN station are not associated with station

Checklist

• This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
• This issue is not a duplicate issue of currently previous issues..

Describe the issue

LVRS8-DIN is detected (thank you), but parent (controller) to child (load) relationship is not reported in HA, i.e. station has no loads and relay loads have no parent.

In contrast DualRelayStation (keypad) and ModuleGen2 (SDM12) does maintain the parent/controller - child/loads relationship in HA.

On reviewing the XML, the LVRS8-DIN and its loads are reported as parent child, just like the DualRelayStation and ModuleGen2.
But, the DualRelayStation has a blackbox parent, regardless, the loads of the DualRelayStation does point directly to the DualRelayStation as parent, same with ModuleGen2.

Reproduction steps

• Add system with LVRS8-DIN and loads to HA.
• Observe that LVRS8-DIN and loads are detected.
• But that there is no parent/child relationship reported in HA.

XML and dump_system.py logs attached for reference.

dump_system.zip
DC46.zip