Giter Site home page Giter Site logo

Comments (13)

github-actions avatar github-actions commented on August 22, 2024

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

from readfish.

Adoni5 avatar Adoni5 commented on August 22, 2024

max_chunks has to be greater than min_chunks, and should not be set to 1.
You also don't seem to have set any targets?

from readfish.

jennieli421 avatar jennieli421 commented on August 22, 2024

We have been using max_chunks=1 for a very long time and the results were fine. Here I am only providing targeted region's reference, so I don't need to specify targets

from readfish.

mattloose avatar mattloose commented on August 22, 2024

Here I am only providing targeted region's reference, so I don't need to specify targets

I'm not quite sure what you are trying to do here. If you do not give any targets then you will not get any unblocking activity. An empty

targets = []
will mean that no targets are checked and so the later logic of on or off target will not be evaluated.

An example toml enriching for two chromosomes from a reference is available here:
https://github.com/LooseLab/readfish/blob/main/docs/_static/example_tomls/human_chr_selection.toml

In short, you must have something in the targets = [] for any unblocking activity to occur.

from readfish.

jennieli421 avatar jennieli421 commented on August 22, 2024

I have been using this setting (with split region) for a long time and it is working as expected. The design for not having targets can be traced back to this conversation:
#242 (comment)

Basically I have provided references of only the desired sequences, so everything mapped to the reference is accepted.
Thus, the problem I want to fix is why this setting does not work when I only have one region.

from readfish.

mattloose avatar mattloose commented on August 22, 2024

Hmmm

I indeed stand corrected.

Let me check this further and come back to you.

from readfish.

mattloose avatar mattloose commented on August 22, 2024

Hi, Could you pleaase confrim your readfish version and also share your readfish log with us - the log should be called the <run_id>.tsv

Thanks

Matt

from readfish.

jennieli421 avatar jennieli421 commented on August 22, 2024

tested_one_or_more_regions_ef170d0f.zip

Unfortunately, I was testing different region settings during the run, so this run had multiple settings. I hope this is fine.

from readfish.

Adoni5 avatar Adoni5 commented on August 22, 2024

Hi @jennieli421 - do these logs contain an example of it working, with a region of control=true, where you see unblocking?

And can I just check the version of readfish you were using?

readfish --version

Final question, what is the mean read length of the library you are testing?

from readfish.

jennieli421 avatar jennieli421 commented on August 22, 2024
readfish --version
readfish 2023.1.1

Both should contain multiple trials where I see unblocking, as long as there is a region of control=True.

Screenshot 2024-05-12 at 1 03 25 AM
Screenshot 2024-05-12 at 1 03 42 AM

from readfish.

github-actions avatar github-actions commented on August 22, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

from readfish.

github-actions avatar github-actions commented on August 22, 2024

This issue was closed because there has been no response for 5 days after becoming stale.

from readfish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.