lorddarkula/chess_py

Chess library for simple chess engine creation

chess_py's Issues

Fix enter key crash

When no move is provided and the enter key is hit instead, the program crashes.

Rewrite Converter

Refactor code into variables, methods, and classes

class Converter:
    def short_alg():
        king_side = ....
        .......... 


}

Fix import statements

Extremely complicated set of imports in init.py. Decide if internal directories need to be packages.

Rename methods in converter.py

These 3 should be the only publicly accessible methods

• long_alg
• short_alg
• make_legal

Renaming to_move to _to_move would probably be the easiest way to do this

Revamp Color

get rid of constants outside the class (white and black), and replace with Color.White and Color.Black.

Update docstrings

In order to work correctly with sphinx, docstrings must look like this . . .

def my(a, b):
"""
my does some shit

:type a: str
:type b: str
:rtype: str
"""
return a + b

Implement testStr

Specifically test all string getters in this test class.

Replace old for loops with cleaner versions

Replace for i in range(len(x)) with for i, j in enumerate(x)

Add __eq__ to Color and Piece classes

Fix castling exception

When castling, the Location of the King somehow ends up as empty when testing checks in King.

test = copy.deepcopy(position)
# Somehow the Location of the King is empty 

test_move = Move(end_loc=move.end_loc,
                 piece=test.piece_at_square(self.location), # Problem right here
                 status=move.status,
                 start_rank=self.location.rank,
                 start_file=self.location.file)

test.update(test_move)
test_king = test.piece_at_square(test_move.end_loc)

Remove unfiltered

Certain methods that return a list of moves first generate a raw list then filter it. This is inefficient.

Write unit tests for everthing

The tests directory should be populated with tests of all major methods.

Symbols associated to pieces appear to be wrong color

Firstly, thanks for making this library available. I think all of the symbols associated to the chess pieces have the opposite color to the color intended. For instance on line 42 of the following file:

https://github.com/LordDarkula/chess_py/blob/master/chess_py/pieces/rook.py

we have

def _symbols(self):
        return {color.white: "♜", color.black: "♖"}

which is surely not as intended? Or am I missing something?

Update README

Update README to reflect changes in v2.0, and point to the sphinx docs.

Add @property decorators

Add @property to getters and @name.setter to setters

Fix issue in which Piece locations do not change after being moved

Add type annotations to all methods.

def square(x: int) -> int:
    return x*x

Rewrite Board

With the following goals

• more efficient
• reflect changes in the architecture

The pieces on the board are not aligned.

When running this program in the command line or IDLE, the pieces do not stay aligned as the game progresses. An example is provided.