loucypher/lwthemes

Lightweight Themes Manager Firefox add-on

lwthemes's Issues

It does NOT work with Firefox 47!!

Hello the developer,

In Firefox 47, Tools, Lightweight Themes and I get a blank page instead of the normal full page of showing my personas!!

Thanks to solve this BUG with the FF47 version.

Thanks to the developer for this great addon.

Cannot manage more than 30 lightweight themes

Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 SeaMonkey/2.27a1 ID:20140214003001 c-c:1ce77c2f9bd0 m-c:d275eebfae04

Lightweight Themes Manager 0.2

AFAICT it is not possible to manage more than 30 lightweight themes. (Even if I hand-craft a JSON file in the correct format, when I try to restore it I am told that [for instance; and quoting from memory] "this backup contains 83 lightweight themes; 30 are installed at the moment; therefore this backup will replace all your installed lightweight themes [Cancel] [OK]" and if I accept the restore, only the first 30 are restored.)

Is this a limitation of this extension or of the Toolkit add-ons manager subsystem itself? If the latter, I suppose that, alas, I shall have to live with it, because the add-ons manager owner and peers believe that the preference lightweightThemes.usedThemes already gets much too bulky as it is. If it is a limitation of this extension, I am willing to incur the performance slowdown it would entail at startup, at closedown, and every time prefs.js is saved. Would it be possible to increase the maximum, if necessary by means of an additional Integer or Boolean preference? I am willing to test an experimental version, either as a "development version" at AMO, or by (IIUC) zipping the src/ subfolder of a test branch from a clone on my HD.

Don't use `innerHTML`

Email from AMO Editor

Your add-on, Light Weight Themes Manager 0.1a7, has been reviewed 
by an editor and did not meet the criteria for being hosted in our gallery.


Reviewer:
Kris Maglione

Comments:
Your version was rejected because of the following problems:

1) Your add-on creates DOM nodes from HTML strings containing unsanitized data, 
by assigning to innerHTML or through similar means. Aside from being inefficient, 
this is a major security risk. For more information, see 
https://developer.mozilla.org/en/XUL_School/DOM_Building_and_HTML_Insertion

Please fix them and submit again. Thank you.

Tested on Linux with Firefox 22.0

For reference:
https://developer.mozilla.org/en-US/docs/XUL/School_tutorial/DOM_Building_and_HTML_Insertion

Finding a quick way to open up LWT manager

I just installed your extension, and would like a convenient way of opening it. I have seen two methods so far: going into the Extensions list, hitting yours, and then click on Open. Also, I bookmarked the chrome page and put it on my bookmarks bar, but I’d like to get it off the bookmarks toolbar. Can I put a link to your extension in the Hamburger menu?