Giter Site home page Giter Site logo

musicplayer's People

Contributors

cryveck avatar louish-760 avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

cryveck

musicplayer's Issues

Seekbar click

When do click at a position in the seekbar, bad behaviour :

  • Do not go at the place where we click on seekbar
    OR
  • Do not retry to play music

NullPointerException when launching the program

When trying to launch a built jar since after the new shortcut merge.

Error:

Exception in thread "main" java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.jdt.internal.jarinjarloader.JarRsrcLoader.main(JarRsrcLoader.java:61)
Caused by: java.lang.NullPointerException
	at com.musicplayer.keyboard.ShortcutBinding.isIn(ShortcutBinding.java:81)
	at com.musicplayer.keyboard.ShortcutBinding.addBind(ShortcutBinding.java:68)
	at com.musicplayer.gui.SwingGUI.setNextAction(SwingGUI.java:132)
	at com.musicplayer.logic.SingleAlbumLogic.<init>(SingleAlbumLogic.java:70)
	at com.musicplayer.Main.main(Main.java:16)
	... 5 more

Previous action freeze

No crash log. Just freeze button push frame and cut music.
Context (reproductible):
-Run player, with music (to be faster set music near the end).
-Minimize or unfocus the player
-Wait player change music
-Go back on the player
-Now if you try to go back on the preceden music (with previous button, or shortcut) it will freeze the player and stop playing music.

GUI redesign

The current GUI, while working, is not the prettiest. It could be rewritten using JavaFX or another library to have a more modern style and a different layout.

Keyboard shortcut

Add keyboard shortcut for actions (volume up, down, play/pause, etc...), currently there is no shortcut.

Going previous music while playing first one

Exception in thread "AWT-EventQueue-0" java.lang.IllegalArgumentException: End of players reached!
at com.musicplayer.misc.Helper.check(Helper.java:18)
at com.musicplayer.player.VLCJSinglePlayer.previous(VLCJSinglePlayer.java:116)
at com.musicplayer.logic.SingleAlbumLogic.lambda$2(SingleAlbumLogic.java:77)
at com.musicplayer.gui.Button.mouseClicked(Button.java:40)
at java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:270)
at java.awt.Component.processMouseEvent(Component.java:6542)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
at java.awt.Component.processEvent(Component.java:6304)
at java.awt.Container.processEvent(Container.java:2239)
at java.awt.Component.dispatchEventImpl(Component.java:4889)
at java.awt.Container.dispatchEventImpl(Container.java:2297)
at java.awt.Component.dispatchEvent(Component.java:4711)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4904)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4544)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4476)
at java.awt.Container.dispatchEventImpl(Container.java:2283)
at java.awt.Window.dispatchEventImpl(Window.java:2746)
at java.awt.Component.dispatchEvent(Component.java:4711)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760)
at java.awt.EventQueue.access$500(EventQueue.java:97)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.awt.EventQueue$3.run(EventQueue.java:703)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:84)
at java.awt.EventQueue$4.run(EventQueue.java:733)
at java.awt.EventQueue$4.run(EventQueue.java:731)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:730)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Player redesign

Player seems to need to be optimize and avoid all these track loading (maybe a buffer with length of 2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.