lpikora/bing-wallpaper-daily-mac-multimonitor

Bash Script for download and set Bing Daily Wallpaper on all monitors for macOS

bing-wallpaper-daily-mac-multimonitor's Issues

Not working on Snonoma 14.1.2

Can't get this to run on my MacBook with Sonoma 14.1.2 installed

enable-auto-update is not working

Hello,

Launching the script with enable-auto-update returns the error message: "Unknown parameter: enable-auto-update" on MacOS 13.4.1(c).

No plist in LaunchAgents has been created as well.

Script fails due to missing bashrc

With autoupdate enabled, the script fails to run since on newer systems there's only a .zshrc file, but not a .bashrc.

% /bin/sh -c "source ~/.bashrc && npx --yes bing-wallpaper-daily-mac-multimonitor@latest  --all-desktops-experimental"
/bin/sh: /Users/stephan/.bashrc: No such file or directory

Download file title contains `OHR`

Files always contain the unnecessary OHR bits in the front of every file; should be removed.

Can't seem to get the launchctl to work on Big Sur

❯ ll ~/Library/LaunchAgents/com.bing-wallpaper-daily-mac-multimonitor.plist
-rw-r--r-- 1 sumonto staff 566B Dec 21 20:08 /Users/sumonto/Library/LaunchAgents/com.bing-wallpaper-daily-mac-multimonitor.plist
❯ launchctl unload -w ~/Library/LaunchAgents/com.bing-wallpaper-daily-mac-multimonitor.plist
❯ launchctl load -w ~/Library/LaunchAgents/com.bing-wallpaper-daily-mac-multimonitor.plist

The desktop wallpaper does not change, nor do I see any errros being reported

Mac OS Version
BuildVersion: 20B29

Feature request: insert mkt={ }

I'd like to request the option to choose the market for the download. For example, en-US or en-WW or the like.

Logging without events occurrence date and time

I periodically check the script's log for some errors and it is not convenient that the logged events don't have their occurrence date and time.
In my own local copy of the script in the node_modules folder, I've changed the script as follows:

print_message() {
    if [ ! "$QUIET" ]; then
        printf "%s\n" "$(date): ${1}"
    fi
}

Propose to add the same to the repo.

Fallback wallpaper

On some days Bing's picture of the day is not available for downloading, as can be seen in the screenshot below. Your bash script tries to download the image per the resolution of the user's monitor. When Bing has downloading disabled, only lower resolution URLs of the image work and higher ones (eg. 1900x1200) do not.

But when this happens, we are treated with a wallpaper that is a nasty placeholder image as seen below.

It would be great if you could offer a quick and reliable way to choose a fallback wallpaper from the local disk when this happens.

Failed to create the file /Users/wuyi/Pictures/bing-wallpapers//: Is a directory

running the command fails now:

bing-wallpaper-daily-mac-multimonitor

Downloading: ...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
Warning: Failed to create the file /Users/wuyi/Pictures/bing-wallpapers//: Is
Warning: a directory
40 15862 40 6353 0 0 13373 0 0:00:01 --:--:-- 0:00:01 13373
curl: (23) Failure writing output to destination
Downloading: ...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
Warning: Failed to create the file /Users/wuyi/Pictures/bing-wallpapers//: Is
Warning: a directory
75 15862 75 11889 0 0 21636 0 --:--:-- --:--:-- --:--:-- 21636
curl: (23) Failure writing output to destination
Downloading: ...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
Warning: Failed to create the file /Users/wuyi/Pictures/bing-wallpapers//: Is
Warning: a directory
100 15864 100 15864 0 0 49789 0 --:--:-- --:--:-- --:--:-- 49789
curl: (23) Failure writing output to destination

Setting the wallpaper on all desktops/"spaces"

Currently the script switches the wallpaper only on the current desktop/"space".
It would be great if it would be changed consistently amongst all instances.

Bing Daily Wallpaper broken on bing.com

The Bing homepage used to display the daily wallpaper without any action required from the user. However, now it seems that a button must be clicked in order to see the wallpaper of the day. so the script is not working as normal