lrcfs/lrcfs-file-renamer

lrcfs-file-renamer's Issues

old filename column not used

Defining filenameOldColumn as something other than originalFilenameColumn has no effect.

Is filenameOldColumn required?

Gatekeeper restriction on macOS Catalina

I don't have a machine to test it, but the Gatekeeper on macOS Catalina is more restrictive than Mojave and may not allow an unsigned application to run. We may have to get a valid developer ID from Apple. I think this costs $100 per year.

Fix security warnings during build

found 2 vulnerabilities (1 moderate, 1 high)
run npm audit fix to fix them, or npm audit for details

List "required columns" and "filename columns"

Renamers.json now has a concept of "required columns" that the data must contain. Those columns can optionally have "useInFilename=true" which means they are used to generate the filename.

This means that we can independatly validate the metadata and the filename creation.

However, currently the user interface does not show this to the user.

UI issues

The "show metadata requirements" DIV/panel has lots of underlined entries which appear to be tooltip help (e.g. "Filename") when you hover the mouse, but don't have any text. Intentional?

Also webiste typo.

Create Blank Metadata button has moved to this div. Also intentional? Not sure that helps.

Metadata Column Name

If two columns have the same name, no error is reported (the first column appearing is one used in the new Filename). Case sensitivity tested and is working as expected.

"Worker Process" window

I keep seeing an empty "Worker Process" window pop up in front of the app on a Mac. It definitely appears upon first launch, but also pops up now and again when using the app.

File checking errors show both types regardless

The text for when a file checking error is raised has both the file missing and header missing options shown even if one isn't erroring e.g.

There are problems with your metadata headers
The following headers is missing and is needed for identifiying your files...

The required headers are missing that will be used to rename your files...

• Evidence type

Only show text for valid error

spelling mistake from page

hunderds should read hundreds

Missing required columns create files with 'undefined'

Adding an 'Experiment' column to renamers.json:

	"filenameColumns":
	{
		"Weight": "w",
		"Time": "t",
		"Experiment": "x"
	}

but having a typo in the 'Experment' column results in the filename with "x-undefined".

Add check for missing required columns.

metadata can get overwritten if saving the same folder

filename columns need to be different

Setting orginalFilenameColumn to the same as filenameNewColumn causes an "Original File Does not Exist" error as the original name has been overwritten.

Do we want users to be able to do this?

Trim trailing empty columns and rows.

Probably an excel artefact, but for the "StrSg" dataset am getting several trailing empty columns.

This appears to be caused by a few rows with (empty) merged columns.

I can generate the same for trailing rows. This, however, causes errors as there's no data so all the output filenames are identical:

Same New Filename
The following rows will generate new files that have the same name.

457: -S-A-O-E-M-S-T-G-C-R
458: -S-A-O-E-M-S-T-G-C-R
459: -S-A-O-E-M-S-T-G-C-R
460: -S-A-O-E-M-S-T-G-C-R
461: -S-A-O-E-M-S-T-G-C-R
462: -S-A-O-E-M-S-T-G-C-R
463: -S-A-O-E-M-S-T-G-C-R
464: -S-A-O-E-M-S-T-G-C-R
465: -S-A-O-E-M-S-T-G-C-R
466: -S-A-O-E-M-S-T-G-C-R
467: -S-A-O-E-M-S-T-G-C-R
468: -S-A-O-E-M-S-T-G-C-R
469: -S-A-O-E-M-S-T-G-C-R

Maybe add a check that the filename column/row can't be empty, plus filter out completely empty rows/cols.

Add "ignore file list"

Exsiting file check flags .DS_Store and "output" directory as files that aren't in metadata.

Add "ignore file list" to filter out common files that should be ignored.

Excel file import/export

To consider.

Missing originalFilenameColumn fails silently

If the filename column doesn't match what is expected renamer fails silently for the user. JS error is:

Uncaught TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
at validateString (internal/validators.js:107)
at Object.extname (path.js:1223)
at GetNewFilename (/Applications/LRCFS File Renamer.app/Contents/Resources/app.asar/app/pages/index.js:124)
at Object. (/Applications/LRCFS File Renamer.app/Contents/Resources/app.asar/app/pages/index.js:309)
at Function.each (/Applications/LRCFS File Renamer.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:367)
at GenerateNewFilenames (/Applications/LRCFS File Renamer.app/Contents/Resources/app.asar/app/pages/index.js:308)
at /Applications/LRCFS File Renamer.app/Contents/Resources/app.asar/app/pages/index.js:277
at CallbacksRegistry.apply (/Applications/LRCFS File Renamer.app/Contents/Resources/electron.asar/renderer/callbacks-registry.js:41)
at /Applications/LRCFS File Renamer.app/Contents/Resources/electron.asar/renderer/api/remote.js:281
at EventEmitter. (/Applications/LRCFS File Renamer.app/Contents/Resources/electron.asar/renderer/api/remote.js:271)

Case Sensitivity

Case Sensitivity is working as expected but does not prevent data renaming.
E.g. If Column "Date" reads "date", the Filename will be renames "undifined-..."

Spelling mistake

Persistance should read Persistence

Show hidden files info needs added for windows/mac

rework wording for loading metadata into same folder

Note: Before loading your metadata please ensure that your metadata and it's corresponding files are in the same directory.

Add "required feild" to renamer property details

The renamers.json now supports the ability to have feilds that are not required (allowNull = true)

However, the interface does not currently show this to the user in a meaningful way.

Possibly add * to any property that is required.

Labelled empty column

A labelled empty column (not NA) is removed from the viewer.
A partially filled column stays or move as the last column in the viewer depending on where the information is missing.
Neither stops renaming the files.

Progress/loading popup doesn't refresh while loading

Seems like outdated implementation of plugin.

Look at alternatives like: https://www.npmjs.com/package/progressbar.js

Include code for updating taskbar progress: https://www.electronjs.org/docs/tutorial/progress-bar

[UI] Processing progress bar

Or similar.

There's no feedback once the "Processing" button is pressed until the files are renamed. Add a spinner on the button or summat.