lrebornsl/awesome-books

A web page that brings you a list of books that you also can add or remove in their respective section. Build it with: HTML, CSS and JS.

awesome-books's Issues

Module 2 - Week 2 - Day 2: Peer to Peer Code Review :speech_balloon: :ok_hand:

Hello @lRebornsl 👋 👋

Great job my friend on the project so far! Your hard work and progress are clearly visible, particularly in the impressive use of JavaScript classes and local storage to manage the bookshelf data. This demonstrates a solid foundation to build upon. 👏 💯

However, in order to meet all the project requirements, there are a few issues that need to be addressed. I have no doubt that you're more than capable of resolving them. 💪

To highlight 🌟 🎯

• Nice use of JS modules for splitting the code. 🥇
• Good use of luxon to display the current time. ⌚
• well-structured LocalStorage for managing stored books ✔️
• Use GitHub Workflows. .

Needed modifications ♻️

At book-collection.js 👀

• It would be better if you use forEach instead of classic for to iterate over this.books. (Line 27)

Using forEach is often preferred over a normal for loop because it simplifies the syntax and can make the code more readable by eliminating the need for an index counter and explicit indexing.

your code 💟

for (let i = 0; i < this.books.length; i += 1) {
 // iterate over this.books and display books
}

suggested code

this.books.forEach((book) => {
  // iterate over this.books and display books
});

At index.js 👀

• You might want to consider making your index.js file the main entry point for your application. To do this, you could move the menus.EventListener and doDate functions to a new file in the modules directory and then import it in the index.js file. This will help make your index.js file more clear and more organized.

The index.js file is commonly used as the main module that imports and initializes other modules, libraries, and components. It can also define global configurations and set up the application environment.

Cheers, and Happy coding! 👏 👏 👏. Keep up the great work! 💪 👨‍💻