lshallo/advanced-electric

Factorio modification that adds new tiers of solar panels and accumulators. Makes solar farms more space efficient and not as repetitive to build.

Past projects that are no longer maintained: LsHallo Archive

advanced-electric's Issues

Add `next_upgrade` to entities

When using the upgrade planner, it currently won't automatically upgrade the solar panels or accumulators unless they are specifically set in the upgrade planner. This is because entities have a next_upgrade property, which, went set, will tell the upgrade planner what to default to. https://wiki.factorio.com/Prototype/Entity#next_upgrade

I tested it today to make sure it would work, and it does. Below are the changes I made:

in data.lua (approx line 48):

-- add these lines so that the regular solar panel and accumulator upgrade to the advanced ones
data.raw["accumulator"]["accumulator"].next_upgrade = "advanced-accumulator"
data.raw["solar-panel"]["solar-panel"].next_upgrade = "advanced-solar"

in entity/advanced-solar.lua

-- line 2
tier=settings.startup["advanced-electric-enabled-tiers"].value
-- approx line 50, only set next upgrade if additional tiers are unlocked
if tier == "elite" or tier == "ultimate" then
	advanced_solar.next_upgrade = "elite-solar"
end

in entity/elite-solar.lua

-- line 2
tier=settings.startup["advanced-electric-enabled-tiers"].value
-- approx line 50, only set next upgrade if additional tiers are unlocked
if tier == "ultimate" then
	elite_solar.next_upgrade = "ultimate-solar"
end

in entity/advanced-accumulator.lua

-- line 2
tier=settings.startup["advanced-electric-enabled-tiers"].value
-- approx line 134, only set next upgrade if additional tiers are unlocked
if tier == "elite" or tier == "ultimate" then
	advanced_accumulator.next_upgrade = "elite-accumulator"
end

in entity/elite-accumulator.lua

-- line 2
tier=settings.startup["advanced-electric-enabled-tiers"].value
-- approx line 134, only set next upgrade if additional tiers are unlocked
if tier == "ultimate" then
	elite_accumulator.next_upgrade = "ultimate-accumulator"
end

That should do the trick!

More Sizes (1x1, 2x2, 5x5?)

There was a request about having more sizes available in the mod.
Since I'm only really able to do the code and not the visual part I'm seeking for help to create new graphics for the new sizes.

See https://mods.factorio.com/mod/Advanced-Electric-Revamped-v16/discussion/5fbc7943c23c61e3df4a34c6 for the origin.

Multiplier settings do not scale costs relative to other multiplier settings

Using the multiplier settings to change the values of the solar panels/accumulators causes the costs of an ultimate panel to scale exponentially with the multiplier, since the cost of each tier is hardcoded as dividing by 10, not the previous multiplier.

For example, changing the accumulator values from 10/100/1000 to 20/200/2000, to match Krastorio's accumulators, causes the costs to become 21 basic accumulators per advanced, 22 advanced per elite, and 25 elite per ultimate. Each accumulator is still 10x more powerful than the previous, but the costs are multiplied by 20x instead.

When calculating costs of each tier, the formula should scale as (Multiplier[Tier] / Multiplier[Tier-1]), not (Multiplier[Tier] / 10), as currently.