lucas42/lucos_media_manager

A java service for keeping track of which music is currently playing.

lucos_media_manager's Issues

Can't recover from null pointer exception

The follow stracktrace occurs sometimes:

Feb 18 19:07:23 lucos_media_manager[21825]: Server Error (HttpRequest, host:10.0.0.4):
Feb 18 19:07:23 lucos_media_manager[21825]: java.lang.NullPointerException
Feb 18 19:07:23 lucos_media_manager[21825]: at java.util.LinkedList$ListItr.next(LinkedList.java:893)
Feb 18 19:07:23 lucos_media_manager[21825]: at Manager.createFullSummary(Manager.java:165)
Feb 18 19:07:23 lucos_media_manager[21825]: at Manager.fullSummaryHasChanged(Manager.java:101)
Feb 18 19:07:23 lucos_media_manager[21825]: at HttpRequest.processRequest(HttpRequest.java:181)
Feb 18 19:07:23 lucos_media_manager[21825]: at HttpRequest.run(HttpRequest.java:30)
Feb 18 19:07:23 lucos_media_manager[21825]: at java.lang.Thread.run(Thread.java:745)

Once it starts it occurs repetitively. Only way to fix it is restart the service.

Don't run tests as part of `mvn install` or `mvn package`

Currently mvn runs tests at every available point. This means for a single commit they get run 3 times:

• In circleCI, as part of the test job
• As part of the docker build
• In codeql, when installing

Limit this to just the test job, to speed things up and avoid conflicting results in different places.

Change Track hashCode when metadata changes

Currently the hashCode method for Track is based on its URL. However, now that track metadata can be changed, it should factor that in, so that a metadata change causes the hashcode to change too.

Sending `NaN` to volume endpoint screws everything up.

The volume endpoint checks inputs to make sure they're valid numbers. But sending the input "NaN" is seen as a valid number. However, on reading this later, GSON gets very confused, throwing an error and causing requests to hang.

Steps to reproduce

1. Send a POST request to /volume?volume=NaN

Artist images from BBC return a 404

The BBC has broken loads of its /music website. Looks like they don't care for the web anymore. 🤷‍♀️
Perhaps look at other sources of images (if you do find one, try to cache it server-side, rather than hot-loading, so won't have this issue in future).

Re-order tracks

Enable the order of tracks in the playlist to be altered.

Flakey unit test

Sometimes PlaylistTest:topups() fails on:

lucos_media_manager/src/test/java/PlaylistTest.java

Line 73 in 2230552

verify(loganne, times(2)).post("fetchTracks", "Fetching more tracks to add to the current playlist");

Example failure: https://app.circleci.com/pipelines/github/lucas42/lucos_media_manager/69/workflows/6dffe309-ab53-4cf4-bddd-f3d519ea57aa/jobs/188

13.26 [ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.24 s <<< FAILURE! - in PlaylistTest
13.26 [ERROR] topups  Time elapsed: 0.067 s  <<< FAILURE!
13.26 org.mockito.exceptions.verification.TooFewActualInvocations: 
13.26 
13.26 loganne.post(
13.26     "fetchTracks",
13.26     "Fetching more tracks to add to the current playlist"
13.26 );
13.26 Wanted 2 times:
13.26 -> at Loganne.post(Loganne.java:18)
13.26 But was 1 time:
13.26 -> at Playlist.topupTracks(Playlist.java:120)
13.26 
13.26   at PlaylistTest.topups(PlaylistTest.java:73)
13.26 

Non-Linear Volume.

Volume should account for perceived loudness.

http://stackoverflow.com/questions/5365766/non-linear-volume-for-htmlmediaelement

Unknown Error

Stacktrace:

ERROR: Unknown Error (HttpRequest, host:172.25.0.1):
java.lang.IndexOutOfBoundsException: Index: 0, Size: -1
	at java.base/java.util.LinkedList.checkPositionIndex(LinkedList.java:564)
	at java.base/java.util.LinkedList.listIterator(LinkedList.java:871)
	at java.base/java.util.AbstractList.listIterator(AbstractList.java:311)
	at java.base/java.util.AbstractSequentialList.iterator(AbstractSequentialList.java:238)
	at java.base/java.util.AbstractList.hashCode(AbstractList.java:566)
	at Playlist.hashCode(Playlist.java:117)
	at Status.hashCode(Status.java:37)
	at Status.summaryHasChanged(Status.java:44)
	at FrontController.respond(FrontController.java:61)
	at FrontController.processRequest(FrontController.java:46)
	at FrontController.run(FrontController.java:26)
	at java.base/java.lang.Thread.run(Thread.java:833)