Redesign Menu Field

[lucaspilla]

Redesign Menu Field

[GlacialBlaze]

1. The two buttons should actually be the original one so, that particularly you can ignore the image.
2. Is it possible to keep the widget classes before we introduce changes to them? So that we can see any change systematically.

[GlacialBlaze]

@LucasPilla

Will do!

Don't worry - keeping the interface as clean and minimal as possible, with only the most important things is my top priority. That's why previously I ensured the major pull request contains only the most useful and required-only stuff.

[mugulmd]

1. The two buttons should actually be the original one so, that particularly you can ignore the image.

2. Is it possible to keep the widget classes before we introduce changes to them? So that we can see any change systematically.

@GlacialBlaze ok it shouldn't be too hard I'll keep you updated :)

[mugulmd]

Ok I'll try that and I'll keep you updated in the following days :)

[mugulmd]

Sorry for the delay ^^
I just did the pull request, it seems to work fine : #132

[mugulmd]

Ok, I have 2 questions though :

• are both the play and stop buttons constantly displayed, or do they switch from one to the other when clicked (like in the current display) ?
• do you want to use the gui package I wrote or keep using the widget classes defined in dispay.py ?

[LucasPilla]

@GlacialBlaze Feel free to accept and merge any pull request. Just make sure to not overload the program with useless features and keep the interface as clean as possible. Thank you for helping :)

[mugulmd]

Actually it causes a bunch of problems I did not anticipate, the 2 major ones being :

• since the label of every widget is contained in the same object as the widget itself, every draw() method has to be rewritten to write the label on the left of the widget instead of on top of it
• when clicking on the algorithms button, most of the algorithm names are out of the screen and there's no way to scroll in order to reach them.

@GlacialBlaze I don't know what you think about all this, but from my perspective it would be cleaner and easier to work with a more solid GUI structure (even though I hear you when you say it's a pretty big step to take).
What's your opinion on this ?

[GlacialBlaze]

@mugulmd

I see. I too am surprised by these.

Patch: #131

• Sorry that you had to face problem 1 as I've forgotten to unify the boxes under one template class previously😅. I've refactored the code which improved control over all labelled boxes. Now, the problem should be simplified to tweaking the label position from the top to the left of each box.

• For problem 2, is it possible that you attempt to make another file of the original code (where everything is still a menu at the bottom) and try to make changes to the Algorithm box only? Doing so, it'll be easier to separate the code changes (from the above problem). Then, it'll be easier and cleaner to focus on whether a vertical slider menu is possible after clicking the box. If both these problems are fixed in their respective files, then it would be simple to combine them together.

For the algorithm box, before the vertical slider, did you manage to make it pop to its right instead of to its top? I mean, the new menu can still output all the algorithm names using the current list mechanism and that would be enough, because the number of algorithms we have now doesn't demand a vertical slider. We can focus on it once we have finished other tasks.

Also, sorry I did not clarify, the issue Redesign Menu Field is just about moving the menu from bottom to the left. Actually, there was no intention of dealing with a vertical slider simultaneously now. 😅