Giter Site home page Giter Site logo

Comments (13)

LucasPilla avatar LucasPilla commented on June 11, 2024 2

@lucasrafaldini I will have a look asap, thanks! 😄

from sorting-algorithms-visualizer.

Velin-Todorov avatar Velin-Todorov commented on June 11, 2024 2

@Velin-Todorov, @lucasrafaldini did a great job 👋 but there are some tasks to be done:

  • maybe it is better if we keep the docstrings 1 or 2 paragraphs long.
  • add a simple table with time and space complexity for each algorithm.
  • remove the "Args" and "Yields" parts, they are not useful at all

What do you think?

Hey @LucasPilla can you also assign this to me?? I can work on some of the algorithms.

Thanks, Ven

@Velin-Todorov, @lucasrafaldini did a great job 👋 but there are some tasks to be done:

  • maybe it is better if we keep the docstrings 1 or 2 paragraphs long.
  • add a simple table with time and space complexity for each algorithm.
  • remove the "Args" and "Yields" parts, they are not useful at all

What do you think?

Hey @LucasPilla can you also assign this to me?? I can work on some of the algorithms.

Thanks, Ven

Hi Ven. I prefer to work this task alone.

Kind regards,

Velin

from sorting-algorithms-visualizer.

lucasrafaldini avatar lucasrafaldini commented on June 11, 2024 1

Hey, I want to contribute with binaryinsertionSort docstrings.

from sorting-algorithms-visualizer.

lucasrafaldini avatar lucasrafaldini commented on June 11, 2024 1

Hey guys.

I took advantage of the holidays in Brazil and wrote docstrings for all algorithms. I hope it helps.
I tried to keep a certain "standard" but sometimes I didn't know everything about it or just didn't know anything to write about but I think they are a good starting point.

from sorting-algorithms-visualizer.

Velin-Todorov avatar Velin-Todorov commented on June 11, 2024 1

It sounds great. Please assign this to me.
Where can i find the docstrings?

Also, could you please provide me with a deadline?

Kind regards,

Velin

from sorting-algorithms-visualizer.

lucasrafaldini avatar lucasrafaldini commented on June 11, 2024

I took the liberty to also make the docstrings for bitonicSort. Here's the PR -> #165

from sorting-algorithms-visualizer.

Velin-Todorov avatar Velin-Todorov commented on June 11, 2024

Hi. Is this issue still open? Are there algorithms that still need comments/docstrings?

from sorting-algorithms-visualizer.

LucasPilla avatar LucasPilla commented on June 11, 2024

@Velin-Todorov, @lucasrafaldini did a great job 👋 but there are some tasks to be done:

  • maybe it is better if we keep the docstrings 1 or 2 paragraphs long.
  • add a simple table with time and space complexity for each algorithm.
  • remove the "Args" and "Yields" parts, they are not useful at all

What do you think?

from sorting-algorithms-visualizer.

LucasPilla avatar LucasPilla commented on June 11, 2024

@Velin-Todorov I just merged the pull request made by @lucasrafaldini.

  • Now you can find the docstrings in this repository (src/algorithms).
  • Take your time and fell free to ask anything.

from sorting-algorithms-visualizer.

raghavaraghav3 avatar raghavaraghav3 commented on June 11, 2024

@Velin-Todorov, @lucasrafaldini did a great job 👋 but there are some tasks to be done:

  • maybe it is better if we keep the docstrings 1 or 2 paragraphs long.
  • add a simple table with time and space complexity for each algorithm.
  • remove the "Args" and "Yields" parts, they are not useful at all

What do you think?

Hey @LucasPilla can you also assign this to me?? I can work on some of the algorithms.

Thanks,
Ven

from sorting-algorithms-visualizer.

Velin-Todorov avatar Velin-Todorov commented on June 11, 2024

@LucasPilla I have finished editing the docstrings. Let me know what you think. Tomorrow I will add the table with the complexities as well.

from sorting-algorithms-visualizer.

Alex-Wengg avatar Alex-Wengg commented on June 11, 2024

Hey @ Velin-Todorov, are any contributions left for this issue?

from sorting-algorithms-visualizer.

brkuhgk avatar brkuhgk commented on June 11, 2024

@Velin-Todorov can you highlight the sorting algorithms which are not contributed.

from sorting-algorithms-visualizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.