Giter Site home page Giter Site logo

lucasstark / woocommerce-dynamic-pricing-table Goto Github PK

View Code? Open in Web Editor NEW

This project forked from stuartduff/woocommerce-dynamic-pricing-table

7.0 7.0 1.0 62 KB

WooCommerce dynamic pricing table adds a pricing discount table to WooCommerce products that are offering bulk discounts or special offer discounts and user role discount messages to WooCommerce sections via the WooCommerce Dynamic Pricing plugin.

Home Page: https://stuartduff.com/woocommerce-dynamic-pricing-product-discount-table-extension/

PHP 96.42% JavaScript 3.58%

woocommerce-dynamic-pricing-table's People

Contributors

dajocarter avatar lucasstark avatar stuartduff avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

Forkers

dadodd

woocommerce-dynamic-pricing-table's Issues

Error Notices & Thousand Separator Issue

Hello,

I've installed the plugin and, with DEBUG enabled,
I get these errors which break the whole website functionality (e.g. in Checkout AJAX stops working, mini cart widget stops working, …) since they are outputted in the beginning of <head>.
Notice: Undefined index: roles in /woocommerce-dynamic-pricing-table/woocommerce-dynamic-pricing-table.php on line 335
Notice: Undefined variable: info_message in /woocommerce-dynamic-pricing-table/woocommerce-dynamic-pricing-table.php on line 356
Notice: Undefined variable: info_message in /woocommerce-dynamic-pricing-table/woocommerce-dynamic-pricing-table.php on line 406

So, while DEBUG is enabled, this plugin can't be used.


A second, big issue is that this plugin does not take into account the currency settings and thousands separator.
I'm using € with comma for decimals and dot for thousands (e.g. € 1.000,00).

I set pricing rules with comma (e.g. 90,00 - 80,33 - 65,60…).
Dynamic Pricing plugin has been updated time ago to take currency settings and thousands separator into account (before, you needed to use dots), so price discounts in the cart are correctly displayed.
But this plugin displays, below 'Bulk Purchase Pricing':
€ 90,00 Per Item
€ 80,00 Per Item
€ 65,00 Per Item
rounding decimals at 0.
I've tried to revert dots in pricing rules, as in the first Dynamic Pricing releases (90.00 - 80.33 - 65.60) and the dynamic pricing table is correct, but in the cart I get € 8.033,00 - € 6.560,00…

In conclusion, the plugin should be updated to work with currency and thousands separator settings, while error notices should be fixed otherwise it can't be tested nor used.

Thanks
Davide

Support Groups

Need to add support for the Groups plugin so that the proper pricing table will be rendered when using Groups rather than built in Roles.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.