luffytaro22/portfolio-mobile-first-skeleton

This is a Portfolio based on a Figma template. The goal was to replicate it following the mobile first approach.

portfolio-mobile-first-skeleton's Issues

Peer to peer code code review

Hi @Luffytaro22 ,

Good job so far! 👏. Your Code is Awesome! 💪

There are some few issues 🐛 that you still need to work 🔧 on though to go to the next project ⏭️ but you are almost there! 🏃

Don't Worry 🙏

It's ok to have bugs in your code 🐛. Especially if that's is your first project 1️⃣. Please, see this code review as a chance for you to learn practical coding skills and learn new tips that can improve your code quality 💯 and help you get a better job 💼.

I am going to guide you on how to fix them down below. 🤓

Required Changes ♻️

Check the comments under the review.

• Could you consider removing the max-with of the * global container because it makes an issue with the sides of the webpage.
• Kindly consider changing the height of the footer to get a better UX.
• I think it should be better if you resize the img tags with other responsive sizes like rem , % , em. because they improve your responsive design.

Happy coding!!

Deployment

The Online Version of this project can be accessed through this link: https://luffytaro22.github.io/Portfolio-Mobile-First-Skeleton/