luk27official/platform041

A simple C++ 2D platformer using the SFML library.

platform041's Issues

Use cont-reference for read-only objects

E.g.,

platform041/src/Player.hpp

Line 123 in 390bdfc

bool leftObstacleCollision(sf::RectangleShape& rect) {

and many more

Weird collision detection when jumping

Kdyz se priblizim co nejbliz to jde k prekazce a skocim, tak panacek zustane potom na prekazce, coz nedava moc smysl "fyzikalne". Mel by zase spadnou dolu

Status window + lose window

Similar as you do for winning, I would like to see this windows maybe after every failure. Also, after finishing a level? Also, can you add stats window (at the beginning, you can have a menu -> [levels, stats] or something like that where you can see all the overall stats with names etc...

Cannot compile

Cannot compile under Windows WSL
Error:

CMake Error at /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find X11 (missing: X11_X11_INCLUDE_PATH X11_X11_LIB)
Call Stack (most recent call first):
  /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.22/Modules/FindX11.cmake:457 (find_package_handle_standard_args)
  build/_deps/sfml-src/cmake/Macros.cmake:391 (find_package)
  build/_deps/sfml-src/src/SFML/Window/CMakeLists.txt:294 (sfml_find_package)

Please specify all the required libraries in the documentation, I can download if need. Or include into the script

Cmake output: CMakeOutput.log

Replace all unnecessary shared_ptrs with unique_ptrs

E.g.,

platform041/src/Level.hpp

Line 39 in 390bdfc

std::vector<std::shared_ptr<Coin>> coinVec;

Split into sources & headers