lukas-krecan/future-converter

Converts between various future types

future-converter's Issues

Add support for converting Guava Futures to Spring Futures and vice-versa

RxJava Observables to Java 8 Completable future

Lukas,

A couple of years ago you wrote a blog post on RxJava Observable <-> Java8 CompletableFuture. I don't see that code integrated into the future-converter lib. Am I looking in the wrong place? Or is there a better solution there now? If not, why not add that code to the lib?

-GBS

Is there code to convert java8 to rxjava 2?

I can't find it thanks.

Convert a generic Future into CompletableFuture

Could something like this be of interest?

https://gist.github.com/hamnis/19b3eef14d0b79744fdc

ArtifactId may overlap easily with other libs

Thanks for making this lib available!

One suggestion: "spring-java8" as artifactId easily overlaps with others, and is not very easy to identify while developing and having a bunch of jars in the classpath. May I suggest to try some more explicit name?

Any thoughts at adding Guava to RxJava?

Flaky unit tests for Single to Future conversion

Every few builds I am seeing the same stack trace, have to rebuild 3-4 times before it passes, seems like some timing issue is present:

Running net.javacrumbs.futureconverter.java8rx.ToCompletableFutureConverterTest
Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.893 sec <<< FAILURE!
testCancelNew(net.javacrumbs.futureconverter.java8rx.ToCompletableFutureConverterTest)  Time elapsed: 0.005 sec  <<< ERROR!
java.util.concurrent.ExecutionException: java.lang.InterruptedException
	at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
	at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895)
	at net.javacrumbs.futureconverter.common.test.rxjava.AbstractSingleToFutureConverterTest.testCancelNew(AbstractSingleToFutureConverterTest.java:153)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
	at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
	at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
Caused by: java.lang.InterruptedException
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:998)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1304)
	at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:231)
	at net.javacrumbs.futureconverter.common.test.rxjava.AbstractSingleToFutureConverterTest.lambda$null$1(AbstractSingleToFutureConverterTest.java:221)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Add conversion between RxJava Completable and ListenableFuture<Void>

Currently, we can only convert from Single<T> to ListenableFuture<T>. We can't convert from RxJava Completable to Single<Void> because the only valid type for a Void is null, and RxJava explicitly prevents having a Single with a null value.

There is a way to workaround this by just using a dummy object as the value of the Single,

Futures.transform(
  FutureConverter.fromSingle(
    completable.toSingleDefault(new Object())), 
    _ignored -> null, 
    MoreExecutors.directExecutor())

But the above is pretty messy. It seems like it should be pretty straightforward to convert from Completable to ListenableFuture<Void> (or CompletableFuture<Void> for that matter).

Happy to take this on myself if this sounds reasonable!