lukasstevens/scrape-mep-mails

scrape-mep-mails's Issues

[BUG] Wrong order committee and role

At https://github.com/lukasstevens/scrape-mep-mails/blob/master/query.py#L143, the order of role and committee is wrong (cf https://github.com/lukasstevens/scrape-mep-mails/blob/master/query.py#L113).
Maybe consider specifying the column names in the insert statement?

Database Normalisation

The database stores values redundantly, e.g. national_party, eu_fraction, and nation should be a separate table. The latter should be renamed to country.

Missing Names

Just tried to update the MEP data but all names seem to be missing. Try

select * from meps;

Request: Change "nation" to "country"

As far as I understand the difference (https://english.stackexchange.com/questions/15007/state-vs-country-as-nation), a nation might not have sovereignty when contrasted to a country/state.
Country is also used in the frontend and currently mapping back to "nation". See https://github.com/kappelmann/mep_contact_frontend/blob/master/src/consts/sqls.ts#L22

On a related note, is there a good way to share the schema definitions between the two repositories in some way? E.g. save the SQL schema as a JSON?