Giter Site home page Giter Site logo

Comments (7)

Trenar avatar Trenar commented on May 27, 2024

Some more thoughts, since I worked a little with the code in the meantime...

  1. I think it makes sense to have a config parameter for the amount of time, the sender and caption is shown. Maybe there can be three options like 0,1,2 meaning not shown, full time and half time of the slideshow-interval.
    BTW: @LukeSkywalker92 , is there a fallback in the case that a user forgets one of the parameters in the config? Maybe we should implement that the TeleFrame uses the config.example.js values in case of undefined parameters.
    Related question: I once tried to "deactivate" the voice reply action by removing the parameters from the config file. However, this gave errors on long-press. Is there a proper way to deactivate this feature?

  2. I solved that. I had to uncomment the config_hdmi_boost=4 line in /boot/config.txt. Seems to be related to the RPi 3A+, if I'm the only one with this issue.

from teleframe.

gegu avatar gegu commented on May 27, 2024

Config parameter for the amount of time and #69 was implemented in feature/caption-sender-fullscreen.

config.js

...
  interval: 10 * 1000,
  showCaption: true,
  // To output sender caption, use the entire screen
  useFullscreenForCaptionAndSender: true,
  // Defines the percentage of the duration of <interval> to show sender and caption.
  // minimum value: 10  = fade out after 10% of <interval>
  // maximum value: 100 = full time. sender and caption does not fade out
  senderAndCaptionDuration: 50,
...

But the release has to wait until we have #66 finished.

from teleframe.

Trenar avatar Trenar commented on May 27, 2024

Nice implementation, thank you!

What is the status of #35 and #53? Also postponed until #66 is decided?

from teleframe.

gegu avatar gegu commented on May 27, 2024

IMO it is better to integrate the waiting PR's only after changing the configuration handling. Especially #35 will only work if the configuration is to be changed by external commands.

from teleframe.

Trenar avatar Trenar commented on May 27, 2024

Sure, I agree. Too bad that Christmas is that early this year :P

from teleframe.

gegu avatar gegu commented on May 27, 2024

There are seven days left. I am optimistic that we will be able to do a few more things 😏

from teleframe.

Trenar avatar Trenar commented on May 27, 2024

closed with PR #86 and #35

from teleframe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.