Giter Site home page Giter Site logo

lume.land's People

Contributors

aeshus avatar andrei0x309 avatar andy-preston avatar arnavk-09 avatar aurorahharmony avatar benjamingeets avatar bryophyta avatar carlrafting avatar ek-an avatar hpfast avatar iainsgillis avatar jimt avatar jrson83 avatar kidonng avatar kwaa avatar maluscat avatar mash-graz avatar naiyerasif avatar naltun avatar ngdangtu-vn avatar nonwiz avatar nubunto avatar officialrajdeepsingh avatar oscarotero avatar paulrobertlloyd avatar salvaft avatar scarf005 avatar segundofdez avatar uta8a avatar valpackett avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

lume.land's Issues

Add sitemap.xml

I will add the missing sitemap.xml using my plugin from the experimental repo.

Use tsx over jsx in documentation

Summary

import type { Data, PageHelpers } from 'lume/core.ts';

export default (
    { title, children }: Data,
    filters: PageHelpers
) => (
  <html>
    <head>
      <title>{title}</title>
    </head>
    <body>
      {children}
    </body>
  </html>
);

replace examples in jsx, jsx preact with tsx.

Motivation

majority of template engines lume supports does not have type system (nunjucks, liquid, etc...). however, users of tsx and tsx preact could benefit by using typescript definitions. for example, it would be helpful to show that layouts uses Data type.

Documentation specifies "Nunjucks", while providing documentation examples in Vento

When following the setup documentation as a new user, I am instructed to "Create a new directory _includes and the file layout.vto inside it. The .vto extension is for Nunjucks: a template engine supported by default by Lume." - See source

This instruction has two issues:

  • .vto is not the extension for Nunjucks. It is the extension for Vento
  • It creates an error:
Error: Error rendering the layout of this page
- page: /index.md
    at (https://deno.land/x/[email protected]/core/renderer.ts:160:19)
Caused by Error: There's no handler for this layout format
    at eventLoopTick (ext:core/01_core.js:197:13)

- layout: layout.vto
    at Renderer.#renderLayout (https://deno.land/x/[email protected]/core/renderer.ts:242:15)
    at (https://deno.land/x/[email protected]/core/renderer.ts:143:52)
    at concurrent (https://deno.land/x/[email protected]/core/utils.ts:152:33)
    at eventLoopTick (ext:core/01_core.js:197:13)
    at async Renderer.renderPages (https://deno.land/x/[email protected]/core/renderer.ts:139:7)
    at async Site.#buildPages (https://deno.land/x/[email protected]/core/site.ts:615:5)
    at async Site.update (https://deno.land/x/[email protected]/core/site.ts:583:9)
    at async Events.dispatchEvent (https://deno.land/x/[email protected]/core/events.ts:49:11)
    at async callback (https://deno.land/x/[email protected]/core/watcher.ts:96:24)
Changes detected:
- /index.md

I believe this error occurs as Lume still uses Nunjucks by default. As the documentation has been converted to using Vento instead of Nunjucks, It may be a good idea to add a page to the "Getting Started" section with instructions to install Vento (if Lume does not plan to configure it by default).

Improve documentation for index files

i'm not sure if i should move this issue to https://github.com/lumeland/lume, but i guess it belong here since it's related to documentations.

Summary

improve documentation for index files by adding section to describe

  1. how lume finds and uses index files
  2. which file extension will be accepted as valid index file (index.templ.ts, index.tsx, etc)
  3. how could user load custom index file to lume() (like lume.data())

Motivation

sometimes how lume works feels automagical, and documentation often does not fully address lume's internals.

image

today i was trying to use index.tsx file, and somehow it failed to load. i searched through the docs yet the only example was using with 'index.md'. only after reading deno blog post i could be certain that other index files were supported.

Same LICENSE as Lume?

Hey, Lume & Lume.land look great! Could I use this repo as a starter for my documentation?

That would be cool, but I really need to see a license to feel good about it.

I see Lume is MIT?
Any chance you want to release this as MIT also?
If yes, could you please add a file?
Thanks for sharing this cool work.
Cameron

Pagefind doesn't work without `--allow-run` but the error message is not helpful

How to reproduce:

  1. Install Simple Blog theme using the deno run -A https://lume.land/init.ts.
  2. In lume task change permissions to --allow-net --allow-read --allow-write=./_site --allow-sys=homedir --allow-env --allow-run=git.
  3. Attempt to run. The error like below will be there.
  4. Remove the =git part. No error will be there.

The error is:

TypeError: Cannot read properties of null (reading 'on')
    {{# I omitted a few lines here. #}}
    at https://deno.land/x/[email protected]/plugins/pagefind.ts:139:40
    at Processors.run (https://deno.land/x/[email protected]/core/processors.ts:32:13)
    at eventLoopTick (ext:core/01_core.js:168:7)
    at async Site.#buildPages (https://deno.land/x/[email protected]/core/site.ts:689:5)
    at async Site.build (https://deno.land/x/[email protected]/core/site.ts:532:9)

add option to use local decap_cm.js instead of CDN

Hi,
The wait time for unpkg.com, for decap_cms.js, can be long (a minute or more). This is annoying especially in local/dev mode, but it also sometimes affects my production deployment.

Would it be possible to make this configurable, so that the user can specify a local copy of the script if they want?

I'm having a hard time deciding how to do this, though. First I tried doing it just for my site by writing a processor that modifies the rendered /admin/ page, and rewrites the src of the script to a local url. This could be encaspulated in a plugin wrapping (or coming after) the DecapCMS plugin, and it could have the desired url as an option. But this seems like a non-starter because it seems like deno-dom doesn't know about document.scripts?

So the next thing I thought of was to make the DecapCMS plugin configurable: add an option localscript or some such which the page builder function checks here: https://github.com/lumeland/lume/blob/d5ac50063d60979124ef732121a7426fc9fb436e/plugins/decap_cms.ts#L88 and uses if defined, falling back to unpkg.

It feels a bit weird to me to make this an option, but I don't see how else to make something like this configurable since the url is hard-coded.

Would you:

a. be open to a pull request adding this option
b. have a suggestion for how else I could modify this?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.