Giter Site home page Giter Site logo

An interesting network issue about rtw88 HOT 16 OPEN

cemunal avatar cemunal commented on August 30, 2024
An interesting network issue

from rtw88.

Comments (16)

dubhater avatar dubhater commented on August 30, 2024

Excellent! I have been waiting for someone with this problem to test the potential fix which is going into kernel 6.9. You can do it by blacklisting rtw88_8821ce, rtw88_8821c, rtw88_pci, and rtw88_core, and then installing the driver from this repository.

from rtw88.

cemunal avatar cemunal commented on August 30, 2024

Installed the driver and tested ~6 hours. As a result, there is no problem like described in the post. All the other configs are same like:

options rtw_core disable_lps_deep=y
options rtw_pci disable_aspm=y
wifi.powersave = 2


But getting same dmesg errors. (Not sure but i think getting these errors a bit less when AC plugged after installed repo drivers)


Some extra Qs:

When will not we have to use extra module options and disable wifi powersaving?
When will this fix added to build-in kernel drivers?


Thank you.

from rtw88.

dubhater avatar dubhater commented on August 30, 2024

This fix will be in kernel 6.9. Eventually the stable and longterm kernels will have it as well, maybe when 6.9-rc0 appears.

Are you sure you still need those options? What are they fixing?

from rtw88.

lwfinger avatar lwfinger commented on August 30, 2024

@cemunal - If you need those fixes, it is because of the BIOS found in your device cannot properly handle your PCIe devices. On my 10-year old Samsung laptop, there is never a problem. It is the new Lenovo and HP laptops that show this "feature".

from rtw88.

cemunal avatar cemunal commented on August 30, 2024

@dubhater, I removed options rtw_core disable_lps_deep=y, options rtw_pci disable_aspm=y and wifi.powersave = 2 and there is no problems :) and I will wait for 6.9.x kernels.

@lwfinger, my laptop MFD 2021 and BIOS release date 2019 (ASUS X540UAR)

and lastly I am getting these logs:

sudo dmesg | grep rtw:


[ 8.629772] rtw_core: loading out-of-tree module taints kernel.
[ 8.629779] rtw_core: module verification failed: signature and/or required key missing - tainting kernel
[ 8.832251] rtw_8821ce 0000:02:00.0: enabling device (0000 -> 0003)
[ 8.839749] rtw_8821ce 0000:02:00.0: Firmware version 24.8.0, H2C version 12
[ 8.948701] rtw_8821ce 0000:02:00.0 wlp2s0: renamed from wlan1
[ 165.081916] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 165.081920] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 165.081923] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)
[ 195.110291] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 195.110300] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 195.110312] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)
[ 206.916185] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 206.916196] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 206.916210] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)
[ 456.017608] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 456.017611] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 456.017615] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)
[ 456.237650] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 456.237657] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 456.237664] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)
[ 531.806429] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 531.806434] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 531.806438] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)
[ 1265.197840] rtw_8821ce 0000:02:00.0: firmware failed to leave lps state
[ 1401.770298] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 1401.770315] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 1401.770333] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)


Can these logs or errors ignored or they need any fixes?

Thanks.

from rtw88.

cemunal avatar cemunal commented on August 30, 2024

New logs but there is no connection problems:

failed to send h2c command
firmware failed to leave lps state

PS: the system froze once :(

from rtw88.

pyt0xic avatar pyt0xic commented on August 30, 2024

I have had a similar issue with rtw88_8821cu for ages.
The connection would drop after some time and it was always worse when not connected to AC.

A month ago I switched to this driver and VOILA, no more connection dropping 😄

The firmware download error messages are also gone, I saw there was a fix for that added to 6.9, didn't realize it came from here.

Thank you for your hard work!

from rtw88.

lwfinger avatar lwfinger commented on August 30, 2024

You have the code generation sequence wrong. The new code goes into the wireless-next repo, which is 2 steps ahead of the stable releases. For example, stable is at 6.8, the mainline development is working on 6.9, and wireless-next has 6.10 code. What I do is backport the wireless-next code and make it compile on older kernels. That way the rtw88 repo is ahead of your distros kernels.

from rtw88.

cemunal avatar cemunal commented on August 30, 2024

Here again to understand all :)

I have no "failed to send h2c command" & "firmware failed to leave lps state" logs and no system freeze with "options rtw_core disable_lps_deep=1" & "options rtw_pci disable_aspm=1" and "wifi.powersave = 2" (using repo drivers). I am only getting these logs:


[ 8.632507] rtw_core: loading out-of-tree module taints kernel.
[ 8.632515] rtw_core: module verification failed: signature and/or required key missing - tainting kernel
[ 8.860964] rtw_8821ce 0000:02:00.0: enabling device (0000 -> 0003)
[ 8.868039] rtw_8821ce 0000:02:00.0: Firmware version 24.8.0, H2C version 12
[ 8.958539] rtw_8821ce 0000:02:00.0 wlp2s0: renamed from wlan0
[ 78.212672] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 78.212677] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 78.212682] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)
[ 123.395771] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 123.395774] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 123.395777] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)
[ 158.829239] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 158.829251] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 158.829266] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)
[ 343.123940] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 343.123953] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 343.123967] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)
[ 435.885108] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 435.885122] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000
[ 435.885196] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)


Q1: Can these logs ignored?
Q2: Can the code improved to use without additional settings like "options rtw_core disable_lps_deep=1" , ... , or are these BIOS releated problems? (PS: I have no error logs with Ubuntu 's DKMS driver.)

And @lwfinger, I am a bit confused about your last post. My main problem is "sometimes network is not responding" you know. Is this fix in 6.9.x or 6.10.x kernels?

Thanks.

from rtw88.

pyt0xic avatar pyt0xic commented on August 30, 2024

Here again to understand all :)

I have no "failed to send h2c command" & "firmware failed to leave lps state" logs and no system freeze with "options rtw_core disable_lps_deep=1" & "options rtw_pci disable_aspm=1" and "wifi.powersave = 2" (using repo drivers). I am only getting these logs:

[ 8.632507] rtw_core: loading out-of-tree module taints kernel. [ 8.632515] rtw_core: module verification failed: signature and/or required key missing - tainting kernel [ 8.860964] rtw_8821ce 0000:02:00.0: enabling device (0000 -> 0003) [ 8.868039] rtw_8821ce 0000:02:00.0: Firmware version 24.8.0, H2C version 12 [ 8.958539] rtw_8821ce 0000:02:00.0 wlp2s0: renamed from wlan0 [ 78.212672] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 78.212677] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000 [ 78.212682] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First) [ 123.395771] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 123.395774] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000 [ 123.395777] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First) [ 158.829239] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 158.829251] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000 [ 158.829266] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First) [ 343.123940] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 343.123953] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000 [ 343.123967] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First) [ 435.885108] rtw_8821ce 0000:02:00.0: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 435.885122] rtw_8821ce 0000:02:00.0: device [10ec:c821] error status/mask=00000001/0000e000 [ 435.885196] rtw_8821ce 0000:02:00.0: [ 0] RxErr (First)

Q1: Can these logs ignored? Q2: Can the code improved to use without additional settings like "options rtw_core disable_lps_deep=1" , ... , or are these BIOS releated problems? (PS: I have no error logs with Ubuntu 's DKMS drives.)

And @lwfinger, I am a bit confused about your last post. My main problem is "sometimes network is not responding" you know. Is this fix in 6.9.x or 6.10.x kernels?

Thanks.

If my understanding is correct, wireless-next is ahead of mainline, and contains all the patches that have been added to this repo.
Some of said patches should be making it into 6.9 (and/or have been added to mainline, I think...)

I don't know much about the 8821ce driver but maybe try the following setting for NetworkManager

[device]
wifi.scan-rand-mac-address=no

Just a shot in the dark xD

from rtw88.

lwfinger avatar lwfinger commented on August 30, 2024

@cemunal - Those options are needed because of BIOS problems. All of the rtw88 drivers work on my system with no options needed.

I would worry about those PCIe Bus errors. Yes, they are corrected, but I have not seen them on any other system.

Any patches in 6.9 are already in this repo, as are those that will be in 6.10.

from rtw88.

cemunal avatar cemunal commented on August 30, 2024

@lwfinger, You mean my laptop has some BIOS problems but if this is main problem, shouldn't I face similar problems with Ubuntu 's DKMS driver or on Windows? And may be I have a different card you have (Subsystem: AzureWave for example)

I write these because I want to contribute this repo and build-in kernel drivers. And I can do same tests if needed.

Thanks.

from rtw88.

lwfinger avatar lwfinger commented on August 30, 2024

The reason I wrote that is because only Lenovo and HP laptops have problems such as you see. Windows uses a completely different driver than Linux - I have no idea what they do as I have never seen their source. Again, I have no idea what Ubuntu is doing. If you could figure out what triggers the problem on your system, that would be a big help.

from rtw88.

cemunal avatar cemunal commented on August 30, 2024

@lwfinger, firstly thank you so much for all your detailed answers.

I wanted to analyze the code site of Ubuntu 's DKMS driver and "alt_rtl8821ce" driver (also no problems with this driver) to figure out what triggers the problem and to find diffs from the code of this repo but this is beyond me :)

So I will only ignore the all PCIe Bus Errors and add rtw_core disable_lps_deep=y, rtw_pci disable_aspm=y, wifi.powersave = 2 and wait for 6.9.x kernels to fix "sometimes network is not responding" problem to use build-in kernel drivers, I think.

If there is noting to say you can close the issue.

from rtw88.

cemunal avatar cemunal commented on August 30, 2024

Updated to 6.8.6-200.fc39.x86_64 to test build-in kernel drivers. Here are new logs. Thanks.
logs.txt

from rtw88.

lwfinger avatar lwfinger commented on August 30, 2024

Firstly, check to make sure that you do not have modules from the kernel and this repo both loaded. 'lsmod | grep rtw' will show what is loaded.
Secondly, if you only have kernel modules loaded, then this problem needs to be reported at [email protected].

from rtw88.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.