make error

[noticu]

make error

[lwfinger]

Sorry that I did not get to your problem earlier.

I used your change to fix the code to build on versions of the kernel older than 5.13.

I think you have a small error in your patch. The rtw_dbg() call should be reached if the code gets a valid address, not if the address is invalid.

Do a 'git checkout -f' to clear your changes, and a 'git pull' to get mine, and you should be OK.

[fffonion]

on my 5.10.160-legacy-rk35xx I did:

diff --git a/rtw8703b.c b/rtw8703b.c
index 867e632..0e96b34 100644
--- a/rtw8703b.c
+++ b/rtw8703b.c
@@ -540,11 +540,13 @@ static void try_mac_from_devicetree(struct rtw_dev *rtwdev)
 {
        struct device_node *node = rtwdev->dev->of_node;
        struct rtw_efuse *efuse = &rtwdev->efuse;
-       int ret;
+       const void *ret;

        if (node) {
-               ret = of_get_mac_address(node, efuse->addr);
-               if (ret == 0) {
+               ret = of_get_mac_address(node);
+               if (!IS_ERR(ret))
+                       ether_addr_copy(efuse->addr, ret);
+               else {
                        rtw_dbg(rtwdev, RTW_DBG_EFUSE,
                                "got wifi mac address from DT: %pM\n",
                                efuse->addr);

[fffonion]

You are right, thanks for the quick fix! @lwfinger