macder/wfv-validation

Input validation API for WordPress

wfv-validation's Issues

Create validator for 'alpha_dash' with unit tests

Create a helper method to render the required hidden fields

albeit this goes against my philosophy of 'do not return rendered markup,' it will make templates cleaner.

idea is to have an option to avoid doing:

<input type="hidden" name="action" value="<?php echo $contact_form->get('action'); ?>">
<?php echo $contact_form->get('nonce_field'); ?>

and instead:

<?php echo $contact_form->action_token(); ?>

Create validator for 'between' with unit tests

Create validator for 'required_if' with unit tests

Create validator for 'digits' with unit tests

Rename render method to escape - For better semantics

this does not render anything, just returns the encoded string: $form->input()->render('name')

more semantically correct would be $form->input()->escape('name');

Create validator for 'alpha_num' with unit tests

Tests - Automation - Create shell script(s) to run tests

The automation needs to be strategic

Should become more clear as more units get complete

Create validator for 'min' with unit tests

Rework form config array so that each field attr is an array with 'label', 'rules', 'messages'

new structure should look like:

array(
  'email' => [
    'label' => 'Email',
    'rules' => 'required|email',
    'messages' => [
      'required' => 'Custom required validation error msg',
      'email'    => 'No email? No soup for you!',
    ],
   'phone' => [
      //...
   ]
  ]
);

Improve shorthand method into WFV_Errors

error() method on WFV_Form

achieve behaviour similar to the input() shorthand

Support for array input form repopulation - checkboxes / multi selects

In order to repopulate checkboxes or multiselects, i.e. select them after validation fail - keep user sane...
Create a helper method to return a 'checked' or 'selected' attribute for checkbox and multiselect fields

LEGACY (from old validation library) - Add support for custom rules that have parameters

Currently, custom rules can only be simple callbacks that don't take in any additional parameters

There are cases when parameters are necessary

Create unit tests for FormComposite

Create validator for 'integer' with unit tests

Validator Class - split the validate method into several simple methods

It is doing more than 1 thing. Split the logic into simple pure functions to make it more readable and testable

Create validator for 'email' with unit tests

New unit tests for FormComposite

Certain parts of FormComposite have been refactored. Good opportunity to create new tests instead of trying to adapt the old ones

Create validator for 'max' with unit tests

Add support for front end validation via WP REST API

Should be able to take in the input as JSON and return a validation result JSON

Add validation fail feedback messages

Integrate PHPUnit and wp-cli

API has standardized - make unit tests for all simple and pure methods

Build an endpoint for front end validation

build an api that returns a forms configuration as JSON

making it compatible with https://validatejs.org/ might be good start

Create unit tests for ErrorCollection

REMOVED - legacy and irrelevant. Composite is encapsulated

Create validator for 'alpha' with unit tests

Create new validator class that receives a single validation strategy (ValidateInterface) for each field rule

Currently the FormComposite holds an array of validation strategies (ValidateInterface) and loops through them during validation. This is somewhat confusing, making it unclear that a strategy pattern is being used. It also add's too much responsibility to the FormComposite.

The new Validator class will be added to the FormComposite as a class member, and the FormComposite will feed it a single strategy at a time.

The only validation responsibility the FormComposite should have is providing correct strategies to the Validator

Create validator for 'array' with unit tests

Input is returning escaped string - needs unquoting

stripcslashes() should solve this

Create validator for 'required_with' with unit tests

Switch validation library from Valitron to Respect\Validation

Valitron uses a God class, so only way to add new rules is either with callback or extending the Valitron class. Both approaches would get messy fast, therefore this library needs to be replaced.

Respect\Validation is more flexible. Can create a validator class for each rule and then use a strategy pattern to validate input.

This opens the door to creating an unlimited amount of built in rules by just adding new validator classes.

Create unit tests for RuleCollection

Create validator for 'optional' with unit tests

Create validator for 'ip' with unit tests

Create unit tests for InputCollection

Create validator for 'callback' with unit tests

When a rule is an array, everything just dies

For instance, if a ruleset for a field is defined like so ['required', ['lengthMin', 3] ] the entire system grinds to a halt.

Must add support for rules that are arrays

Create unit tests for ValidatorAdapter

This is a meaty one...

Adjust code to a decorator pattern

Now that most methods and properties are known, create decorator class or classes

Create validator for 'different' with unit tests

Shorthand method that prints escaped input values to the screen

provide a better alternative to $form->input()->render('name')

Replace static factory with builder pattern

A builder pattern to build the form instance is more appropriate and extendable, especially since the form class take 4 instance params to construct

Create unit tests for MessageCollection

Create validator for 'numeric' with unit tests

Create validator for 'boolean' with unit tests

Create validator for 'date' with unit tests

Create validator for 'required' with unit tests

Support basic bool test if field has an error

Create a method to check if a field has an error, return true or false
Will be useful for adding error classes in markup

Create validator for 'equals' with unit tests

Validator / Form Classes - Remove inheritance and move most methods into Form

The Validator class is doing things that are not directly related to getting a validation result. Many of the methods are more appropriate for the Form Class.

The inheritance should become unnecessary after this rework, making the class hierarchy flat