madkins23/go-slog

Testing and tools for log/slog handlers

go-slog's Issues

New slog Handler

And I found another handler authored by go team member https://github.com/seankhliao/svcrunner/blob/main/jsonlog/ , phuslu/slog and its implementation details are similar.

I played it a bit in https://go.dev/play/p/dzeEV_YHO_J , although it's not a feature-completed slog.JSONHanlder implementation -- It does not support caller/source -- I think it's performance should very close to score 100

UPDATE: after my rough tests, its benchmark is similar with phsym/zeroslog

Some thoughts about benchmark fairness/scores

1. Currently I found that phuslu/log and phsym/zeroslog has no mutex to lock the writer. It is somehow reasonable because we suppose/except that the underlying writer will handle it. see log.FileWriter and lumberjack.Logger. But it seems that unfair for slog.JSONHandler and madkins23/flash because they hold mutex -- Although this does not have much impact on single-threaded throughtput testing.
2. I notice that the Disabled benchmark result is unstable. It may be that the performance of each handler implementation is too close, so measurement result has jitter in every time.
3. I guess that the score of samber/slog-logrus is too lower then its score will interfere with the scores of other handlers -- Might consider removing it?
4. In my experience, allocs is a bit import than nanos. for example, a 200 ns/op + 0 allocs/op call seems has a higher score than a 150 ns/op + 1 allocs/op call by right.

Could please re-run phuslu/slog with latest commit

Many thanks for adding phuslu/slog to your benchmark.
The current phuslu/slog is very rough, it only passed slogtest and focus on common performance -- logging/simple/simplesource suites in your repo.
After review&learn your other test cases, I understood that phuslu/slog has poor performance in vary/variable groups cases.

So I tried to improve phuslu/slog performance today, in master branch https://github.com/phuslu/log/commits/master/

Could you please give a chance to verify it? Very appreciate for your works!