magento/inventory

Magento Inventory Project (a.k.a MSI)

Magento Inventory Project (a.k.a MSI)

Welcome to the Magento Inventory community project!

Overview

Multi-Source Inventory (MSI) project is designed to enable stock management in multiple locations so that merchants can properly reflect their physical inventory in Magento without having to use extensions or customization.

Documentation

• Complete user documentation located on the project Magento DevDocs pages
• Technical vision and designs described on the project wiki
• Project roadmap contains information about project phases and stories for each phase
• How to start local development described in the installation guide

Community Engineering Slack

To connect with Magento team and the Community, join us on the Magento Community Engineering Slack. If you are interested in joining Slack, or a specific channel, use our self signup link.

MSI project slack channel: #msi

inventory's Issues

Provide Basic Implementation for Reservation Story

Provide Basic Implementation for Reservation Story according to Technical Design

https://github.com/magento-engcom/magento2/wiki/Reservations

Wrong DocBlocks

Digging in the code of the Inventory module, I've found a repetition of the following DocBlock above __construct() methods:

/**
 * SourceCarrierLinkManagement constructor
 *
 * @param ResourceConnection $connection
 */

I add this issue as a reminder to fix the SourceCarrierLinkManagement reference with the correct class name in which the constructor is declared.

Refactor the Product form

Full context in documentation

[HLD] Inconsistent saving of Stock Data

Description

Currently, the product form sends data to the server in two keys:

1. stock_data
2. quantity_and_stock_status
   After refactoring, the form should send data in a single field.

The best way is to keep the data consistent with Magento WebAPI:

[
    ProductInterface::EXTENSION_ATTRIBUTES_KEY => [
        'stock_item' => [
            StockItemInterface::QTY => 1000,
            StockItemInterface::IS_IN_STOCK => true,
            ...
        ],
    ]

You will also need to update:

• \Magento\CatalogInventory\Ui\DataProvider\Product\Form\Modifier\AdvancedInventory::modifyData

MSI: Add posibility to Disable/Enable source

Currently, we have a Source toggling. To support Disabling the whole source (thus, all the SourceItems allocated in this Source became available for Stock aggregation and should not be taken into account for all Inventory calculations).

Need to add Disable/Enable Button on the Source edit page in admin panel.
Click on that button leads to Enabling/Disabling Source
For now, we have SourceRepositoryInterface which could be used for these purposes (save method updates ENABLE attribute of Source entity).
But we would like to introduce new service for these purposes (SourceDisabling).

*In case of any questions - send an email to [email protected], or ask a question in #MSI Slack channel

Source WebAPI

Description

To allow integration with the external services Web API for Source Management is required. It should provide set of endpoints enabling third-parties with CRUD operations on Sources.

Acceptance Criteria

• Source Management Web API operates with the data structures described in
  SourceInterface
• Source Management Provides the following list of operations on Sources:
  • Loading of the single Source entity by identifier with the GET request.
  • Loading the list of Sources filtered by search criteria with the GET request.
  • Creation of the new Source from the SourceInterface data with the POST request.
  • Update of the existing Source providing identifier and SourceInterface data with the PUT request.
• ACL is defined for endpoints.

Details

Resource	Request method	Permissions	Payload	Response	Implementation	Description
/V1/inventory/source/:sourceId	GET	Admin InventoryApi::source		SourceInterface	Magento\InventoryApi\Api\SourceRepositoryInterface::get	Get Single Source by identifier
/V1/inventory/source/search	GET	Admin InventoryApi::source		SourceInterface[]	Magento\InventoryApi\Api\SourceRepositoryInterface::getList	Load Sources filtered by Search Criteria
/V1/inventory/source	POST	Admin InventoryApi::source, InventoryApi::source_edit	SourceInterface	Created source_id	Magento\InventoryApi\Api\SourceRepositoryInterface::save	Create Source
/V1/inventory/source/:sourceId	PUT	Admin InventoryApi::source	SourceInterface	SourceInterface	Magento\InventoryApi\Api\SourceRepositoryInterface::save	Update Source

Documentation: Source WebAPI

Create Interface for the Source Selection Algorithms

Per Source Selection Algorithms HLD

Following interface will be called by the Magento framework at the point of shipment calculation. Changing the implementation of the interface allows affecting the algorithm of the Warehouse resolution.

use Magento\Quote\Model\Quote\Address\RateRequest;

/**
 * SourceShippingResolverInterface
 */
interface SourceResolverInterface
{
    /**
     * Resolve source shipping data
     *
     * @param RateRequest $request
     * @param ShippingRateCalculator $shippingRateCalculator
     * @return array
     */
    public function resolve(RateRequest $request, ShippingRateCalculator $shippingRateCalculator);
}

Acceptance Criteria

• There is an interface of the Warehouse Selection which can be implemented by the extension to provide the logic of the warehouse selection

MSI: Add Request processor

Need to add to Save controllers extension point for a possibility for extending data processing.

Source to Stock Mapping UI and API

Create the UI, backend logic, and the API to manage the Source mapping to the Stock according to the HLD https://github.com/magento-engcom/magento2/wiki/Sources-to-Sales-Channels-Mapping.

AC:

• it should support many-to-many mapping between sources and stocks
• it should provide UI to manage the addition of new stocks and assigning the stock to sources
• it should provide API for the same functionality

Sources to Sales Channels Mapping. API and Website Implementation

Preconditions

Based on the description provided
https://github.com/magento-engcom/magento2/wiki/Sources-to-Sales-Channels-Mapping
we need to make a mapping between Sources and Sales Channel.

Provide Technical Design Document for Reservation

https://github.com/magento-engcom/magento2/wiki/Reservations

Implement Default Source Selection Algorithm "By Priority"

Per Source Selection Algorithms HLD

Algorithm steps:

1. Get list of sources sorted by priority (source attribute)
2. Take all available products from 1st source by priority. If some of the products in the order couldn't be delivered from the 1st source - get the rest of products from next by priority source.
3. Repeat Step 2. until all the products from the order would be ready to shipping.

Acceptance Criteria:

1. There is default implementation of the source selection interface via "By Priority" source selection algorithm

Add Support of PHP 7 Syntax for MSI APIs

Add Support of

1. Return types declaration
2. Scalar type hinting

For Inventory API service contracts.

Make selected source visible during order fulfillment

Per Source Selection Algorithms HLD

Information about selected warehouse reflected on the Order and be available during the fulfillment.

Acceptance Criteria:

1. Merchant views and modifies sources selected for delivery after order is placed before shipment is created
2. Merchant views relevant source data for all shipments from the order shipments list and detail page for each shipment
3. Merchant defines which sources are used for fulfillment for each website

Support "Update on Save" Indexation for StockItem index

Currently, StockItem index supports just "Update by Schedule" when you need to set-up Cron which will launch the Inventory reindex.

We need to support "Update on Save" as well when changes of Source inventory would be applied immediately for StockItem index

Provide Technical Design for StockItem Index

Provide Technical Design for StockItem Index

Defining of Source API

Description
Define Source API interfaces

Module name: InventoryApi
Edition: Community Edition

Acceptance Criteria

• Module skeleton is created (module config, composer.json, README, license, module can be installed)
• Source API interfaces are defined
• API supports CRUD operations

Documentation:

• Technical Design: Source API

MSI: Update UI components configuration

Update old style to new semantic style

MSI: qty is decimal

Fix all places in code where Quantity (both SourceItem and StockItem) is NOT float
In Database, DECIMAL type should be used (Table::TYPE_DECIMAL)

*In case of any questions - send an email to [email protected], or ask a question in #MSI Slack channel

MSI: Integration tests, API tests for Source functionality

• Source CRUD
• Assigning Sources on Product

Api-functionality tests for web api
Integration tests for controllers

Stock item indexer

Introduce new Inventory index, which will produce and fill the stock_item table with StockItems based on Source to Stock assignment and Inventory on Sources.

Need to create an interface like as StockItemIndexer, StockItemManager in module Inventory
which would be used during the StockItem re-indexation to create StockItem entities

StockItem is aggregated data by Sources Qty which are assigned to the concrete Stock.

Think about how we will use this index, it will direct join, or we need to provide Api interface

Technical Design Document https://github.com/magento-engcom/magento2/wiki/New-Indexer-for-StockItems

Adjust StockItem aggregation functionality to support `OutOfStock` SourceItem during the calculation

Adjust StockItem aggregation functionality to support OutOfStock SourceItem during the calculation.

Currently, indexation mechanism does not take into account that some of the source items could be out of Stock and just sum up all the quantities together.

We need to fix that logic.

So, if there are 3 Sources assigned to the single Stock.
Source A: Qty - 10 Status: In Stock
Source B: Qty - 20 Status: Out Stock
Source C: Qty - 30 Status: In Stock

Current Indexation result is: 10 + 20 + 30 = 60

Expected Behaviour: 10 + 30 = 40

Changes should be covered with Unit Tests and MUST be covered by integration tests (because we can not check full re-indexation work via api-functional tests)

Refactor functional tests

Full context in documentation

[HLD] Inconsistent saving of Stock Data

Description

The table below shows how many times the entities we're changing occur in functional tests.
First of all, it is fixtures creating.

Name	Occurrences in CE
stock_data	56
quantity_and_stock_status	264

Design Checkout Extension Points for Multi-Source

The multi-source inventory affects checkout at the moment when shipping rates are calculated. Having products can be potentially shipped from the multiple locations, there will be multiple origin addresses and multiple packages which have to be shipped.

Design the extension points in the checkout process to inject the logic of multi-source selection and shipment calculation

Marketing tab - Widget List - Duplication - Blank Page

I just updated from Magento 2.1.7 to 2.1.8 and I noticed when I log in to my dashboard and click on the marketing tab, I see two widget list links and both of them go to a blank page. Can you please tell me if this is a bug?

Adjust StockItem aggregation functionality to support Disabled Sources

Adjust StockItem aggregation functionality to support Disabled Sources.

Currently, indexation mechanism does not take into account that some of the sources could be disabled. So that, all the source items in the scope of this Source should be inaccessible as well.

We need to fix that logic.

So, if there are 3 Sources assigned to the single Stock.
Source A: Qty - 10 Status: In Stock
Source B: Qty - 20 Status: In Stock
Source C: Qty - 30 Status: In Stock

But Source B is disabled

Current Indexation result is: 10 + 20 + 30 = 60

Expected Behaviour: 10 + 30 = 40

Changes should be covered with Unit Tests and MUST be covered by integration tests (because we can not check full re-indexation work via api-functional tests)

Add default Source in Data Install.

Currently, Inventory module installed with an absence of Sources. It's incorrect because merchant needs to have some "Default" Source to deal with, as it's implemented in Single Stock Magento.
Read this document for more details - https://github.com/magento-engcom/msi/wiki/The-Concept-of-Default-Source-and-Domain-Driven-Design

What we need to do is:

to Add Install data with default Source created. Pre-fill data for Default Source.
to check that after Magento Installation Default Source added. Cover this behavior with Integration test.

*In case of any questions - send an email to [email protected], or ask a question in #MSI Slack channel

Update Product model

Full context in documentation

[HLD] Inconsistent saving of Stock Data

Description

Сreate a single point of data (source of truth) for write operations.
Proxy all methods with stock data manipulation to StockItem.

Prototype:

// \Magento\Catalog\Model\Product
class Product 
...
    public function __construct(
        ...
        array $data = [],
        StockRegistryInterface $stockRegistry = null,
        HydratorInterface $hydrator = null    
    ) {
        ...
        $this->stockRegistry = $stockRegistry ?: \Magento\Framework\App\ObjectManager::getInstance()
            ->get(StockRegistryInterface::class);
        $this->hydrator = $hydrator ?: \Magento\Framework\App\ObjectManager::getInstance()
            ->get(HydratorInterface::class);
    }
    ... 
    /**
     * {@inheritdoc}
     *
     * This method has been overridden only for backward compatible work with stock item (stock_data,
     * quantity_and_stock_status keys)
     *
     * Use \Magento\Catalog\Api\Data\ProductExtensionInterface::getStockItem for retrieving of stock item data (or stock
     * status index)
     * Use \Magento\Catalog\Api\Data\ProductInterface for retrieving of product data
     *
     */
    public function getData($key = '', $index = null)
    {
        if ('stock_data' === $key) {
            $result = $this->getStockData();
        } elseif ('quantity_and_stock_status' === $key) {
            $result = $this->getQuantityAndStockStatus();
        } else {
            $result = parent::getData($key, $index);
        }
        return $result;
    }
    
    /**
     * {@inheritdoc}
     *
     * This method has been overridden only for backward compatible work with stock item (stock_data,
     * quantity_and_stock_status keys)
     *
     * Use \Magento\Catalog\Api\Data\ProductExtensionInterface::setStockItem for updating of stock item data
     * Use \Magento\Catalog\Api\Data\ProductInterface for updating of product data
     *
     */
    public function setData($key, $value = null)
    {
        if ('stock_data' === $key) {
            $result = $this->setStockData($value);
        } elseif ('quantity_and_stock_status' === $key && is_array($value)) {
            $result = $this->setQuantityAndStockStatus($value);
        } else {
            $result = parent::setData($key, $value);
        }
        return $result;
    }
    
    /**
     * @return array
     * @deprecated Use \Magento\Catalog\Api\Data\ProductExtensionInterface::getStockItem for retrieving of stock item
     * data (or stock status index)
     */
    public function getStockData()
    {
        $stockItem = $this->resolveStockItem();
        return $this->hydrator->extract($stockItem);
    }
    
    /**
     * @param array $stockData
     * @return $this
     * @deprecated Use \Magento\Catalog\Api\Data\ProductExtensionInterface::setStockItem for updating of stock item data
     */
    public function setStockData(array $stockData)
    {
        $stockItem = $this->resolveStockItem();
        $this->dataObjectHelper->populateWithArray(
            $stockItem,
            $stockData,
            StockItemInterface::class
        );
        return $this;
    }
    
    /**
     * @return array
     * @deprecated Use \Magento\Catalog\Api\Data\ProductExtensionInterface::getStockItem for retrieving of stock item
     * data (or stock status index)
     */
    public function getQuantityAndStockStatus()
    {
        return $this->getStockData();
    }
    
    /**
     * @param array $quantityAndStockStatusData
     * @return $this
     * @deprecated Use \Magento\Catalog\Api\Data\ProductExtensionInterface::setStockItem for updating of stock item data
     */
    public function setQuantityAndStockStatus(array $quantityAndStockStatusData)
    {
        return $this->setStockData($quantityAndStockStatusData);
    }
    
    /**
     * @return StockItemInterface
     */
    private function resolveStockItem()
    {
        $extensionAttributes = $this->getExtensionAttributes();
        $stockItem = $extensionAttributes->getStockItem();
        if (null === $stockItem) {
            $stockItem = $this->stockRegistry->getStockItem($this->getId());
            $extensionAttributes->setStockItem($stockItem);
            $stockItem->setProduct($this);
        }
        return $stockItem;
    }

Source Management UI

As a Merchant I would like to be able create and manage inventory locations so that my sources can be used for delivery and inventory management with the correct information assigned to each source.

Acceptance Criteria

• Possible to create sources in admin panel
• Possible to manage (edit and disable) source information in admin panel (Note: should not be possible to delete a warehouse with inventory assigned)
• Disabled source can still have inventory assigned but it cannot be used for any orders
• Possible to hide disabled sources from Source grid. Disabled warehouses are hidden by default and can be shown by admin user
• Source attributes are
  • Name
  • ID
  • Description
  • Address
  • Contact Name
  • Contact Email
  • Contact Phone (user account)
  • Address
  • Latitude/Longitude,
  • flag/status for physical store
  • flag/status for 3rd party warehouse
  • list of enabled shipping methods
• Source can use global address as address or a different address (entered by admin user)
• Possible to view sources and associated data in grid from admin panel with normal grid options (filter, sort, pagination, column select)
• Ability to edit source can be assigned/denied in user roles configuration (ACL)

Documentation:

• Admin UI: Source Management

MSI: Remove dependency Inventory on Catalog

Split Inventory module into: Inventory, InventoryCatalog
Foreign key (sku on catalog_product_entity) will be added in InventoryCatalog

• forms
• data providers
• controller processing

Merge M2 Develop Branch into MSI fork Develop to Support PHPUnit 6.1

Merge M2 Develop Branch into MSI fork Develop to Support PHPUnit 6.1

*In case of any questions - send an email to [email protected], or ask a question in #MSI Slack channel

Source API Implementation

Description
Implement Source API interfaces

Module name: Inventory
Edition: Community Edition

Acceptance Criteria

• Module skeleton is created (module config, composer.json, README, license, module can be installed)
• Implementation of Source API interfaces are provided
• All API implementations are covered by unit/integration tests
• Source db table is created during installation

Documentation:

• Technical Design: Source API

Update all integration tests

Full context in documentation

[HLD] Inconsistent saving of Stock Data

Description

Integration tests should use the only eligible API for writing data using StockItem interface

Order Management UI

[TBD]

Make Framework use Source Selection Interface

Per Source Selection Algorithms HLD

Magento framework should invoke the interface of the source selection algorithm created at #8 at the point of shipment calculation. Changing the implementation of the interface allows affecting the algorithm of the Warehouse resolution.

Acceptance Criteria

The interface is used by the Magento framework during the shipping rate calculation. Shipping rate calculation which uses the interface is:
1. compatible with bundle products
2. compatible with configurable products
3. compatible with backorders
4. compatible with multi-address shipping

Deprecate the 'quantity_and_stock_status' attribute backend model

Full context in documentation

[HLD] Inconsistent saving of Stock Data

Description

Deprecate the \Magento\Catalog\Model\Product\Attribute\Backend\Stock attribute backend model.
Remove all logic.
Taking into account proposed changes, it makes no sense to keep this logic.

Create a single point of stock data processing

Full context in documentation

[HLD] Inconsistent saving of Stock Data

Description

1. Unite logic in a single processing point

The logic of the following classes:

• \Magento\CatalogInventory\Model\Plugin\AroundProductRepositorySave
• \Magento\CatalogInventory\Observer\SaveInventoryDataObserver
  should be united in a single "processing" point. It could be a SaveInventoryProcessor class, like in the example below.

PAY ATTENTION: this logic is needed ONLY for BI (saving stock item data on product save). In proper way, we need to save StockItem only via StockItemRepositoryInterface
Also, we now save via stockregistry only for BI.

/**
 *  Dockblock like as "this logic is needed ONLY for BI (saving stock item data on product save). In propel way, we need to save StockItem only via StockItemRepository"
 */
class SaveInventoryProcessor (NOT INTERFACE)
{
    /**
     * Saving product inventory data
     *
     * @param Product $product
     * @return $this
     * @throws LocalizedException
     */
    public function execute(Product $product)
    {
        $stockItem = $this->getStockItemToBeUpdated($product);
        if (null !== $stockItem) {
            $stockItem->setProductId($product->getId());
            $stockItem->setWebsiteId($this->stockConfiguration->getDefaultScopeId());
            $this->stockItemValidator->validate($product, $stockItem);
            $this->stockRegistry->updateStockItemBySku($product->getSku(), $stockItem);
        }
        return $this;
    }
    
    /**
     * Return the stock item that needs to be updated
     *
     * @param ProductInterface $product
     * @return StockItemInterface|null
     */
    private function getStockItemToBeUpdated($product)
    {
        $stockItem = null;
        $extendedAttributes = $product->getExtensionAttributes();
        if ($extendedAttributes !== null) {
            $stockItem = $extendedAttributes->getStockItem();
        }
    
        if ($stockItem === null) {
            $stockItem = $this->stockRegistry->getStockItem($product->getId());
        }
        return $stockItem;
    }
}

The processing logic of saving data via model and via product repository must be the same!

2. Move validation logic from ProductRepositoryPlugin to a separate class.

For example:

<?php
/**
 * Copyright © 2016 Magento. All rights reserved.
 * See COPYING.txt for license details.
 */
namespace Magento\CatalogInventory\Model;

use Magento\Catalog\Api\Data\ProductInterface;
use Magento\CatalogInventory\Api\Data\StockItemInterface;
use Magento\CatalogInventory\Api\StockConfigurationInterface;
use Magento\CatalogInventory\Api\StockRegistryInterface;
use Magento\Framework\Exception\LocalizedException;

/**
 * StockItemValidator
 */
class StockItemValidator (NOT INTERFACE)
{
    /**
     * @var StockConfigurationInterface
     */
    private $stockConfiguration;

    /**
     * @var StockRegistryInterface
     */
    private $stockRegistry;

    /**
     * @param StockConfigurationInterface $stockConfiguration
     * @param StockRegistryInterface $stockRegistry
     */
    public function _construct(
        StockConfigurationInterface $stockConfiguration,
        StockRegistryInterface $stockRegistry
    ) {
        $this->stockConfiguration = $stockConfiguration;
        $this->stockRegistry = $stockRegistry;
    }

    /**
     * @param ProductInterface $product
     * @param StockItemInterface $stockItem
     * @throws LocalizedException
     * @return void
     */
    public function validate(ProductInterface $product, StockItemInterface $stockItem)
    {
        $defaultScopeId = $this->stockConfiguration->getDefaultScopeId();
        $defaultStockId = (int)$this->stockRegistry->getStock($defaultScopeId)->getStockId();
        $stockId = (int)$stockItem->getStockId();
        if ($stockId !== null && $stockId !== $defaultStockId) {
            throw new LocalizedException(
                __('Invalid stock id: %1. Only default stock with id %2 allowed', $stockId, $defaultStockId)
            );
        }

        $stockItemId = $stockItem->getItemId();
        if ($stockItemId !== null && (!is_numeric($stockItemId) || $stockItemId <= 0)) {
            throw new LocalizedException(
                __('Invalid stock item id: %1. Should be null or numeric value greater than 0', $stockItemId)
            );
        }

        $defaultStockItemId = $this->stockRegistry->getStockItem($product->getId())->getItemId();
        if ($defaultStockItemId && $stockItemId !== null && $defaultStockItemId !== $stockItemId) {
            throw new LocalizedException(
                __('Invalid stock item id: %1. Assigned stock item id is %2', $stockItemId, $defaultStockItemId)
            );
        }
    }
}

Also need to investigate about moving this logic in StockItemRepository

Create Inventory Module Skeleton

Module name: Inventory
Edition: Community Edition

Acceptance Criteria

• Module skeleton is created (module config, composer.json, README, license, module can be installed)

Resolve problem with origin data

Full context in documentation

[HLD] Inconsistent saving of Stock Data

Description

We have the following situation in _\Magento\Catalog\Model\Product.php#L2298

/**
 * Check whether stock status changed
 *
 * @return bool
 */
private function isStockStatusChanged()
{
    $stockItem = null;
    $extendedAttributes = $this->getExtensionAttributes();
    if ($extendedAttributes !== null) {
        $stockItem = $extendedAttributes->getStockItem();
    }
    $stockData = $this->getStockData();
    return (
        (is_array($stockData))
        && array_key_exists('is_in_stock', $stockData)
        && (null !== $stockItem)
        && ($stockItem->getIsInStock() != $stockData['is_in_stock'])
    );
}

We need to DELETE or REFACT this code.
So, we need to check the origin of the Stock Status value. We can solve in several ways:

1. [Recommended] Create a mechanism for tracking the origin entity data, based on EntityStateInterface. For this, a separate HLD is required.
2. Use origin data from StockItem like as $stockItem->getOriginData('status')
3. Create a simple model like this:

class ProductOriginStockStatusChecker
{
    public function getValue()
    {
        // resolving from origin data or direct call to db or 
    } 
}

4. Using of private property in Product model for storing stock status data.

Implement Default Source Selection Algorithm "By Minimal Delivery Cost"

Per Source Selection Algorithms HLD

Algorithm steps:

Delivery to fulfill the order could be made from one or several (more than one) sources

1. Evaluate each source for one product delivery
2. Fulfill the order by minimal cost sources (result is sum of each value)
3. Recalculate Shipping cost based on previous step result. Obtained value is displayed for the customer.

Acceptance Criteria:

1. There is default implementation of the source selection interface via "By Minimal Delivery Cost" source selection algorithm

Refactor import and export

Full context in documentation

[HLD] Inconsistent saving of Stock Data

Description

1. Skip attribute from import

For \Magento\CatalogImportExport\Model\Import\Product\Type\AbstractType:

namespace Magento\CatalogImportExport\Model\Import\Product\Type;
abstract class AbstractType
{
    /**
     * This property has been added in scope of work for backward compatible of stock item processing (work with
     * stock_data and quantity_and_stock_status keys)
     * quantity_and_stock_status attribute will be deleted
     *
     * @var array
     */
    private $attributesToSkip = ['quantity_and_stock_status']; // values must be configurable via DI
    ...
    public function prepareAttributesWithDefaultValueForSave(array $rowData, $withDefaultValue = true)
    {
        $resultAttrs = [];
    
        foreach ($this->_getProductAttributes($rowData) as $attrCode => $attrParams) {
            if ($attrParams['is_static'] || in_array($attrCode, $this->attributesToSkip)) {
                continue;
            }
    ...
}

For the import test, \Magento\CatalogImportExport\Model\AbstractProductExportImportTestCase:

namespace Magento\CatalogImportExport\Model;

abstract class AbstractProductExportImportTestCase extends \PHPUnit_Framework_TestCase
{
    ...
    public static $skippedAttributes = [
    ...
    'quantity_and_stock_status',
    ];
    ...
}    

2. [Important!] Check possibility to disable/enable the Out of Stock status when importing products

3. Check and if needed replace 'quantity_and_stock_status' attribute with stock item data in Import/Export.

Create Warehouse Selection Algorithm for the Shipping

Overview

Multiple Nodes Inventory implies that the products will be stored in multiple locations. When Customer buys the product, it should be shipped from the particular location. A customer usually does not care what location product was shipped from, as soon as this is the cheapest option. For the Merchant, it is important to have minimal overhead for the inventory storage and shipping costs. An algorithm which assigns the particular inventory to the order item should take all these considerations into account and select the best possible options.

Use-Case

To visualize the process of the warehouse selection let's describe the following use-case. Customers create an Order to buy products A, B and C:

Product	Qty
A	5
B	2
C	7

Merchant has following stock quantities in warehouses X, Y and Z

Product	Warehouse	Qty
A	X	10
A	Y	10
A	Z	10
B	X	1
B	Y	1
B	Z	1
C	X	5
C	Y	2
C	Z	7

There are multiple possible options on how to fulfill the order:

1. Ship 10xA from the Warehouse X, 1xB from the X and 1xB from Z, 5xC from the X and 2xC from Y
2. Ship 5xA from X and 5xA from Y, 1xB from the X and 1xB from Z, 7xC from the Z
3. etc

As you can see there are multiple possible strategies on how to optimize order fulfillment:

• try to ship as much as possible from one warehouse. This minimizes packaging costs and possibly shipping cost
• try to distribute the load between warehouses. This minimizes storage cost
• select warehouse based on the cost of shipment to the merchant address for the particular Carrier
• select warehouse based on the shipment time

The order fulfillment algorithm should pick the location of the product and use it to calculate the shipping cost.

Problem

Earlier implementations of MNI identified the problems with the advanced algorithms of the warehouse selection. For example, if the warehouse selected based on the delivery cost, for every possible combination of warehouses system should perform the API call to the carrier to retrieve the shipping cost.

Approach

It is impossible for the Magento platform to predict all the circumstances which affect inventory and shipping costs for the particular merchant. That's why instead of implementing all possible optimizations of the algorithm selection, the framework will contain the interface which is used to resolve the Source for the order item. Different implementations of the algorithm will contain
Implementations, provided by the 3-d party extensions will allow affecting the priorities of the warehouse selection depending on the particular case where Magento is used.

Magento framework will provide the default, rule-based algorithm which allows configuring the priority of warehouses depending on the source origin, shipping address and the selected carrier.

Interfaces

Following interface will be called by the Magento framework at the point of shipment calculation. Changing the implementation of the interface allows affecting the algorithm of the Warehouse resolution.

use Magento\Quote\Model\Quote\Address\RateRequest;

/**
 * SourceShippingResolverInterface
 */
interface SourceResolverInterface
{
    /**
     * Resolve source shipping data
     *
     * @param RateRequest $request
     * @param ShippingRateCalculator $shippingRateCalculator
     * @return array
     */
    public function resolve(RateRequest $request, ShippingRateCalculator $shippingRateCalculator);
}

Default Algorithm

Magento will allow creating rules of selecting the fulfillment warehouse based on following pieces of information:

• warehouses addresses
• customer shipping address
• carrier

The rules will be defined in the format: (Customer State, Carrier) -> Warehouse
The rules will be configured in the CSV file and imported to the Magento.

Implementation Items

Following items need to be implemented in order to make Warehouse selection work in Magento:

• Create interface of the Warehouse resolution
• Inject interface to the Magento framework and use it during shipping rate calculation. Implement it for complex cases such as Bundle or Grouped products.
• Make information on selected warehouse reflected on the Order and be available during the fulfillment
• Implement default algorithm which works based on configured rules
• implement import of rules via CSV File

Stock Management UI

[TBD]

MSI: Resolve Country and Region view in grid

Create/Update testing scenario to check following functionality.
Source Grid displays region correctly when:

• specified custom region entered manually
• specified region selected from predefined values

Fix Product model

Full context in documentation

[HLD] Inconsistent saving of Stock Data

Description

1. Replace 'getExtensionAttributes' method

/**
 * {@inheritdoc}
 *
 * @return \Magento\Catalog\Api\Data\ProductExtensionInterface
 */
public function getExtensionAttributes()
{
    $extensionAttributes = $this->_getExtensionAttributes();
    if (!$extensionAttributes) {
        /** @var \Magento\Catalog\Api\Data\ProductExtensionInterface $extensionAttributes */
        $extensionAttributes = $this->extensionAttributesFactory->create(
            \Magento\Catalog\Api\Data\ProductInterface::class
        );
        $this->setExtensionAttributes($extensionAttributes);
    }
    return $extensionAttributes;
}

After replacing, we nave a problem: the extensionAttributes is recreated every time the method is called.

2. Fix 'toArray' and 'fromArray'

The entities:

• \Magento\Catalog\Model\Product::toArray
• \Magento\Catalog\Model\Product::fromArray
  must be changed to get the stock inventory data from the current StockItem.

3. Remove reindexing from 'afterSave'

Remove the following from the \Magento\Catalog\Model\Product::afterSave:

if ($this->getStockData()) {
    $this->setForceReindexEavRequired(true);
}

Source Ui Backend

Description

• - Implement Filter Regions by selected Country in UI
• -Add Resolve Country and region view in grid

Module name: Inventory

Integration of multi-stock data with Import/Export

[TBD]

Add possibility To Delete Stocks in Admin Panel

Add possibility To Delete Stocks in Admin Panel

*In case of any questions - send an email to [email protected], or ask a question in #MSI Slack channel

Implement Delivery Cost Configuration

Per Source Selection Algorithms HLD

To support Minimal Delivery Cost algorithm, Magento should have some source of information about the shipping prices. This information can be statically stored in the database. The source of information should be imported from the CSV file.

Magento will allow creating rules of selecting the fulfillment warehouse based on following pieces of information:

• warehouses addresses
• customer shipping address
• carrier

The rules will be defined in the format: ``(Customer State, Carrier) -> Warehouse.''
By default, Magento will provide the way to import the rules will be configured in the CSV file.

Acceptance Criteria

1. Magento allows to perform Delivery Cost Configuration used by the Minimal Delivery Cost algorithm
   1. Delivery costs for different source locations, different destinations and different carriers are stored in the database
   2. Delivery costs can be imported via CSV File

StockItem Indexation

Task for Basic implementation of StockItem Indexation

Technical Desing Could be found here - https://github.com/magento-engcom/magento2/wiki/New-Indexer-for-StockItems

Refactor the Configurable Product form

Full context in documentation

[HLD] Inconsistent saving of Stock Data

Description

For this refactoring, you will need to:

• update the Configurations section in configurable product form (creating and updating)
• remove logic from \Magento\ConfigurableProduct\Model\Product\VariationHandler

if (!isset($postData['stock_data']['is_in_stock'])) {
    $stockStatus = $parentProduct->getQuantityAndStockStatus();
    $postData['stock_data']['is_in_stock'] = $stockStatus['is_in_stock'];
}