Comments (15)
Hi @ZandaBear. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release- For more details, review the Magento Contributor Assistant documentation.
- Add a comment to assign the issue:
@magento I am working on this
- To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
from magento2.
Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
- 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
- 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
- 3. Add
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to. - 4. Verify that the issue is reproducible on
2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-develop
branch, please, add the labelReproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here! - 5. Add label
Issue: Confirmed
once verification is complete. - 6. Make sure that automatic system confirms that report has been added to the backlog.
from magento2.
Hi @ZandaBear,
Thank you for reporting and collaboration.
Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.
Steps to reproduce
- Go to pagebuilder in adminhtml.
- Add row.
- Add element such as image, banner, slider, etc. Make it 400x400px for this example.
- Set minimum height on row or element (either one) to any static value, 200px for this example.
- Save page and go to view changes on front end.
row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 200px
Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.
Thanks.
from magento2.
Hey @engcom-Bravo,
Correction, it appears "Media -> Image" is the only one functioning correctly. Updated initial report to match.
As you can see pictured, with "Banner" all three modes, in order from top to bottom of Cover, Contain, Auto are incorrectly locking the height at 100px.
So, the issue appears to be encountered when doing the following...
-> Image is set as Background of row (not using Media->Image)
-> Image is set as Banner background.
-> Image is set as a Slider Image (not background).
A similar, but different issue encounter is that the image will always look like the top-most "cover" instance in the screenshot when...
-> Image is set as Slider background (NOT as a slide).
from magento2.
@magento give me 2.4-develop instance
from magento2.
Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.
from magento2.
Hi @engcom-Bravo, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering
Admin access: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering/admin_da4c
Login: c3c96138
Password: 376a1edbb7c8
from magento2.
Hi @ZandaBear,
Thanks for your update.
Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.
Steps to reproduce
- Go to pagebuilder in adminhtml.
- Add row.
- Add image to element as a row background, as a banner background, or as a slider slide. Make it 200x200px for this example.
- Set minimum height on row or element (either one) to any static value, 100px for this example.
- Save page and go to view changes on front end.
row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 100px.
Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.
Thanks.
from magento2.
@magento give me 2.4-develop instance
from magento2.
Hi @ZandaBear. Thank you for your request. I'm working on Magento instance for you.
from magento2.
Hi @ZandaBear, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering
Admin access: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering/admin_3642
Login: 6228b27c
Password: f3bc4ebf81a7
from magento2.
@engcom-Bravo If you are setting the row to 100px then of course you must verify that the element's minimum height is not set to a greater value. For example, by default Magento sets banners to have a minimum height of 300px.
See screenshot for proof of the behavior I described in the initial post from the developer instance. For the screenshot, Row minimum height was set to 100px. Banner minimum height was cleared. Verified same behavior when the Row minimum height is cleared and Banner minimum is set to 100px.
As you can see, page-builder is not scaling banners or sliders in accordance with a minimum of 100px for the element. It is stretching or cropping the image used to a set height of 100px. The headers describe what each element is using. Only the top one is the correct size for the image of 200x200px.
from magento2.
Related Issues (20)
- [Issue] [vcl] don't manually interfere with compression HOT 5
- About deleting license copyright comments in .html files HOT 1
- CSS minifiying sometimes results in blank CSS file due to PREG_JIT_STACK_LIMIT_ERROR in tubalmartin/cssmin HOT 8
- Animated gif not working HOT 23
- Missing indexing of required columns in catalog_product_entity_int table HOT 3
- Set Generate "category/product" URL Rewrites to "no" has no effect HOT 13
- Coupon usage limits not honored HOT 7
- Sales order item table, qty_backordered not set for configurable products HOT 9
- Currency not convert in new product widget without cache clean HOT 26
- Getting Database CPU usages high (100%) suddenlly HOT 7
- Configurbale Product update child product saving qty move issue HOT 24
- Cannot make city field optional in addresses HOT 6
- Columns functionality for \Magento\Theme\Block\Html\Topmenu seems broken HOT 6
- Export Product does not working with Large number of attribute HOT 12
- We are not getting the product_type and parent_item_id inside refund HOT 15
- magento 2 Braintree error verifyCard options must include a BIN. HOT 4
- We are not getting the base_grand_total value in order response HOT 13
- Customer address form allows random code in the name fields HOT 20
- Magento/OfflineShipping/Model/Carrier/Tablerate.php::collectRates is modifying the request for subsequent carriers HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento2.