Giter Site home page Giter Site logo

Comments (15)

m2-assistant avatar m2-assistant commented on June 2, 2024

Hi @ZandaBear. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

from magento2.

m2-assistant avatar m2-assistant commented on June 2, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

from magento2.

engcom-Bravo avatar engcom-Bravo commented on June 2, 2024

Hi @ZandaBear,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Go to pagebuilder in adminhtml.
  • Add row.
  • Add element such as image, banner, slider, etc. Make it 400x400px for this example.
  • Set minimum height on row or element (either one) to any static value, 200px for this example.
  • Save page and go to view changes on front end.

New

Screenshot from 2023-12-26 11-58-14

row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 200px

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

from magento2.

ZandaBear avatar ZandaBear commented on June 2, 2024

Hey @engcom-Bravo,

Correction, it appears "Media -> Image" is the only one functioning correctly. Updated initial report to match.
github 100px lock

As you can see pictured, with "Banner" all three modes, in order from top to bottom of Cover, Contain, Auto are incorrectly locking the height at 100px.

So, the issue appears to be encountered when doing the following...
-> Image is set as Background of row (not using Media->Image)
-> Image is set as Banner background.
-> Image is set as a Slider Image (not background).

A similar, but different issue encounter is that the image will always look like the top-most "cover" instance in the screenshot when...
-> Image is set as Slider background (NOT as a slide).

from magento2.

engcom-Bravo avatar engcom-Bravo commented on June 2, 2024

@magento give me 2.4-develop instance

from magento2.

magento-deployment-service avatar magento-deployment-service commented on June 2, 2024

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

from magento2.

magento-deployment-service avatar magento-deployment-service commented on June 2, 2024

Hi @engcom-Bravo, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering
Admin access: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering/admin_da4c
Login: c3c96138
Password: 376a1edbb7c8

from magento2.

engcom-Bravo avatar engcom-Bravo commented on June 2, 2024

Hi @ZandaBear,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Go to pagebuilder in adminhtml.
  • Add row.
  • Add image to element as a row background, as a banner background, or as a slider slide. Make it 200x200px for this example.
  • Set minimum height on row or element (either one) to any static value, 100px for this example.
  • Save page and go to view changes on front end.

Screenshot from 2024-01-03 13-08-49

row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 100px.

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

from magento2.

ZandaBear avatar ZandaBear commented on June 2, 2024

@magento give me 2.4-develop instance

from magento2.

magento-deployment-service avatar magento-deployment-service commented on June 2, 2024

Hi @ZandaBear. Thank you for your request. I'm working on Magento instance for you.

from magento2.

magento-deployment-service avatar magento-deployment-service commented on June 2, 2024

Hi @ZandaBear, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering
Admin access: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering/admin_3642
Login: 6228b27c
Password: f3bc4ebf81a7

from magento2.

ZandaBear avatar ZandaBear commented on June 2, 2024

@engcom-Bravo If you are setting the row to 100px then of course you must verify that the element's minimum height is not set to a greater value. For example, by default Magento sets banners to have a minimum height of 300px.

See screenshot for proof of the behavior I described in the initial post from the developer instance. For the screenshot, Row minimum height was set to 100px. Banner minimum height was cleared. Verified same behavior when the Row minimum height is cleared and Banner minimum is set to 100px.

Magento Issue Proof

As you can see, page-builder is not scaling banners or sliders in accordance with a minimum of 100px for the element. It is stretching or cropping the image used to a set height of 100px. The headers describe what each element is using. Only the top one is the correct size for the image of 200x200px.

from magento2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.