Comments (1)
@stalniy
Thank you for the proposed code changes.
Entire mechanism of wrapping native object creation aims to support classes rewrite customization feature. Unfortunately,
proposed approach is incompatible with the class rewrites.
Regarding static dependencies on the Mage
class, you're right, it does make sense to eliminate or at least reduce such dependencies. Currently, there is a research going on regarding the dependency injection container adoption for that purpose, stay tuned.
Closing the ticket, since proposed approach dramatically reduces existing customization capabilities.
from magento2.
Related Issues (20)
- Shop By Category Filter Visible On Non-Anchor Categories HOT 9
- media-width single quotes only HOT 2
- Collapsible make scrollToTopIfNotVisible optional? HOT 5
- Base table or view not found: 1146 Table 'magento.tfa_user_config' doesn't exist HOT 3
- ProductRepository function GetById does not create the correct cache key HOT 5
- [ERROR] Failed to load the "Magento_Checkout/js/view/form/element/email" component #38274 HOT 5
- Invoice PDF displays company address on Sold To: and Bill to: address fields instead of customer address in Magento 2.4.5 on all orders. HOT 6
- Error Validating Media Gallery Metadata fields HOT 8
- Credit memo tax error - off by 1 cent HOT 6
- Can't add product images roles with $product->addImageToMediaGallery HOT 4
- Tier Price is not being deleted from Configurable Product HOT 10
- emoji not allow in subject email HOT 13
- [Issue] Adding created_at, status and grand_total filters to customer Orders query and fixing multiple filters failure HOT 3
- Scope bug in Catalog URL resource (_getCategories) HOT 2
- Apostrophe in store view name is replaced by ' HOT 3
- CVS Product Import when attribute backend_type static. HOT 7
- Type Mismatch in Data Comparison when checking if data has changes HOT 5
- Recent fresh install of 2.4.6-p3 adds border to backend grids HOT 10
- 1 exception(s): Exception #0 (Exception): Warning: Undefined array key 0 in vendor/colinmollenhour/php-redis-session-abstract/src/Cm/RedisSession/Handler.php on line 515 HOT 12
- Unexpected token '}' when configure product in admin create order HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento2.