magepal/magento2-edit-order-email

Magento2 - Edit Order Email from Admin

magepal

MagePal Extensions - Install our extensions with confidence knowing that they will just work! But if you run into an issue... no problem, we normally solved all issues in 15 minutes or less.

magento2-edit-order-email's Issues

magePalCoreNotificationsIcon.js fails to load on M2.4.0 in admin backend

magePalCoreNotificationsIcon.js fails to load on M2.4.0 in admin backend

Debug from Chrome console log...

JQMIGRATE: Migrate is installed with logging active, version 1.4.1
require.js:1895 GET

https://www.example.com/pub/static/adminhtml/Magento/backend/en_US/magePalCoreNotificationIcon.js net::ERR_ABORTED 404

main.js:44 Error: Script error for: magePalCoreNotificationIcon
http://requirejs.org/docs/errors.html#scripterror
at makeError (require.js:166)
at HTMLScriptElement.onScriptError (require.js:1681)

Fails to install on M2.4.4 (php 8.1)

$ composer require --update-no-dev magepal/magento2-edit-order-email
Info from https://repo.packagist.org: #StandWithUkraine

[InvalidArgumentException]
Package magepal/magento2-edit-order-email has requirements incompatible with your PHP version, PHP extensions and Composer version:
- magepal/magento2-edit-order-email 1.1.6 requires php ~5.6.0|7.0.2|7.0.4|~7.0.6|~7.1.0|~7.1.3|~7.2.0|~7.3.0|~7.4.0 which does not match your installed version 8.1.4.

No error message when updating customer email which is already existed in customer record

When updating customer email (checked "Update Customer Record") which is already existed in customer record, there is no error message. Although the email is updated in order, it remains un-change in customer record due to unique email rule.

Error message should be showing up to notice user that the email in customer record remain un-change, instead of saying "Email address successfully changed".

Can't send order email from admin after editing email address.

Magento v2.4.1
PHP v7.4.14

Steps to replicate.

1. Place an order as a guest customer.
2. Check you receive the order confirmation.
3. Login to the admin area, find the order and click 'Send Email' and hit OK.
4. Check you receive order confirmation.
5. Edit the email address on the order to a different email address.
6. Login to the admin area, find the order and click 'Send Email' and hit OK.
7. Check you receive order confirmation.

Expected outcome
At points 2, 4 and 7 you should receive an order confirmation email.

Actual outcome
Email only received on points 2 and 4. After editing the email address the email is no longer sent at point 7.

When clicking the send email button in the admin the page refreshes but no confirmation message is shown as in steps 2 and 4.

Change several times doesn´t work

Another issue we found in our testing is when you try to update several times the e-mail without refreshing the order page, sometimes will not work, in example If I change the e-mail from [email protected] to [email protected], works, if I change second time to [email protected] ,although the new e-mail appears changed in the account information, order page, after the Ajax refresh, if you refresh the page it shows [email protected] on the order.

No update in order address

Hi. I was using this module for several projects and one customer detected a 3rd party retrieves still the old email after the change.
Inspecting the database I see the order address is not being changed.
Can add this feature in the code or make it as optional via configuration?

I´m using those lines in the controller after save the order, and is doing the job.

foreach ($order->getAddressesCollection() as $address) { $address->setEmail($emailAddress)->save(); }

Update customer record email address not working

Hi, developers

I want to notice an issue in our installation of Magento 2.3.2

When you have the value of 'Automatically update customer record email address' to No (Default) and you edit the order e-mail checking the checkbox ' Update Customer Record', the customer data are is really not modified. I debugged the MagePal\EditOrderEmail\Controller\Adminhtml\Edit\Index and the 'update_customer_email' param received appears undefined, so the logic never proceeds to change the e-mail in the customer account.

I think the solution would be just to change the part of template
view/adminhtml/templates/email.phtml

<input type="checkbox" class="checkbox" id="update_customer_email" name="update_customer_email" value="<?= $block->getAutocheckEmail() ?>" <?= $checked ?>>

to

<input type="checkbox" class="checkbox" id="update_customer_email" name="update_customer_email" value=1 <?= $checked ?>>

I tested it and looks working.