magicalex/writeinifile

Write-ini-file php library for create, remove, erase, add, and update ini file

writeinifile's Issues

Value with quote not escaped

I have a project which stores a third party command. The command is as follows: ./bin/cscript --title="Greg's program" --output=./dist/.

The output of WriteiniFile produces something like this:

[compiler]
name=cscript
command="./bin/cscript --title="Greg's program" --output=./dist/"

I believe that the double quotes should be escaped, as parsing the produced ini file fails with syntax error, unexpected 'G'.

Add the ability to set $process_sections to false

PHP's parse_ini_file function's second argument is $process_sections. By default it is set to false.
I wanted to write a simple .ini file (without sections) but noticed that your package requires that the .ini file has sections so it won't work on simple .ini files.

I'll include a pull request that will let people specify the $process_sections attribute when needed.

empty string converted to 0

If a value is an empty string, it's converted to 0, which is generally not what's wanted.

The encode() method would need to be changed.

Linux EOL always used

When writing the .ini file the unix end of line, \n, character is always used. This breaks some Windows applications that parse ini files assuming \r\n has been used.

In this method https://github.com/Magicalex/WriteiniFile/blob/master/src/WriteiniFile.php#L93 \n should be replaced by PHP_EOL.