Giter Site home page Giter Site logo

xpomusic's People

Contributors

mahdighiasi avatar mgoulao avatar padmick avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

xpomusic's Issues

Show alert when adding a song to the playlist which is already there

When I am adding some song to one of my playlists, it doesn't show a warning about a duplicate song, as the official Spotify app, it will automatically add the song to the playlist multiple times.

duplicate-song

I think this should be done the same way as in the Spotify app, ask each time for confirmation.

Pause button not showing on home screen

As you can see, the pause button is clearly visible over the album cover here.

image

But on the home screen is still shows the play button, which is different from the way the official Spotify client handles it.

image

I am unsure if this is related to the recent message about some broken functionality because I do not remember if this behavior existed before.

UI is extremely fuzzy when viewed on a monitor with portrait display orientation

Description
When viewing Xpo Music on a monitor in portrait display orientation, the main UI is extremely fuzzy. This includes text and images. The left hand menu, settings menu and now playing bar remain unaffected.

This issue is not seen on the same monitor in landscape display orientation.

To Reproduce
Steps to reproduce the behavior:

  1. Use Xpo music on monitor in portrait mode (Windows Settings > System > Display > Display orientation > Portrait)

Screenshots
Portrait
Landscape

Build:

  • OS: Windows 10 Pro (1903 - 18362.10006)
  • Xpo Music Version: 2.0.1.0

Additional context
Multi-monitor setup with the portrait monitor using the following settings in Windows display:

  • Scale: 100%
  • Advanced option, Fix scaling for apps: Enabled*
  • Display Resolution: Portrait (flipped)

* Disabling this option has no impact

image

Explore using Spotify Playback SDK for premium users

Currently Xpotify lets the PWA handle music playback. Using Spotify Playback SDK might be a good alternative.

Possible advantages are:

  • Maybe more reliable than the PWA on MS Edge
  • The app can be listed as "Xpotify" in Spotify Connect, instead of "Web Player (Microsoft Edge)"

For free users, we can continue using the PWA.

If we ever implement this, we should keep both options available for premium users to choose.

[Bug] Playlist not visible on sidebar

The playlists that are usually present in the sidebar are not visible anymore. Only the top one is visible, and even the playlists on the bottom are usable, they are no longer visible.

The issue is showcased in this video.

Running v.2.0.1.0 on the Pro edition of Xpo Music.

After hibernating, Xpotify does not play music.

After hibernating, the song was "stuck" at 0:00 and would not start playing. Same for pressing play on the "Release Radar" tile.

Fixed by restarting Xpotify. This then also correctly set the song to it's proper start point where it was (1:44).

Might be the case due to: Hibernate PC -> Play song on mobile -> Power up PC -> Sync mismatch.

High CPU usage when leaving application running

Xpotify is using up to 25% of my CPU when I just leave it running without even a song running. If I just start it fresh and stream a song it runs around 3%. I noticed the play button being grayed out as well.
I am on Windows 10 Pro Version 1809 Build 17763.557.

Keyboard shortcuts

The app should support keyboard shortcuts, preferably the same as the official Spotify app.

Songs consistently play twice

Summary
When playing a playlist every song will be played two times before continuing to the next song.

Steps to reproduce

  1. Find a playlist created by Spotify (e.g. a national top 50 chart).
  2. Point your cursor at the playlist
  3. Click the big play button
  4. Keep listening for several songs

Expected behavior
Every song will only be played one

Notes
Some times the app will skip several songs at a time when it has finished a song. E.g. skipping 3 songs.
It should be noted, that this happened during a Discord "listening together"

Option to hide song/artist

There is already an option to hide a song or artist in the windows version. Would be great is it would also be possible through Xpotify.
picture Release Radar(this option is only for discover weekly, Daily mix and release radar):
image

Xpotify(only possible in Daily mix):
image
But on discover and Release I only see the heart

xpotify.ghiasi.net does not resolve

When I try to log in with my Spotify account, everything works until I get this screen saying "NotFound" for the URL to activate Xpotify with Spotify's API.

I copied the URL and went to it, but when it redirects, I get this
image

Seems like something that could block others from signing up in the app.

[Request] Do not limit mini-player size

I LOVE the mini player feature. I have a monitor on the back wall of my office that I use almost exclusively for Spotify full screen. With Xpo I like the look of the mini player better, but I wish I could make it bigger so I could read the text, etc.

Alternatively, make a full-screen player!

Use injected Windows Runtime component for communicating from js to c#

The injected Windows Runtime Component method is explained here.

A Windows Runtime component is already created (for showing progress bar in playback bar), communications that use window hash changes should use this method instead. Also regular pollings from C# side should be abandoned and js should send the necessary info itself to c# in regular intervals instead.

[Feature Request] Use scroll wheel for volume change

Feature Request

When in the official Spotify client when the user mouses over the volume bar and uses the scroll wheel on the mouse it changes the volume. I think this is a great feature and I wanted to hear others thoughts on it if it should be implemented.

volume

Application crashing on start

After the application was renamed to Xpo, I re-installed it through MS store and now it crashes on start. I tried removing all files related to it and re-installing but I'm still getting the same issue.
It loads the splash screen then crashes right after.

[Feature request] Plus/Minus for favourite next to each song in playlist

Spotify shows a little plus/minus next to each song in a playlist if it's a favourite, thus a visual indicator at a glance for every song in the playlist. Clicking on it also toggles this state.
Please duplicate this functionality on Windows Desktop.
EDIT: I've updated this to make it more clearly about the plus/minus next to songs listed in a playlist that allows you to make them a favourite with one click and also see at a glance the favourite state of every song in that playlist.

[Request] Global Hotkeys

Requesting to be able to map global/systemwide hotkeys to Xpotify actions: vol up, vol down, pause, prev/next, current track info, etc.

Excellent app, thanks for develop and sharing it!

Remember View where you have left

When I leave the "Library"-Page where I was on on the "Albums"-View to go to the "Start Page" and Then back to the "Library"-Page, I would like to get back on the "Albums"-View automatically, because it was the last View I visited on the "Library"-Page.

Adding to playlist when song already present

On the Spotify client, whenever you try to add a song to a playlist where it is already there, there is a pop-up confirming if you want to add the duplicate anyways or skip adding it. On Xpo, it adds the song anyways without letting you know if it is already there.

It would be nice to see this Spotify feature mimicked in Xpo.

Split script and css files to multiple files and compile them to one.

initScript.js, initLightTheme.js, style.css and style-light.css files are becoming too big, and ugly to remember all the details and maintain them.

We should split those files into many files, each handling one specific functionality. Then we can either compile them all to one script on each release (on development time), or stitch them together on runtime, maybe.

Note: Remember to explore existing solutions for this type of situation.

"Listening on" client name in Spotify

When I am listening to Xpotify, the regular Spotify client says this:

image

Is it possible to change this to Xpotify or something more representative than "Web Player (Microsoft Edge)?" I am unfamiliar with the Spotify Developer API so I wouldn't know where to start.

Several references to Xpotify throughout project

Since the rename, the only real modification to reflect references to the old name was 5c87789, but even the README update didn't change Xpotify references to Xpo Music other than in the header.

Throughout the file structure as well, there are many things including the primary folder that are named Xpotify. Are you wanting someone to work on changing this, or does it not matter to you? I wouldn't mind attempting the refactor if you consider this an issue. Just not sure what all you had to change as a result of the issue with the project name.

Can't Download Xpo Music

When trying to download Xpo Music I get the error:
0x80072EFD - Check Internet Connection

Quick search said that it might be an IPv6 problem but I have a stable & fast IPv4 and IPv6 connection. I tried test downloading other apps like Netlix, etc. and they downloaded correctly and without errors.

My Windows 10 Version: 1903 (Build 18362.239)

Unable to sign-in

I have obtained the developer ID and secret, however, when I am at the sign-in page, after inputting the correct credential, I get, "Invalid redirect URI" error, same with creating a new account.

Now Playing page

Like the one in Groove.

Also should have the ability to go fullscreen.

Try to extract playback info from the PWA itself

Currently Xpotify gets the playback info from Spotify API, which is not always completely in sync with the local player state, and also results in lots of requests to Spotify API.

We could extract most (all?) playback info periodically from the WebView, and use the API as a backup for when this fails (some change in PWA structure which causes the extract script to fail), or for the information not available in the PWA (in that case we might also be able to reduce the polling interval for API).

Refactor MainPage

There's a lot of functionality in the middle of MainPage.xaml.cs, which should be moved to appropriate classes and helper classes. The xaml structure might need some refactoring too.

Liked song message displays strangely

As shown below, in Xpo, the liked song message is centered in just the right panel and is much longer than the message it contains. The box is also very short and is positioned a good bit above the play bar.

image

In the Spotify client, the message is centered on the window and the box's height and width are much more proportional to the message it contains. It is also positioned much closer to the play bar, maybe even too close.

image

It would be nice if the Xpo version could be turned into a better version of the Spotify message, because right now it isn't very visually appealing. It's worth mentioning that the issue is present with all similar messages, such as adding to a playlist or removing a like, not just liking a song.

Also, when I was getting these screenshots, I noticed that the Spotify UI updated instantly when I liked the song in Xpo, but the Xpo client would not change to reflect whether I liked or removed a like from the song in Spotify. Is it possible to fix this with some listener code for changes made in Spotify?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.