mahilab/mahi-util

Utility classes and common functionality use by the mahi-lib ecosystem

mahi-util's Issues

Fails to build under Ubuntu 20.10

I get the following error:

/home/joey/work/mahi-util/src/Mahi/Util/System.cpp:21:10: fatal error: sys/sysctl.h: No such file or directory
   21 | #include <sys/sysctl.h>
      |          ^~~~~~~~~~~~~~

Simply removing the line, seems to build fine.

get_key_nb() returns 0 for either no input or "Esc" input

If there was no key pressed, get_key_nb() returns 0. But pressing Enter returns the KEY_ESC enum, which is also 0. We could either:

• Change return for get_key_nb() and get_ch_nb() to be -1
• Change the 0 enum to be something like KEY_NO_INPUT so that they result in the same thing

Build issue on MacOS + workaround

Building on MacOS yields:

...
[ 50%] Building CXX object CMakeFiles/gui.dir/src/Mahi/Gui/Native.cpp.o
/Users/mark/dev/mark/sfs/gui/build/_deps/mahi-gui-src/src/Mahi/Gui/Native.cpp:25:10: fatal error: 'filesystem' file not found
#include <filesystem>

I was able to figure out that this relates to the Native dialogs and also the <filesystem> header is not available in my environment. I have been able to work around this (for now) by disabling the native dialogs. Ideally CMake should be finding my <filesystem> headers (I think they're there); I also noticed that it's set to use C++14 but <filesystem> is a C++17 thing (I think).