Rheda: Updating replacement player to nobody not working.

[mahjongpantheon]

Rheda: Updating replacement player to nobody not working.

[ctizen]

Ah! I guess I misunderstood your case then :) OK, I'll take a look soon, thanks!

[ctizen]

I'm not sure how we should handle this particular situation. In tournaments, we disallow adding or removing players after a session is created (== when first seating is generated), because in general removing or replacing a player will break some stateful logic, e.g. it's well known that several achievement pages will be broken in that case.
Though, I guess nothing should be wrong with replacing a player before the first game, but it's gonna require some custom methods to ensure that we're exactly 1) replacing player, 2) before first game. Other cases seem invalid to me.

[ctizen]

If there are any other thoughts about this issue from other team members, please share:)

[Jesterboxboy]

After testing a bit i think it's just a frontend bug,
Selecting "Nobody" in Rheda in eid2/reg in the replacement player field, does not trigger a backend api call to mimir.
I was able to fix it to some degree, so at least after reloading the page, clicking "Nobody" triggers a api call reliably, but not after populating the whole player list in the dropdown. There seems to be some problem with the string concatenation in the _updateReplacementList function in the PlayerRegistration.handlebar template file.
I commited the changes to my fork if you wanna have a look:
Jesterboxboy@9a01da8