mahjongpantheon/pantheon

Primary Pantheon project repository

pantheon's Issues

Check starting timer functionality

https://github.com/MahjongPantheon/pantheon/pull/242/files

Is it still not implemenetd? What about crons, daemons, etc?

Incorrect priority of storage engines

LocalStorage has first priority while cookies have secondary. See

pantheon/Tyr/app/services/idb/index.ts

Line 81 in b667407

this.cookieEngine.set(key, type, valuePrimary);

This leads to some undesirable behavior after password reset:

• User resets password from Rheda
• User tries to log in from Rheda
• User gets to Tyr, but they already have an auth token in localStorage, so the right token in cookie is overwritten by the expired one.

Also check domain of cookies for Tyr and Rheda: the domain should be exactly .riichi.top everywhere (started with dot)

[Forseti] East/South4 displayed as East/South0

As shown in the image, East4 and also South 4 are shown as East0 and South0

[Forseti] Round information update needs page reload in "Manage games" Menu

In the "Manage Games" Menu for a tournament after i.e. a round has finished, the score, round number etc. is not refreshed automatically, and a page reload is required.
At least a refresh button should be there.

Get rid of yellow zone setting

• Remove "Yellow zone duration" setting in Rheda and in DB
• Use "Session duration" setting as an amount of guaranteed time when using yellow zone mode.

[Forseti] Player list in Manage Players not updated

When adding a Player to a tournament in Forseti via "Manage Players".
Only the last added player is shown.
Only after a page reload, is one able to see the whole list of Players

Require name/surname on initial registration stage

Review password recovery flow

• We can't nullify reset token code on first visit, as it doesn't allow sharing links via messengers with auto-previews.
• There's some questionable logic with temporary passwords that is probably to be deleted.
• Maybe use some digit-code to prevent nullifying token with auto-previews

[Forseti] Last Round cannot be chanceled in tournament

After finishing S4 in a tournament(with prescripted seating in test case) the "Chancel last round" button is not visible anymore, even though the "Approve Sessions" Button has no yet been clicked.

[Forseti] Long Timeouts after chancel rounds

The bug was replicated a few times, by using a fresh pull from commit a9b2e23
running
make container
make run
make dev
make seed
make seed_tournament

creating a tournament with EMA Rules and prescripted seating.

After canceling a round in the management page in Forseti, and then Reentering the exact same result once more via Frey, the backend seems to time out as a lot of timeout errors are visible in PHP logs from Rheda, and the whole frontend times out. After a long time(some minutes) and a reauth the system seems to recover, and the error cannot be recreated until the next session.

2023/04/21 12:49:12 [error] 113#113: *1439 upstream timed out (110: Operation timed out) while reading response header from upstream, client: 127.0.0.1, server: , request: "POST /v2/Common.Frey/QuickAuthorize HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "localhost:4004" 127.0.0.1 - - [21/Apr/2023:12:49:12 +0300] "POST /v2/Common.Frey/QuickAuthorize HTTP/1.1" 504 497 "-" "GuzzleHttp/7" "-" 2023/04/21 12:49:13 [error] 113#113: *1441 upstream timed out (110: Operation timed out) while reading response header from upstream, client: 127.0.0.1, server: , request: "POST /v2/Common.Frey/QuickAuthorize HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "localhost:4004" 127.0.0.1 - - [21/Apr/2023:12:49:13 +0300] "POST /v2/Common.Frey/QuickAuthorize HTTP/1.1" 504 497 "-" "GuzzleHttp/7" "-" 2023/04/21 12:49:13 [error] 112#112: *1417 upstream timed out (110: Operation timed out) while reading response header from upstream, client: 127.0.0.1, server: , request: "POST /v2/Common.Frey/GetPersonalInfo HTTP/1.1", upstream:

Rheda: Updating replacement player to nobody not working.

Removing a replacement player via Rheda(on view http://localhost:4002/eid2/reg) does not work.
Field in db is not updated.
Had the problem at the last tournament, because a player showed up in the last minute and i needed to remove the replacement player again, which i then did directly from the event_registered_player table.

Potential fraud in event management

• Any user can create an event and add there any other user
• There should be a way to prevent fraudulent events (advertising, inappropriate naming, etc)

Add rating results export

Either change the results table from <div> to <table>, or add a button for a CSV export (hidden URL?). Any way to properly export the results would be great.

Right now, if you attempt to copy rating results, they will not be copied as a table.

Original:

Copied to the google doc:

Seating list on timer page shows more tables that actual

Steps to reproduce:

• Create tournament
• Add 8 players, exclude 4 of them from the seating
• Make new seating for next session
• Open timer page
• Actual result: There's two rows with duplicated players
• Expected result: Only one table is shown, excluded players don't show in ratings table.

Check behavior when excluding one or two players, but not the whole table.

Кнопка со ссылкой на статистику из запущенной игры

При отсутствии фамилии, в мобильном интерфейсе отображается точка через пробел после имени

Код, ответственный за это:

pantheon/Rheda/src/controllers/RatingTable.php

Lines 143 to 147 in dacd54e

	private function _makeShortName($name)
	{
	list($surname, $name) = explode(' ', $name . ' '); // Trailing slash will suppress errors with names without any space
	return $surname . ' ' . mb_substr($name, 0, 1, 'utf8') . '.';
	}

Предлагаю, если в $name нет пробелов, возвращать просто $name, не пытаясь ничего с ним делать.

Includes text/plain type into sent emails

This will gain +0.1 points from spam-assassin.

Also maybe we should remove html mails and keep plain text only, as we don't send any media content.

Use self-hosted analytics instead of YM

Unbind from non-required externals.
Example: plausible.io

Add "Show on main page" checkbox to event add/modify form

Now all events are hidden by default and could be shown by pressing a button in "My events" page. This should be controlled also by some checkbox in event add/modify page.

Chips are wrongly assigned to tournaments after ruleset migration

See database, eid193 and less. chipsValue should not exist in ruleset_config there.

"End game" button to force session finish

Use case:

• Players use some external timer during club games, and after the time is expired they would like to end the game without adding bogus noten hands.

Suggestion:

• Add a "Force finish" button (or checkbox) either in admin panel or in mobile assistant. Having the checkbox checked will finish the game right after last hand is recorded.

[Error log] Timer page of finished event

The page at URL https://rating.riichimahjong.org/eid132/timer produces next log item:

[31-Mar-2023 19:19:56 UTC] PHP Warning:  Undefined array key "title" in /Mimir/src/TwirpServer.php on line 1619

We need to disable timer page and link for finished events. Also check if this error happens when some users are dropped from event or are excluded from the seating.

Более независимая i18n

Сейчас, английский перевод несёт на себе ещё и функцию placeholder'ов, что приводит к тому, что при изменении английского текста, менять одно и то же нужно в двух местах. Может быть стоит сделать placeholder'ы языконезависимыми?

Review timer/end of game code

Check if games end properly when time is out.
See eid170,171 for presumably problematic ruleset configuration.

Wrong game timestamps

например вот эта игра https://rating.riichimahjong.org/eid146/game/beec8b068bbda3732d4daf3f9088bdd3c8b9b333 имеет правильный таймстамп

а эта https://rating.riichimahjong.org/eid146/game/660436f0b486a07dd04bfb854d85552747ef6902 на самом деле закончилась на 2 часа раньше, в 21:22

если зайти в профиль любого игрока и кликать на точки на графике рейтинга, то там игры в правильном порядке, и как раз сбитое время можно будет обнаружить

Seating generation issue in tournament management

When attempting to generate new seating on the Games Management page, by clicking the designated button, the status changes to "Seating..." but then, after a few seconds, returns to "Not Started" without any seating being created.

Additionally, if manual seating arrangements are specified for the same tournament, the status remains stuck on "Seating..." indefinitely.

Affected tournament: https://manage.riichimahjong.org/event/184/games

Проверка системного имени не соответствует сообщению

Сообщение

pantheon/Rheda/src/controllers/PlayerEnrollment.php

Line 90 in ae9e8eb

$errorMsg = _t("System name should contain only lowercase latin characters.");

некорректно: на самом деле допускаются и цифры. Что стоит изменить: проверку или сообщение?

Add pagination to tournaments admin list

A separate page with ruleset overview

There should be a separate page with full ruleset overview accessible for everyone. Now only administrators see the ruleset overview.

Error after last round in prescript tournament

After finishing the last round of a tournament with preseating, the tournament control page throws an error:
Something went wrong: Response: HTTP/1.1 500 Internal Server Error

PHP Error:
[28-Mar-2023 07:34:07 UTC] PHP Warning: Undefined array key 8 in /var/www/html/pantheon-prod/Mimir/src/primitives/EventPrescript.php on line 262 [28-Mar-2023 07:34:07 UTC] PHP Fatal error: Uncaught TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /var/www/html/pantheon-prod/Mimir/src/helpers/Seating.php:624
It does not really pose a problem, as the round is calculated properly.
Bug can be mitigated by adding a "dummy" round in the prescripting.

Solution:
tournament control page should display something along the lines of "no more prescripted rounds available" or similar, but should still allow hiding and showing rating table(newer version have this toggle in the tournament overview as well).

Pantheon version used when discovering bug hast the following commit as head:
1221ea0

Не запускается на чистой Ubuntu 16.04

Как повторить:

• Установить Ubuntu 16.04 на виртуальной машине
• sudo apt install docker.io git
• git clone https://github.com/MahjongPantheon/pantheon.git
• cd pantheon
• sudo make container
• sudo make run

Как проявляется:
На 4001 и 4002 портах пустая страница, 4003 недоступен.

Ошибки:

• bin/phinx не найден при sudo make seed
• nodejs пропустил опциональную зависимость [email protected], т.к. ожидал архитектуру darwin, а получил linux

Логи:

• docker.log - вывод sudo make logs
• full_bash.log - полный вывод терминала от начала до конца. Примечание: cyclopentan/pantheon это полная копия MahjongPantheon/pantheon, был склонирован 13 августа 2018г. и не изменялся (коммит HEAD = 014e74a).
• npm.log - 24-ый шаг сборки docker, проблема с fsevents

Improve Rheda graphs

• Half of titles are hidden if there's too many yaku
• Count numbers are messed up

Maybe replace with some other histogram drawer?

Events: separate "hidden" flag from "closed" flag

Authentication in Frey not working for Forseti

Behavior was tested with docker dev environment.
When logging in via Frey, the authentication works for rheda but not for Forseti.
Vice versa, when logging in via Forseti, Frey is also authenticated.
Rheda accepts the auth in both cases.

Auth cookie looks the same in both instances

Check if captcha is required with new admin panel

• Automated registrations don't seem to be a problem at the moment
• Probably basic CSRF protection would be enough for now.

Predefined seating: missing "Delete player" button

See https://r.riichi.top/eid154
With predefined seating, players list does not include the delete button. Check if this is required and provide either bugfix or instructions for administrators for this case.

Fix condition of the hanchan end

Hanchan should end after the 4th South if one player has at least 30000 points. Current minimum value is 30100

Bug Report: Player name in Tyr not loaded correctly

After logging in in Tyr , the Player Name is not loaded correctly, and just "Player Name" is displayed.
After reloading the Page, the Name is then loaded correctly.

New roles for event management

• Owner role: equivalent to administrator, but can't be revoked by anyone. Owner role can be transferred explicitly to another user (with confirmation).
• Manager role: can only add new players to the event and cancel hands or games when possible. Manager can't remove players from event, assign other managers or administrators or change event settings.
• Consider adding non-playing administrators (now one can add player, make them an administrator, then remove, but it's a workaround)

Если за ханчан не собрано ни одной руки, отображается placeholder bestHandPlayers

https://gui.mjtop.net/eid70/game/d290b5ee8a0108d1ee03a6189bd22cf08aea7366

Предлагаю вместо этого писать "N/A"

[Prod] Add redirects from old admin panel to new one

Tournament stuck on seating stage in certain conditions

• Make a tournament event with prescripted seating
• Add 8 players to the tournament
• Make a prescripted seating stating that only 4 of 8 players are playing with each other in every game. Example:

7-2-1-8

4-2-6-3

2-4-3-8

1-7-8-6

7-6-3-8

1-2-4-6

1-7-4-3

2-7-6-8

2-7-4-6

1-4-3-8

1-2-6-3

7-4-3-8

1-4-6-8

2-7-1-3

• Try to start the tournament
• Expected behavior: seating is prepared, there is a start button. Actual behavior: UI is stuck on "preparing seating" stage.

This happens due to hardcoded condition in Rheda: https://github.com/MahjongPantheon/pantheon/blob/master/Rheda/src/controllers/TournamentControlPanel.php#L226
Looks like this logic is incorrect, and we should rely on the total number of players participating in certain hanchan.

Password recovery issues

1. Check if password is properly updated after recovery.
2. Ensure all cookies are properly cleared after attempt of unsuccessful login
3. Auth reset token is not cleared after it's used - this is not correct.

Enhancement Autoconfigure mail in docker-compose production

It would be very comfortable if the functionality to send recovery and signup mails via smarthost would work out of the box with docker compose.

Tested Steps to make it work:

• Add Environment Variables to env file for Docker Compose

   FROM_MAIL=Pantheon<[email protected]>`
   SMTP_HOST=mail.domain.test:587
   [email protected]
   SMTP_PASS=password
   SMTP_TLS=YES
   SMTP_STARTTLS=YES

• apk add ssmtp in Frey container

• Add configuration for ssmtp to /etc/ssmtp/ssmtp.conf filled with env variables

  # cat /etc/ssmtp/ssmtp.conf 
  # Config file for sSMTP sendmail 
  #
  # The person who gets all mail for userids < 1000
  # Make this empty to disable rewriting.
  root=

  # The place where the mail goes. The actual machine name is required no
  # MX records are consulted. Commonly mailhosts are named mail.domain.com
  mailhub=SMTP_HOST

  # Where will the mail seem to come from?
  rewriteDomain=

  # The full hostname
  hostname=pantheon

  # Are users allowed to set their own From: address?
  # YES - Allow the user to specify their own From: address
  # NO - Use the system generated From: address
  FromLineOverride=YES

  AuthUser=SMTP_USER
  AuthPass=SMTP_PASS
  UseTLS=SMTP_TLS
  UseSTARTTLS=SMTP_STARTTLS

• Add FROM Header i.e. in send function in Mailer class in Frey/src/helper/Mailer.php
  protected function _send(string $to, string $subject, string $message, array

     $additionalHeaders, string $additionalParams)
    {
        $boundary = md5(uniqid() . microtime());
        $additionalHeaders['Content-Type'] = 'multipart/alternative; boundary="' . $boundary .      '"';
        $additionalHeaders['From'] = SMTP_FROM;

Refine yaku list

• Remove yakuhai 5 everywhere. Do not change other yaku ids!
• Ensure yakuhai 4 is accessible in assistant.

[Forseti] Editing Player profile by admin no longer possible

The functionality to edit a players profile that was available in rheda under
http://localhost:4002/profile/edit/xx has been removed, but the function has not yet been added to Forseti.

User-defined presets of rules

Now we have 4 predefined rulesets with the ability to change details when making a new event. Usually club ratings are based on previous season rules, so there could be some improvements in the process:

• Add ability to use any existing events rules as a base
  or
• Add some user-defined presets of rules so they could be shared. The presets could be either private or public (in this case we need some kind of moderation to avoid chaos).

[Forseti improvement] Add view "Registered Tournaments"

Adding a view for a player to see for which events they are enrolled in would be helpful.
Maybe adding "Enrolled/Registered Events" or something like that in Forset, with the option to click an enrolled event and be redirected to rating table in rheda.

"riichi won" and "riichi in yaku stats" are not equal

wins with riichi: 71
riichi bets won: 71
riichi in yaku stats: 70

https://rating.riichimahjong.org/eid146/user/187

71 / 71 / 70

"Deal-ins because of riichi" are calculated incorrectly in case of deal-in to a double ron being under riichi

Статистика набросов:

Набросов в рон | 65   (10.52%)

• из-за риичи | 13   (20%) <--- looks like 14 is the correct value
• не из-за риичи | 51   (78.46%)
• в открытые руки | 27   (41.54%)
• в риичи | 16   (24.62%)
• в даматен | 8   (12.31%)