mainmatter/compare-fixture

compare-fixture's Issues

Running command not working

Things I've tried

Running with npx

npx compare-fixture pkg-pika pkg

Output: (Node v16.20.0 or Node v14.21.3)

npx: installed 12 in 1.304s
/Users/XXX/.npm/_npx/34130/bin/compare-fixture: line 1: import: command not found
/Users/XXX/.npm/_npx/34130/bin/compare-fixture: line 3: const: command not found
/Users/XXX/.npm/_npx/34130/bin/compare-fixture: line 4: const: command not found
/Users/XXX/.npm/_npx/34130/bin/compare-fixture: line 6: try{: command not found
/Users/XXX/.npm/_npx/34130/bin/compare-fixture: line 7: syntax error near unexpected token `fixtureDir,'
/Users/XXX/.npm/_npx/34130/bin/compare-fixture: line 7: `  compareFixture(fixtureDir, comparisonDir);'

Output: (Node v18.15.0)

npx: installed 12 in 2.79s
Command failed: compare-fixture spawn Unknown system error -8

Cloning the project and running it

node cli.js ../octokit/webhooks.js/pkg-pika ../octokit/webhooks.js/pkg

Output:

internal/process/esm_loader.js:74
    internalBinding('errors').triggerUncaughtException(
                              ^

Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import '/Users/XXX/dev/open_source/compare-fixture/' is not supported resolving ES modules imported from /Users/XXX/dev/open_source/compare-fixture/cli.js
Did you mean to import ../index.js?
    at new NodeError (internal/errors.js:322:7)
    at finalizeResolution (internal/modules/esm/resolve.js:314:17)
    at moduleResolve (internal/modules/esm/resolve.js:776:10)
    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:887:11)
    at Loader.resolve (internal/modules/esm/loader.js:89:40)
    at Loader.getModuleJob (internal/modules/esm/loader.js:242:28)
    at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:76:40)
    at link (internal/modules/esm/module_job.js:75:36) {
  code: 'ERR_UNSUPPORTED_DIR_IMPORT',
  url: 'file:///Users/XXX/dev/open_source/compare-fixture/'
}

---

Possible solution:

Doing this change fixes the issue for me:

- import compareFixture from ".";
+ import compareFixture from "./index.js";

I'm happy to help on this and am open to submitting a PR.

When a file is present in one of the folders but not present on the other, it triggers an Error

Example:
types.js is present in one folder but not on the other.

ls ../octokit/webhooks.js/pkg-pika/dist-src ../octokit/webhooks.js/pkg/dist-src --no-user

Error Output

Error: ENOENT: no such file or directory, open '../octokit/webhooks.js/pkg/dist-src/middleware/node/types.js'
    at Object.openSync (node:fs:590:3)
    at readFileSync (node:fs:458:35)
    at file:///Users/XXX/dev/open_source/compare-fixture/index.js:21:25
    at Array.forEach (<anonymous>)
    at compareFixture (file:///Users/XXX/dev/open_source/compare-fixture/index.js:20:16)
    at file:///Users/XXXX/dev/open_source/compare-fixture/cli.js:7:3
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async loadESM (node:internal/process/esm_loader:91:5) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: '../octokit/webhooks.js/pkg/dist-src/middleware/node/types.js'
}