mainmatter/ember-api-actions

Ember.js addon allowing you to easily implement non-CRUD actions for your Ember Data models

ember-api-actions's Issues

Requested URL is always an absolute URL

In #151, a change was made that adds the current origin to the baseUrl. Although this works fine in most cases, or as the PR says "unlikely to be an issue in practice", it does affect our tests. Let me briefly explain this first.

Our acceptance tests work with PollyJS, which stores the API responses in recording files. To make those requests in the recordings API-agnostic (to allow recording tests with different backends), we set up our API host as '' and use a proxy server to intercept those requests and do the requests to the backend that is currently configured. The way the tests then look up the requests in those recording files, is based on the url, headers, etc. Since this addon turns a url like /v1/users into for example http://localhost:4200/v1/users, this lookup fails. Re-recording the tests is not a solution though, as CI uses a different host and then the lookup would fail there.

I think that the location.href addition was done because new URL(baseUrl) fails with a baseUrl of e.g. /v1/users. However, since this is indeed a breaking change (for us at least), I think it's safer to do something like

return baseUrl.startsWith(url.origin) ? url.href : url.href.replace(url.origin, '');

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• Lock file maintenance

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update actions/checkout action to v4
• Update actions/setup-node action to v4
• Update dependency @embroider/test-setup to v4
• Update dependency @release-it-plugins/lerna-changelog to v7
• Update dependency ember-cli-babel to v8
• Update dependency ember-page-title to v8
• Update dependency ember-resolver to v11
• Update dependency ember-try to v3
• Update dependency msw to v2
• Update dependency pnpm to v9
• Update dependency release-it to v17
• Update pnpm/action-setup action to v4
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/ci.yml

• actions/checkout v3.6.0
• pnpm/action-setup v2.4.0
• actions/setup-node v3.8.2
• actions/checkout v3.6.0
• pnpm/action-setup v2.4.0
• actions/setup-node v3.8.2
• actions/checkout v3.6.0
• pnpm/action-setup v2.4.0
• actions/setup-node v3.8.2

.github/workflows/release.yml

• actions/checkout v3.6.0
• actions/setup-node v3.8.2

npm

package.json

• ember-cli-babel ^7.26.11
• @ember/optional-features 2.1.0
• @ember/string 3.1.1
• @ember/test-helpers 3.3.0
• @embroider/test-setup 3.0.3
• @glimmer/component 1.1.2
• @glimmer/tracking 1.1.2
• @release-it-plugins/lerna-changelog 5.0.0
• @babel/eslint-parser 7.24.6
• broccoli-asset-rev 3.0.0
• concurrently 8.2.2
• ember-auto-import 2.7.3
• ember-cli 5.8.1
• ember-cli-dependency-checker 3.3.2
• ember-cli-inject-live-reload 2.1.0
• ember-cli-sri 2.1.1
• ember-cli-terser 4.0.2
• ember-data 5.3.3
• ember-disable-prototype-extensions 1.1.3
• ember-cli-htmlbars 6.3.0
• ember-load-initializers 2.1.2
• ember-page-title 7.0.0
• ember-qunit 8.0.2
• ember-resolver 10.1.1
• ember-source 5.8.0
• ember-template-lint 6.0.0
• ember-try 2.0.0
• eslint 9.3.0
• eslint-config-prettier 9.1.0
• eslint-plugin-ember 12.1.1
• eslint-plugin-n 17.7.0
• eslint-plugin-prettier 5.1.3
• eslint-plugin-qunit 8.1.1
• loader.js 4.7.0
• msw 1.3.3
• prettier 3.2.5
• qunit 2.21.0
• qunit-dom 3.1.2
• release-it 15.11.0
• webpack 5.91.0
• node 16.* || >= 18

regex

.github/workflows/ci.yml

• pnpm 8.15.8

---

• Check this box to trigger a request for Renovate to run again on this repository