maksymt17/aquamarine

Object recognition tool

aquamarine's Issues

Add Object class

add Object class with possibility to check around if this object connected to other one

Remove virtual destrcutor in common Matrix class declaration

Remove virtual destructor for Matrix class

To Reproduce
Steps to reproduce the behavior:

1. Go to Matrix class definition checkout declaration of special member functions

Additional context
Such virtual destruction make a negative impact on execution time,

1. no needs certain case to define virtual destructor
2. virtual makes additional vtable for that frequently used class

Add new logger

Logger needs to be added to make it possible slightly debug program execution.
Variadiac arguments have to be used, logs should be parametrized.

Add Configuration

parameters:
AffinityThreshold
MinPixelsForObject
PixelStep;
CalculationTimeLimit
IdleTimeout

Add time limitation for algorithms

Add time limitation for algorithms:
No needs to proceed calculations if result can not be provided in time.

If time exceeded - user should be notified about possible noise in images - comparison results can be distorted.

Resolution:
change input parameters: affinity threshold and min count of pixels in object,
or provide other image with reduced 'noise'.

Add interface for movements detection

should provide results of movement for every potential object
search of movement should be done only for objects not whole image
optionally can be added check for checking whole image

Add threads multiplier to config file

Threads count has to be added in config file, to make possibility adjust speed of processing images

Describe the solution you'd like
In case of HW specific such threads multiplier can significantly improve overall results of processing.
In meantime wrong multiplier can also provide loss of objects, especially with conjunction of small Calculation_Time_Limit value.

Describe alternatives you've considered
Add parameter to config file, set value as default to 2.0

Additional context
Explanation can be added on aquamarine wiki page

Calculate pixels count in Object

add pixelsCount in object class, and calculate summ of merged objects when merge needed

Add ordering of collected objects

During searching objects keep some order - Ascending/Descending type.
Will be used during handling results. If user interested in biggest objects - they will be collected in needed order: biggest -first, smallest - last.

[Technical]:
std::set can be used where comparator will be selected, based on 'value'-weight of objects.

[Purpose]:
User can get results of more interested objects(usually - bigger)

[Warning]:
Can be timecostly if a lot of objects found.

[Flexibility]
Can be configurable: up to user requirements. When user can define if ordereing important, if not - can be used simple vector of objects as it was before

Prepare wiki page with usage and main parameters

Explanation of used and required parameters have to be added

Add optimisation in percent difference check in ThresholdChecker class

Add Unit Test for BmpExtractor class

add simple ImageDrawer

Is your feature request related to a problem? Please describe.
Create Bmp image drawer

Describe the solution you'd like
Can be used existing bmp_reader from third_party

Describe alternatives you've considered
as option different libraries will be nice, especially with direct access from taken picture, closer to driver for faster extraction

Additional context
drawRect should exisist to make vision to user where object/movement detected

Add proper namespace usage

check all classes about namespace,
replace 'recognition' to 'am'

Fix UT for new approach with selecting rows to calculations

UTs are failing because of selection Row instead of a column,
UT doesn't updated regarding Row segment selection per thread

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

add configuration reading from file

AM-51 Add UT for DataBaseCommunicator

Add UT and cover functionality related to the storage of RESULTS in the database.

Add object detector class

Interface added,
Needed implementation of searching objects regarding to ChannelDiffs matrix

Extend Object Detector intarface with ImagePair usage

add new method in interface and implement it

[AM-43] Add UT coverage report generation

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Make the possibility to generate a report about how UTs are covered sources

Add usage of Rects as area of object

replace vector of Pixels found to bounding Rect for object, to simplify and reduce memory usage.

POC prepare tool usage for RAW file convertion to RGB bytes

can be used some external tool or script
or c++ code with extraction

requirements:
fast convertion, JPEG data extraction.

optionally:
will be a plus to use low level access to memory,
maybe manufacturers can provide some SDK, for extraction pixels data from internal photo camera picture buffer

opened external discussion:
stackoverflow question

replace bit shiftings wit bitset

remove oldschool bit shifts, and use std::bitset<> instead.
Make code more readable and use modern types defined already in standard.

Add UT

Needed set of Unit Tests which will check expected results after comparison/reading/searching

ThresholdDiffChecker crash occurs with some threads count

Check how ThresholdDiffChecker::getThresholdDiff works with different numbers of threads,
Priority is low for that moment as this class doesn't impact Object/Movement detection

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

add FHD, 20x20, 10x10 image samples

add FHD, 20x20, 10x10 image samples to make possible run tests with different resolutions and objects to search.

Specify std::async flag for faster execution

Type of optimization:
Analyze
add multithread with flag ::launch for immediately execution on available threads

Description:
modify all async calls flag

Add common runtime storage for storing basic precalculated data

Create UT base class

with supporting basic support of prvided statements:

EQUAL
EXPECT_TRUE/FALSE
EXPECT_THROW

simplified alternative of gtest

Bug with last thread collecting objects

Describe the bug
Fix problem with missed results from last thread

To Reproduce
Steps to reproduce the behavior:

1. use multhithreaded CPU
2. launch aquamarine comparison , where object will be in very right side of image
3. Check results(debuggin or output bitmap with BitmapDrawer)

Expected behavior
last thread executed objects collected, but not added in final list.

Multithreading in Bmp image data extraction

Multithreading in Bmp image data extraction, have to be implemented to speed-up execution of current functionality.
Currently Extraction data from QHD image takes more then second, its inappropriate.
Multithreading + optimisations have to be added.

add multithreading in searching objects on diffs

add multithreading to speed-up searching of objects, with possibility to merge different objects from threads to bigger one, if these connected

fix bug with Object detection logic

unexpected exception throws

steps:
issue occurs if used only 1 thread

add Service interface

Refactoring of ObjectDetector class

clean up and refactoring of Implementation

simplify code and optimize

Add singleton class Context

Add singleton class Context for storage basic info available all time during comparisons.

Add ThreadPool suppport

Type of optimization:
[Extraction/Analyze/Build&Compile/Cross-platform]

Description:
Add ThreadPool with conditional variables

replace push_back`s to avoid unnecessary copies

Type of optimization:
[Analyze]

Description:
check search/extraction functionality for possible optimizations where an object can be constructed in place.

Add linux scripts for build

Movement detector class implementation

MovementDetector shall check whether Objects moved on pair of images provided.
User should set objects which he interested in then check of movement can be started.
After checking what changes with should be provided possibility to recieve updated list of objects.

Add golang source code to run prebuild aquamarine binary

Implement launch of aquamarine binary with python.
Add image samples and default config to make it possible to run the test in a dedicated folder.

fix wrong merging of objects between threads results

fix wrong merging of objects between threads results

To Reproduce
Steps to reproduce the behavior:

1. Compare image with movable objects (rs_1 rs_2)
2. Use multhithreading with 8 or more threads

Expected behavior
Merge objects if there are connected

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
Linux/ Windows OS

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[AM-49] Use recatngles instead of of vector of pixels for determining the object

Replace the current implementation with ObjectRectangle class instead of Object.
Should improve performance and not impact results. The result of the comparison is a rectangle(s).

Divide source files respectively.

Change image segments from columns to rows

Type of optimization:
Analyze
[Extraction/Analyze/Build&Compile/Cross-platform]

Description:
Modify existing implementation for multithreaded calculations and improve CPU cache utilization.
An update of the aquamarine wiki page is also required.

replace std::vector for matrix to 2d vector

Type of optimization:
Extraction:
replace std::vector<> inside of matrix to vector<vector>

Description:
as Matrix is representation of image and related pixels, better to use 2 matrix instead of current vector.
Why:
Avoid unnecessary row index calculation all time due access to matrix values

Exception due calculation on rs_1 rs_2 image-samples [Windows]

Exception thrown
"std::vector out of range"

To Reproduce
Steps to reproduce the behavior:

1. compare rs_1 and rs_2 bmp images
2. Windows compiler required(issues visible under VIsualStudio)
3. Config MinPixels: 5, step: 2, Calculation_Time_Limit: 500
4. See error

Expected behavior
Calculation has to be finished without exception

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• Windows OS

Additional context
index is going out of thread column limits

fix CMake settings for includes

relative paths usage(such as "../common/Types,hpp") in includes have to be changed.

[AM-42]Replace TestBase with gtest in UT

Type of optimization:
[Extraction/Analyze/Build&Compile/Cross-platform]

Description:
Add linkage of gtest in all tests
Modify UTs sources

AM-50 Add database storage for all results

While Aquamarine has been making comparisons results could be saved into the database file.
Then after multiple runs, all results could be checked apart from logging.

SQLite3 could be used as a database.

Devide Types.hpp to multiple files

Have to be added new files with types definitions, not uses only one as it now.
Content of Types.hpp -> put to multiple files.