Project has been based refactored based on the on the SOLID principles.
- Separate Controllers for Product and ProductOptions
- Create based model class. e.g.
class BaseEntity { // common fields e.g. ID, DateCreated, DateUpdated }
and extend Product and ProductOptions classes from this BaseEntity.
-
add ProductManager and ProductOptionsManager services classes into depedency injection in startup class.
-
Inject the service classes into controller constructor to get access to use service methods.
On top, Swagger has been added to test API easily. Run the project, use this following URL: http://https://localhost:44335/swagger
The attached project is a poorly written products API in C#.
Please evaluate and refactor areas where you think can be improved.
Consider all aspects of good software engineering and show us how you'll make it #beautiful and make it a production ready code.
There should be these endpoints:
GET /products
- gets all products.GET /products?name={name}
- finds all products matching the specified name.GET /products/{id}
- gets the project that matches the specified ID - ID is a GUID.POST /products
- creates a new product.PUT /products/{id}
- updates a product.DELETE /products/{id}
- deletes a product and its options.GET /products/{id}/options
- finds all options for a specified product.GET /products/{id}/options/{optionId}
- finds the specified product option for the specified product.POST /products/{id}/options
- adds a new product option to the specified product.PUT /products/{id}/options/{optionId}
- updates the specified product option.DELETE /products/{id}/options/{optionId}
- deletes the specified product option.
All models are specified in the /Models
folder, but should conform to:
Product:
{
"Id": "01234567-89ab-cdef-0123-456789abcdef",
"Name": "Product name",
"Description": "Product description",
"Price": 123.45,
"DeliveryPrice": 12.34
}
Products:
{
"Items": [
{
// product
},
{
// product
}
]
}
Product Option:
{
"Id": "01234567-89ab-cdef-0123-456789abcdef",
"Name": "Product name",
"Description": "Product description"
}
Product Options:
{
"Items": [
{
// product option
},
{
// product option
}
]
}