malomohq/accent

Dynamically convert the case of your JSON API keys

accent's Issues

camelCase and PascalCase

Why is it that using Accent.Transformer.PascalCase converts the first letter of key to small and Accent.Transformer.CamelCase with capital? It should be the other way around I think.

snake case adding extra _

There is an extra underscore added which is unexpected.

iex(1)> Accent.Case.Snake.call("address2")      
"address_2"
iex(2)> Accent.Case.Snake.call("address_2")
"address__2"

I believe there should be a check around this line https://github.com/malomohq/accent/blob/master/lib/accent/case/snake.ex#L28

Transforming GET requests without content-type

Hi

Why are we only performing conversion for requests with content-type? Often times GET request does not contain a content-type header, but in these cases, I'd still like to convert response payload to different casing.

https://github.com/sticksnleaves/accent/blob/945659b826b0d1df4d28eb5c6c4d8178f3418704/lib/accent/plugs/response.ex#L86

Ways to ignore or support Plug.upload on request

There seems to be an issue with Plug.upload.

Following the guide on file upload, shows error

This is whats on my router.ex

  pipeline :api do
    plug :accepts, ["json"]

    plug Plug.Parsers,
      parsers: [:urlencoded, :json],
      pass: ["*/*"],
      json_decoder: Jason

    plug Accent.Plug.Request # Removing this line will fix the issue
    
    plug Accent.Plug.Response,
      default_case: Accent.Case.Camel,
      header: "x-accent",
      supported_cases: %{"pascal" => Accent.Case.Pascal},
      json_codec: Jason
  end

Add default response case transformation

Hi

It would be nice to allow setting a default casing for response payloads, even without the client setting the accent header.

In my situation I'd like to always send all responses as camelcase

get_resp_header in before_send_callback instead of get_req_header?

Just wondering, responses.ex on before_send_callback

https://github.com/sticksnleaves/accent/blob/9f5011677827d98e2cedf976f4120132b719004c/lib/accent/plugs/response.ex#L71

Should this be a

get_req_header("content-type")

As on the do_call? uses get_req_header("content-type") on https://github.com/sticksnleaves/accent/blob/9f5011677827d98e2cedf976f4120132b719004c/lib/accent/plugs/response.ex#L99

I've tried to change it and all the tests are passing.

Should apply Accent.Plug.Response without specifying Content-Type: application/json

Would it be possible to apply the Accent.Plug.Response without having a request with Content-Type: application/json header.

For file upload uses cases, the request header has Content-Type: multipart/form-data, I should expect the result be transform into json in camel case.

A configuration would look like this:

pipeline :uploads do
  plug Accent.Plug.Response,
    default_case: Accent.Case.Camel,
    json_codec: Jason
end

scope "/uploads", StackedWeb do
  pipe_through :uploads

  resources "/files", FileController, only: [:create, :show]
end

I've been using propercase, and it does handle this kind of use case.