manasouza/contactnumbersearch

Android project to search contacts by phone number

contactnumbersearch's Issues

Still not showing menu item after EditText gain focus

Possible solutions where in the listeners (MenuItem / EditText focus) implementation

Deploy

Prepare the deployment to fix some past crashes and update according current code base

There's a walkthrough in Dropbox

Refactoring code

• Eliminate duplication (load/update contact list)
• Arrange classes according to Android architecture. Currently all code is at one Activity

Sort contacts by name

Implement the sort by contact name

Some contacts are not sorted accordingly

Contact names that start with "É" and lowercase names as "elder" are located at the end of the list

Contacts are missing when text search is empty

Doing backward search until erase all numbers should show all available contacts

[crash] Caused by: android.database.CursorWindowAllocationException:

Related to #30

Affected: Xiaomi Redmi 5 Plus (vince), Android 8.1

Report 1 of 2
java.lang.RuntimeException: 
 
  at android.os.AsyncTask$3.done (AsyncTask.java:353)
 
  at java.util.concurrent.FutureTask.finishCompletion (FutureTask.java:383)
 
  at java.util.concurrent.FutureTask.setException (FutureTask.java:252)
 
  at java.util.concurrent.FutureTask.run (FutureTask.java:271)
 
  at android.os.AsyncTask$SerialExecutor$1.run (AsyncTask.java:245)
 
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1162)
 
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:636)
 
  at java.lang.Thread.run (Thread.java:764)
Caused by: android.database.CursorWindowAllocationException: 
 
  at android.database.CursorWindow.<init> (CursorWindow.java:137)
 
  at android.database.CursorWindow.<init> (Unknown Source)
 
  at android.database.CursorWindow$1.createFromParcel (CursorWindow.java:685)
 
  at android.database.CursorWindow$1.createFromParcel (CursorWindow.java:684)
 
  at android.database.BulkCursorDescriptor.readFromParcel (BulkCursorDescriptor.java:75)
 
  at android.database.BulkCursorDescriptor$1.createFromParcel (BulkCursorDescriptor.java:34)
 
  at android.database.BulkCursorDescriptor$1.createFromParcel (BulkCursorDescriptor.java:31)
 
  at android.content.ContentProviderProxy.query (ContentProviderNative.java:421)
 
  at android.content.ContentResolver.query (ContentResolver.java:756)
 
  at android.content.ContentResolver.query (ContentResolver.java:705)
 
  at android.content.ContentResolver.query (ContentResolver.java:663)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.getPhoneContactList (NumberSearchActivity.java:239)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:128)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:119)
 
  at android.os.AsyncTask$2.call (AsyncTask.java:333)
 
  at java.util.concurrent.FutureTask.run (FutureTask.java:266)

Substitute optionsMenu

As the optionsMenu is deprecated, implement the upper right option selection

Contact added/excluded does not update list

Deploy

Slownees during forward/backward search on Moto G5

Investigate with Dev monitoring tools

java.lang.NullPointerException: at br.com.mls.contactnumbersearch.NumberSearchActivity.getSpecificContactListLength

java.lang.NullPointerException: 
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.getSpecificContactListLength (NumberSearchActivity.java:262)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.access$200 (NumberSearchActivity.java:35)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$1.onKey (NumberSearchActivity.java:77)
 
  at android.view.View.dispatchKeyEvent (View.java:9891)
 

The line of code in respect to that error was removed and the logic replaced

[analytics] Collect installation statistics

What devices uninstalled the app and count by device

How long the app staid installed

Search must show contacts considering other chars

Chars like (,),-, etc. does not allow search to be continuous. This chars must be excluded during search.

Remembering that search field allows only numbers

Use Gradle/Maven (or convert to Android Studio)

Release:
https://developer.android.com/studio/build/building-cmdline.html

Refreshing not according SharedPrefs

Every time entering in the App the contacts are being refreshed

Previous behavior used to refresh with SharedPrefs which is way faster

java.lang.NullPointerException br.com.mls.contactnumbersearch.NumberSearchActivity.getSpecificContactListLength

Mi 5
2816 MB
Qualcomm MSM8996
1080x1920

java.lang.NullPointerException: 
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.getSpecificContactListLength (NumberSearchActivity.java:262)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.access$200 (NumberSearchActivity.java:35)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$1.onKey (NumberSearchActivity.java:77)
 
  at android.view.View.dispatchKeyEvent (View.java:9887)
 
  at android.view.ViewGroup.dispatchKeyEvent (ViewGroup.java:1667)
 
  at android.view.ViewGroup.dispatchKeyEvent (ViewGroup.java:1667)
 
  at android.view.ViewGroup.dispatchKeyEvent (ViewGroup.java:1667)
 
  at android.view.ViewGroup.dispatchKeyEvent (ViewGroup.java:1667)
 
  at com.android.internal.policy.DecorView.superDispatchKeyEvent (DecorView.java:406)
 
  at com.android.internal.policy.PhoneWindow.superDispatchKeyEvent (PhoneWindow.java:1800)

Dig for application icon

java.lang.NullPointerException: at br.com.mls.contactnumbersearch.NumberSearchActivity$NumberSearchTextWatcher.onTextChanged

Android 7
Huawei
Mate 10 lite
3840 MB
HiSilicon KIRIN659
1080x2160

java.lang.NullPointerException: 
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$NumberSearchTextWatcher.onTextChanged (NumberSearchActivity.java:301)
 
  at android.widget.TextView.sendOnTextChanged (TextView.java:8510)
 
  at android.widget.TextView.handleTextChanged (TextView.java:8572)
 
  at android.widget.TextView$ChangeWatcher.onTextChanged (TextView.java:10784)
 
  at android.text.SpannableStringBuilder.sendTextChanged (SpannableStringBuilder.java:1212)
 
  at android.text.SpannableStringBuilder.replace (SpannableStringBuilder.java:582)
 
  at android.text.SpannableStringBuilder.delete (SpannableStringBuilder.java:230)
 
  at android.text.SpannableStringBuilder.delete (SpannableStringBuilder.java:229)
 
  at android.view.inputmethod.BaseInputConnection.deleteSurroundingText (BaseInputConnection.java:256)
 
  at com.android.internal.view.IInputConnectionWrapper.executeMessage (IInputConnectionWrapper.java:454)
 
  at com.android.internal.view.IInputConnectionWrapper$MyHandler.handleMessage (IInputConnectionWrapper.java:91)
 
  at android.os.Handler.dispatchMessage (Handler.java:105)
 
  at android.os.Looper.loop (Looper.java:156)
 
  at android.app.ActivityThread.main (ActivityThread.java:6605)
 
  at java.lang.reflect.Method.invoke (Native Method)
 
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:999)
 
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:889)

Meet Google Play's target API level requirement

Upload error on APK when trying to create a new release with target SDK 16

REF: https://developer.android.com/distribute/best-practices/develop/target-sdk

EditText turns red after some digit chars length

After length of 10, the background color turns red.

Considerations:
-ems property was removed on layout
-the length must not be limited

[crash] NoSuchMethodError for Android 2.2

Validate this error on AVD with Android 2.2

Reported on: https://play.google.com/apps/publish/?dev_acc=14210271903223439191#ErrorClusterDetailsPlace:p=br.com.mls.contactnumbersearch&et=CRASH&lr=LAST_7_DAYS&ecn=java.lang.NoSuchMethodError&tf=NumberSearchActivity.java&tc=br.com.mls.contactnumbersearch.NumberSearchActivity&tm=getPhoneContactList&nid&an&c&s=new_status_desc&ed=1476907605770

StackTrace:
java.lang.RuntimeException: An error occured while executing doInBackground() at android.os.AsyncTask$3.done(AsyncTask.java:200) at java.util.concurrent.FutureTask$Sync.innerSetException(FutureTask.java:273) at java.util.concurrent.FutureTask.setException(FutureTask.java:124) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:307) at java.util.concurrent.FutureTask.run(FutureTask.java:137) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1068) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:561) at java.lang.Thread.run(Thread.java:1096) Caused by: java.lang.NoSuchMethodError: java.lang.String.isEmpty at br.com.mls.contactnumbersearch.NumberSearchActivity.getPhoneContactList(NumberSearchActivity.java:184) at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground(NumberSearchActivity.java:82) at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground(NumberSearchActivity.java:1) at android.os.AsyncTask$2.call(AsyncTask.java:185) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305) ... 4 more

Add unit test for cachedContactsDiffers

NPE still happening for v1.0.2 (suspicious cursor == null):

Caused by: java.lang.NullPointerException: 
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.cachedContactsDiffers (NumberSearchActivity.java:107)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:98)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:91)

Force refresh contact in newer versions

This functionality is only available when the menu button is pressed (old devices)

UI test setup

Strategy to analyse Dev Play Store CSV data

For instance, think about what devices uninstalled the app and how long the app staid installed

Update Google Play Developer privacy policy

Reference:
https://support.google.com/googleplay/android-developer/answer/113469#privacy

[test] Loading contacts from Google account / SIM card

Release v6 Deploy

Increment targetSdk (+1)

Follow doc guide

Review:
https://developer.android.com/distribute/best-practices/develop/target-sdk#premarshmallow

NPE NumberSearchOperations

java.lang.NullPointerException: 
 
  at br.com.mls.contactnumbersearch.NumberSearchOperations.excludeNonNumberChars (NumberSearchOperations.java:71)
 
  at br.com.mls.contactnumbersearch.NumberSearchOperations.refreshContactDataList (NumberSearchOperations.java:59)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.refreshContactList (NumberSearchActivity.java:233)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.access$400 (NumberSearchActivity.java:35)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$1.onKey (NumberSearchActivity.java:82)
 
  at android.view.View.dispatchKeyEvent (View.java:9878)
 
  at android.view.ViewGroup.dispatchKeyEvent (ViewGroup.java:1667)

[crash] java.lang.NullPointerException br.com.mls.contactnumbersearch.NumberSearchActivity.excludeNonNumberChars

The method does not exist anymore: excludeNonNumberChars

java.lang.NullPointerException: 
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.excludeNonNumberChars (NumberSearchActivity.java:246)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.refreshContactList (NumberSearchActivity.java:232)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.access$2 (NumberSearchActivity.java:209)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$1.onKey (NumberSearchActivity.java:67)
 
  at android.view.View.dispatchKeyEvent (View.java:9241)
 
  at android.view.ViewGroup.dispatchKeyEvent (ViewGroup.java:1642)```

[crash] java.lang.NullPointerException - br.com.mls.contactnumbersearch.NumberSearchActivity.getPhoneContactList

Android version: 6.0
Device:
Oppo
CPH1701
3072 MB
Qualcomm MSM8940
720x1280
Supported

Caused by: java.lang.NullPointerException:

at br.com.mls.contactnumbersearch.NumberSearchActivity.getPhoneContactList (NumberSearchActivity.java:166)

at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:82)

at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:1)

at android.os.AsyncTask$2.call (AsyncTask.java:295)

at java.util.concurrent.FutureTask.run (FutureTask.java:237)

[crash] java.lang.NullPointerException in br.com.mls.contactnumbersearch.NumberSearchOperations$1.compare

No details found yet

Affected (incomplete info): CPH1803 (CPH1803)

Update targetSdkVersion

Received an "Action required: Update your app to comply with Google Play Permissions policy" due to a dependency with:

br.com.mls.contactnumbersearch READ_CALL_LOG

Looking at:

https://developer.android.com/reference/android/Manifest.permission#READ_CALL_LOG

we can see that this permission is packed together with android.permission.READ_CONTACTS if targetSdkVersion is 15 or lower

Consider copy/paste

If some number is pasted at the form field, the search action is not fired

Deployment process

• Remove android:debuggable
• provide android:versionCode
• provide andoid:versionName
• sign application

Improve layout

Study Material Design to see what's applicable for the current layout

Apply the updates

Refactoring from activity to operations

• Clean up
• Transfer some code from activity to operations
  ** extract the forward search (KeyListener) and backward search (TextWatcher) to semantic methods and verify moving them to NumberSearchOperations
  ** getSpecificContactListLength currently works only on forward search

[SamsumgY] Contact search

After turning back from some number typing (backspace), contacts does not shown accordinly

[crash] java.lang.RuntimeException Caused by: android.database.sqlite.SQLiteException

Caused by: android.database.sqlite.SQLiteException: 
 
  at android.database.DatabaseUtils.readExceptionFromParcel (DatabaseUtils.java:181)
 
  at android.database.DatabaseUtils.readExceptionFromParcel (DatabaseUtils.java:137)
 
  at android.content.ContentProviderProxy.query (ContentProviderNative.java:420)
 
  at android.content.ContentResolver.query (ContentResolver.java:478)
 
  at android.content.ContentResolver.query (ContentResolver.java:422)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.getPhoneContactList (NumberSearchActivity.java:198)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:101)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:93)

https://play.google.com/apps/publish/?account=8813204846538922230#AndroidMetricsErrorsPlace:p=br.com.mls.contactnumbersearch&appid=4975092852933790940&appVersion=PRODUCTION&lastReportedRange=LAST_14_DAYS&clusterName=apps/br.com.mls.contactnumbersearch/clusters/9008acc8&detailsAppVersion=PRODUCTION&detailsSpan=30

Update targetSdk to support deprecation notice

https://developer.android.com/distribute/best-practices/develop/target-sdk

Google Play will require that new apps target at least Android 8.0 (API level 26) from August 1, 2018, and that app updates target Android 8.0 from November 1, 2018.

[crash] android.database.CursorWindowAllocationException

Android 8.0
Nokia 5
2048MB
Qualcomm MSM8937 (Snapdragon 430)
8x ARM Cortex-A53 (1400 Mhz)

java.lang.RuntimeException: 
 
  at android.os.AsyncTask$3.done (AsyncTask.java:353)
 
  at java.util.concurrent.FutureTask.finishCompletion (FutureTask.java:383)
 
  at java.util.concurrent.FutureTask.setException (FutureTask.java:252)
 
  at java.util.concurrent.FutureTask.run (FutureTask.java:271)
 
  at android.os.AsyncTask$SerialExecutor$1.run (AsyncTask.java:245)
 
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1162)
 
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:636)
 
  at java.lang.Thread.run (Thread.java:764)
Caused by: android.database.CursorWindowAllocationException: 
 
  at android.database.CursorWindow.<init> (CursorWindow.java:137)
 
  at android.database.CursorWindow.<init> (Unknown Source)
 
  at android.database.CursorWindow$1.createFromParcel (CursorWindow.java:685)
 
  at android.database.CursorWindow$1.createFromParcel (CursorWindow.java:684)
 
  at android.database.BulkCursorDescriptor.readFromParcel (BulkCursorDescriptor.java:75)
 
  at android.database.BulkCursorDescriptor$1.createFromParcel (BulkCursorDescriptor.java:34)
 
  at android.database.BulkCursorDescriptor$1.createFromParcel (BulkCursorDescriptor.java:31)
 
  at android.content.ContentProviderProxy.query (ContentProviderNative.java:421)
 
  at android.content.ContentResolver.query (ContentResolver.java:756)
 
  at android.content.ContentResolver.query (ContentResolver.java:705)
 
  at android.content.ContentResolver.query (ContentResolver.java:663)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity.getPhoneContactList (NumberSearchActivity.java:198)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:101)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:93)
 
  at android.os.AsyncTask$2.call (AsyncTask.java:333)
 
  at java.util.concurrent.FutureTask.run (FutureTask.java:266)

Menu Item to update contacts

Due to SharedPrefs implementation, there's the need to have a command to force the contacts update

[crash] Caused by: java.lang.SecurityException:

Tests revealed App crashes before open

Caused by: java.lang.NullPointerException: at br.com.mls.contactnumbersearch.NumberSearchActivity$2.cachedContactsDiffers

Android 5.1
Samsung
Galaxy Grand Prime
1024 MB + 2 more
Qualcomm MSM8216 + 3 more
540x960

java.lang.RuntimeException: 
 
  at android.os.AsyncTask$3.done (AsyncTask.java:304)
 
  at java.util.concurrent.FutureTask.finishCompletion (FutureTask.java:355)
 
  at java.util.concurrent.FutureTask.setException (FutureTask.java:222)
 
  at java.util.concurrent.FutureTask.run (FutureTask.java:242)
 
  at android.os.AsyncTask$SerialExecutor$1.run (AsyncTask.java:231)
 
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1112)
 
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:587)
 
  at java.lang.Thread.run (Thread.java:818)
Caused by: java.lang.NullPointerException: 
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.cachedContactsDiffers (NumberSearchActivity.java:108)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:100)
 
  at br.com.mls.contactnumbersearch.NumberSearchActivity$2.doInBackground (NumberSearchActivity.java:93)
 
  at android.os.AsyncTask$2.call (AsyncTask.java:292)
 
  at java.util.concurrent.FutureTask.run (FutureTask.java:237)

Test i18n

Test the application for the 3 supported languages

Sorting problem when contacts by shared preferences

Maybe it happens by the way contacts are added to shared prefs

[test] Tablet App Layout

Choose one AVD as tablet to test the application

[deployment] Prepare promotional materials

• Application summary text (promotional text)
  -Application screenshots

Reduce contacts load time

Performance issues related to contacts retrieve:

• Must implement some mechanism to reduce load time
  or
• Change the loading contacts strategy