Feature Request: Integration with corfu-doc

[manateelazycat]

Feature Request: Integration with corfu-doc

[manateelazycat]

Thanks for feedback, I was so tire recently.

I will have a look when I have free time.

Any PR are welcome.

[anonimitoraf]

I see. Cool, I'll see if I can fix it!

[manateelazycat]

We should cache document in

lsp-bridge//core/handler/completion.py

Line 34 in e8ce421

def process_response(self, response: dict) -> None:

Not send all document from Python to Elisp.

We just need fetch one document when user switch candiate in corfu.

[anonimitoraf]

Sorry, I don't understand. Are you saying that's potentially what's causing corfu-doc to not work?

[manateelazycat]

Sorry, I don't understand. Are you saying that's potentially what's causing corfu-doc to not work?

Becasue we did not parse doc content from textDocument/completion response, it's not a bug of corfu-doc

[anonimitoraf]

AH! I see https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/ (the field documentation is missing). I'll try it out and make a PR, thanks!

[anonimitoraf]

Actually, sorry I'm a bit lost on how I'd go about this.

My thoughts:

• Somehow register some sort of hook (via corfu or company) for when the selected candidate is changed - TODO I need to find out how
• Execute a "hover" request
• Somehow inject the "hover" response into the completion candidates list - TODO I need to find out how

Is this similar to what you were thinking?

[manateelazycat]

1. You need find out how to hook corfu candidate selected
2. Then send completionitem/resolve request to python, details see https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItem_resolve
3. After receive response of completionitem/resolve, pick up documentation property from response json, show with corfu-doc

[manateelazycat]

@anonimitoraf Has fixed by 779bb42

Need install corfu-doc.

[anonimitoraf]

Oh damn thanks! Will learn from your code