Giter Site home page Giter Site logo

Comments (8)

manateelazycat avatar manateelazycat commented on September 24, 2024

这个 snippet 本身的内容是对的吗?

from lsp-bridge.

zijianyue avatar zijianyue commented on September 24, 2024

本身内容是对的,clangd提供的
image
我看它缩进成这样的原因 应该是for (range-declaration : range-expression)这个内容导致的,因为保持这个内容不变的话,我用TAB键去缩进‘}’也是在错误的位置上动不了,但是我如果把for (range-declaration : range-expression)改成正确的语法,
比如for (auto& it : edgeSet.GetAllEdges())这样,再用TAB去缩进'}'就正常了。
但是lsp-mode的snippet补全在处理这个case时是正确的,如下图所示,回车补全候选,‘}’ 缩进位置就是对的
image
image

from lsp-bridge.

manateelazycat avatar manateelazycat commented on September 24, 2024

你试过 emacs -Q 只加载 lsp-bridge 做过对比测试吗?

from lsp-bridge.

zijianyue avatar zijianyue commented on September 24, 2024

刚刚试了一下,现象不太一样,在emacs -Q下snippet补全时右边的}看起来就没有对其缩进做什么特殊处理,都是在行首位置
image
image

from lsp-bridge.

manateelazycat avatar manateelazycat commented on September 24, 2024

emacs -Q 可以测试一下 lsp-mode 吗? 因为 lsp-bridge 的snippet展开是 yasnippet 的函数去展开的。

我估计是 yasnippet 配置不同造成的。

我晚上有空也验证一下。

from lsp-bridge.

zijianyue avatar zijianyue commented on September 24, 2024

lsp-mode的结果
image

配置如下
(add-to-list 'load-path "/home/gezijian/.emacs.d/elpa/lsp-mode-20240130.1829")
(add-to-list 'load-path "/home/gezijian/.emacs.d/elpa/dash-20240103.1301")
(add-to-list 'load-path "/home/gezijian/.emacs.d/elpa/f-20231219.750")
(add-to-list 'load-path "/home/gezijian/.emacs.d/elpa/s-20220902.1511")
(add-to-list 'load-path "/home/gezijian/.emacs.d/elpa/ht-20230703.558")
(add-to-list 'load-path "/home/gezijian/.emacs.d/elpa/lv-20200507.1518")
(add-to-list 'load-path "/home/gezijian/.emacs.d/elpa/markdown-mode-20240107.831")
(add-to-list 'load-path "/home/gezijian/.emacs.d/elpa/spinner-1.7.4")
(add-to-list 'load-path "/home/gezijian/.emacs.d/site-lisp/company-mode")
(add-to-list 'load-path (concat user-emacs-directory "site-lisp/other"))
(require 'company)
(require 'yasnippet)
(require 'lsp-mode)
(require 'lsp-completion)
(global-company-mode t)
(yas-global-mode t)

启动lsp-mode后还要开启一下lsp-completion-mode

from lsp-bridge.

manateelazycat avatar manateelazycat commented on September 24, 2024

研究了一下 lsp-mode, 需要移植 https://github.com/emacs-lsp/lsp-mode/pull/1939/files 这个补丁到 lsp-bridge 中。

lsp-mode 在展开 snippet 后, 接着对展开的 snippet 进行了格式化操作。

from lsp-bridge.

manateelazycat avatar manateelazycat commented on September 24, 2024

我看了 lsp-mode 的方法, 写的太绕了。

6c064de 这个补丁应该修复了这个问题:

  1. 展开 snippet 之间记录当前光标的缩进值
  2. 展开 snippet 后, 跳转到 yas-snippet-end, 并让 snippet 最后一行的缩进和第一行缩进一致

from lsp-bridge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.