manc/kohana-log-database

A database log writer for Kohana 3.3

kohana-log-database's Issues

Allow NULL for file- and line-column in schema

You should update your DB schema so that null is allowed for the file- and line-columns. In the event of a critical error where Kohana_Core's shutdown_handler-method is executed, the raw HTML source code is displayed as the page content. The DB::insert-method fails, echoing the error message in the raw HTML code and there are no exception handlers left to catch that exception.

For instance, try having Allow Null set to false for file- and line-columns and typing this somewhere in your code:

<?php echo echo 'something'; ?>

An alternative way to solve this (and perhaps safer) is to have a try and catch-block inside the write-method of the Log_Database-class. The catch-statement could catch Database_Exception, then do nothing. In case of a catastrophic failure, at least the insert statements (if they fail) won't make it worse.

var_dump?

Thanks for this module.

But what's with the var_dump($messages); in Database.php's write method? Kohana's default error page looks pretty bad with that huge cluster of text at the top.

I'm guessing this is for debugging and that you forgot to remove this line. Amirite? :-)