manifoldxyz/royalty-registry-client

royalty-registry-client's Issues

String on ETH value input

Hi fellows,

I would like to contribute here and found a possible issue on the ETH value input (Lookup Bar).

I noticed that it's accepting any character in the end of the value:

Is that the suppose way to work?

I can open a PR fix with unit tests, I just need to understand a little more about the needs. :)

For "Token Contract Default Royalty" UI asks for "Basis Points" but this concept isn't sufficiently explained with Example: 10% = 1000 Basis Points.

As a user I want to understand why I can't simply set 10% = 1000 Basis Points. If the later statements is indeed reality, then why can't I straight up set percentages? So what is this concept of Basis Points? Where can I look it up? The FAQ makes no mention of the concept.

"Access Denied" trying to edit override?

Hi, the UI froze after testing a RBP over 10000 (to see if it would throw an error in the wallet since the UI didn't convey a maximum) and when I refreshed and added token address it shows an "Access Denied" screen (even with wallet still disconnected and re-connected)

Explain "Royalty Basis Points" range

Hi, it would be helpful to know that 1000 points means 10%. RBP is not explained in the FAQ and the UI even accepts values higher than 10000.

"An error occurred" imprecise error message upon deploying overwrite

Transaction Hash: 0xe096349531a08472f42daa2e116ee29cece68d42116e3364b1f7aed59e7ef2a9Etherscan: https://etherscan.io/tx/0xe096349531a08472f42daa2e116ee29cece68d42116e3364b1f7aed59e7ef2a9Confirming...Confirmed.Contract Address: 0x87148545B9Fe13B4b5a32d1719D3BD9c936D577BEtherscan: https://etherscan.io/address/0x87148545B9Fe13B4b5a32d1719D3BD9c936D577B
An error occured.

What should I do now?

Edit: After deleting my cookies, this error resolves and the website now shows a valid state:

I saw a third-party cookie issue with pendingTransactionConformation or something. So you should look into that. I'm in Mozilla Firefox Dev edition

Access Denied : Need more information

When i am trying to configure the royalty for one of my token contract on Mainnet, I am getting Access Denied message.

Is it due to me not having a royalty override contract and not calling the setRoyaltyLookupAddress()? I am using the address which deployed the contract initially. though my contract doesn't have support for openzepplin Ownable.

But a bit more information on the above screen as to why the Access was denied would help everyone in understanding the issue better.

Gnonsis Safe Support

Supporting Gnosis Safe wallets on the frontend would be very helpful.

Generally, it is best-practice for the owner/admin of a given contract to be using a multi-sig wallet, such as Gnosis Safe. Thus, a common use-case when assigning overrides for a contract would be to connect to the Royalty Registry frontend with a Gnosis Safe.

An additional driver: The fact that the registry uses a proxy pattern makes it quite difficult for anyone non-technical to properly configure their override via contract calls directly. Knowledge of which contract to integrate with, and which ABI to use is critical when not using the frontend.

Cc @jakerockland

Royalty register