Layout can be borked

[manishearth]

Layout can be borked

[mathvav]

Whoops, that being overlooked is my fault. Is the issue in the popups, list, or both?

[Manishearth]

No, in the popup. My fault. Why would I call you a dummy? :P

[mathvav]

@Manishearth I just saw that in my inbox and was confused at first (although penguins can be silly sometimes). But yeah, I should've noticed this, too. I'm working on a fix now...

[Manishearth]

\o/ thanks

[mathvav]

Wow that reply was faster than my Notepad++ update!

Anyway... working on it, but the checkbox is being a pain. The buttons look great formatted, but the checkbox is either minimum width (to fit its contents) OR it is 60 px too wide.

I put in a fixed width, but that defeats the whole purpose of a table! Plus, it still is about 1 px too high...

For the work in progress, I created a commit for until I figure out how to fix this: https://github.com/Annonomus-Penguin/AnnoTabe/commit/b3d2ea0700b1702c6386826447a08d5ca44a4357

[Manishearth]

Hah. These days I usually jump to Github notifications.

That checkbox was annoying in the past. Not sure how to fix that :/

[mathvav]

I'd change the label to a div if I knew a click anywhere would act as a click on the checkbox... I might have to make some JS solution. Does that sound to hackety to you?

[Manishearth]

Meh, hackety is okay :p

[mathvav]

Okay, will work on it.... sorry for the emails you must be getting hehe 😄

[Manishearth]

No probs, thanks for working on this :D

[mathvav]

Sigh... I hate Chrome sometimes.

Refused to execute inline event handler because it violates the following Content Security Policy directive: "script-src 'self' chrome-extension-resource:". Either the 'unsafe-inline' keyword, a hash ('sha256-...'), or a nonce ('nonce-...') is required to enable inline execution.

The div didn't work but a button did... and then Chrome betrayed me :p

[Manishearth]

You need to register the handler in popup.js or something.

[mathvav]

I realize that now... I don't work in extensions that often.

[Manishearth]

Hah. Neither do I, I just keep googling things (this particular annoyance I remembered since it crops up often)

[mathvav]

OMG it actually worked! Yay! That's a first haha

Yeah: development time - 90% on Google, 10% coding (and 95% of my time is spent doing two or three lines)

This should work: https://github.com/Annonomus-Penguin/AnnoTabe/commit/11868c9330999f5295563c67e151ce3f060782c4

[Manishearth]

Alrighty! I can't test it right now, I'm writing a term paper and shouldn't start poking programs lest I get sucked in, so .... ;P

(just PR and I'll have a look tomorrow -- bug me if I don't get to it)

[mathvav]

No problem there, I get sucked in too. Pull request above when you get time, no hurry of course.