manok2912/f1-3-c2p1-colmar-academy

f1-3-c2p1-colmar-academy's Issues

Simplify. Comments

https://github.com/manok2912/f1-3-c2p1-colmar-academy/blob/master/New%20folder/index.html#L56

Adding in comments to your code really helps obviously organize it, both for you, and newcomers looking at the code.

Great! Video Implementation

https://github.com/manok2912/f1-3-c2p1-colmar-academy/blob/master/New%20folder/index.html#L171

Good work, the video works and scales quite well.

Great! Nav Bar

https://github.com/manok2912/f1-3-c2p1-colmar-academy/blob/master/New%20folder/index.html#L15-L31

Your nav bar transitions flawlessly from desktop to mobile sizing, good work. Consider reorganizing it a bit though into a mobile div and a desktop div.

SUMMARY

Grade: Satisfactory

Summary:
Your code here is functional within the spec, overall a good job. Your implementation of mobile resizing works well as does the typical page layout. Your organization however needs some work, put some time into implementing consistent spacing and comments in your code. This will make it much easier to keep organized and read through your code. Great work on this, I can tell it took a significant amount of time and effort on your part.

Once your organizational kinks are worked out, make sure to try adding some personal flair to the site. You can check out this site to get some ideas of modern web design patterns. http://www.webdesign-inspiration.com/web-designs/style/modern

Great! Side Bar

https://github.com/manok2912/f1-3-c2p1-colmar-academy/blob/master/New%20folder/index.html#L95

Your sidebar transitions flawlessly from desktop to mobile sizing, good work.

Simplify. CSS Organization

https://github.com/manok2912/f1-3-c2p1-colmar-academy/blob/master/New%20folder/style/index.css#L7

Your CSS is irregular in its indentation and spacing. It also seems to lack comments which are essential for projects of this size. https://google.github.io/styleguide/htmlcssguide.html