manok2912/prj-rev-bwfs-tea-cozy

prj-rev-bwfs-tea-cozy's Issues

Important!

Center this content on all viewport sizes with the margin: auto property.
https://github.com/manok2912/prj-rev-bwfs-tea-cozy/blob/master/mytimes/style.css#L41

Important!

Use alt attributes with your img tags: http://webaim.org/techniques/alttext/
https://github.com/manok2912/prj-rev-bwfs-tea-cozy/blob/master/mytimes/index.html#L29

Great!

I like that you used page anchors here.
https://github.com/manok2912/prj-rev-bwfs-tea-cozy/blob/master/mytimes/index.html#L11-L13

SUMMARY

Grade: Meets Expectations

Summary: Good job using flexbox to successfully replicate a very challenging layout! I was pleased to see the semantic ​nav and header tags being properly used.You structured your HTML very coherently which makes working with flexbox much more straightforward and I noticed you even included page anchors in your nav. What's more, you made excellent use of the cascade and classes to avoid redundant code.

Moving forward, I encourage you to be more mindful of the class names that you use. For more info on this, please see the relevant issue I opened up in your repo.

I know flexbox is a tricky concept at first so if you wanted some more review in this regard, I highly recommend Flexbox Zombies. It is entirely free if you sign up: http://flexboxzombies.com/courses/139425/lectures/2547657

This tutorial is also a great refresher if you feel like you need it: https://internetingishard.com/html-and-css/flexbox/

Overall, you did an excellent job on this project! Keep up the hard work Manoj !

Important!

Center this content with the margin: auto property.
https://github.com/manok2912/prj-rev-bwfs-tea-cozy/blob/master/mytimes/style.css#L52

Important!

Class names should be "describing but not specifying". For maintainability and readability, I recommend using less cryptic names. https://css-tricks.com/semantic-class-names/
https://github.com/manok2912/prj-rev-bwfs-tea-cozy/blob/master/mytimes/index.html#L18

Great!

Great use of the cascade to keep you code DRY (Don't Repeat Yourself). https://internetingishard.com/html-and-css/hello-css/#the-cascade
https://github.com/manok2912/prj-rev-bwfs-tea-cozy/blob/master/mytimes/style.css#L1-L7

Great!

This is well organized and the semantic header and nav tags are used correctly.
https://github.com/manok2912/prj-rev-bwfs-tea-cozy/blob/master/mytimes/index.html#L7-L16